Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the kedro pandera infer CLI, add log where the file is written to #9

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Improve the kedro pandera infer CLI, add log where the file is written to #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6dc82c5
Improve the `kedro pandera infer` CLI, add log where the file is writ…
noklam Jul 30, 2023
b743d06
Merge branch 'main' into feat/improve-infer-cli
noklam Jul 31, 2023
4dc97fa
remove extra Makefile command
noklam Jul 31, 2023
34d7eaf
Merge branch 'feat/improve-infer-cli' of https://github.com/noklam/ke…
noklam Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,3 @@ help:
# "make mode" option. $(O) is meant as a shortcut for $(SPHINXOPTS).
%: Makefile
@$(SPHINXBUILD) -M $@ "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)

test:
pytest

Comment on lines -21 to -24
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it for now, I'll create a separate PR to create all these command in the appropriate directory.

1 change: 1 addition & 0 deletions kedro_pandera/framework/cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def infer_schema(
data_schema.to_script(filepath)
else:
data_schema.to_yaml(filepath)
click.secho(f"The schema is written to {filepath}", fg="green")

# TODO: should we add a metadata key to the catalog file?
# I hate the idea of modifying a config flag on the fly,
Expand Down
Loading