Fix : Apidae Trek parser now ignores when no linestring in GPX #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix_apidae_parser #4187 +/- ##
==================================================
Coverage 98.38% 98.38%
==================================================
Files 267 267
Lines 20904 20905 +1
==================================================
+ Hits 20567 20568 +1
Misses 337 337 ☔ View full report in Codecov by Sentry. |
Geotrek-admin
|
||||||||||||||||||||||||||||
| Project |
Geotrek-admin
|
| Branch Review |
refs/pull/4187/merge
|
| Run status |
|
| Run duration | 01m 56s |
| Commit |
|
| Committer | Marc-Antoine Dupré |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
22
|
| View all changes introduced in this branch ↗︎ | |
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_file_wo_extension
branch
2 times, most recently
from
7a27012
to
d1ec3e9
Compare
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_handle_no_linestring
branch
from
3151646
to
f244a3e
Compare
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_file_wo_extension
branch
from
d1ec3e9
to
642b30c
Compare
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_handle_no_linestring
branch
from
f244a3e
to
402eca1
Compare
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_file_wo_extension
branch
from
642b30c
to
54c8cfe
Compare
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_handle_no_linestring
branch
from
402eca1
to
5a7c049
Compare
submarcos
reviewed
Sep 3, 2024
juggler31
approved these changes
Sep 3, 2024
Previously caused a crash.
marcantoinedupre
force-pushed
the
fix_apidae_trek_parser_handle_no_linestring
branch
from
5a7c049
to
7acdf81
Compare
Base automatically changed from
fix_apidae_trek_parser_file_wo_extension
to
fix_apidae_parser
September 3, 2024 14:27
marcantoinedupre
deleted the
fix_apidae_trek_parser_handle_no_linestring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction pour parser Trek Apidae. Reste à :
Checklist
My code respects the Definition of done available in the Development section of the documentationI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationand references associated issuesThe title of my PR mentionned the issue associated