Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge main to dev #4800

Merged
merged 3 commits into from
Oct 1, 2024
Merged

merge main to dev #4800

merged 3 commits into from
Oct 1, 2024

Conversation

RamRamez
Copy link
Collaborator

@RamRamez RamRamez commented Oct 1, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced data fetching for the staking pool, improving accuracy and efficiency.
    • Updated APR calculations with error handling for better reliability.
  • Bug Fixes

    • Resolved issues related to network references in data queries.
  • Chores

    • Updated version number to 2.32.2 in the package configuration.

…uld-show-up-when-connected-to-any-chain-#4593

Givfarm aprs on other chains should show up when connected to any chain
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giveth-dapps-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 11:54am

Copy link
Contributor

coderabbitai bot commented Oct 1, 2024

Walkthrough

The pull request introduces a version update in the package.json file from 2.32.1 to 2.32.2, with no changes to scripts or dependencies. Additionally, the useStakingPool hook has been modified to improve data fetching and processing by referencing the network configuration directly, rather than the chain ID. The logic for calculating APR and updating user stake information has also been adjusted accordingly.

Changes

File Change Summary
package.json Updated version from 2.32.1 to 2.32.2 with no changes to scripts or dependencies.
src/hooks/useStakingPool.ts Modified data fetching logic to use poolStakingConfig.network, adjusted APR calculation, and updated user stake info handling.

Possibly related PRs

  • Merge Main to Develop #4457: The package.json file in this PR also includes a version change, specifically from 2.29.0 to 2.29.2, which is directly related to the version update in the main PR from 2.32.1 to 2.32.2.

Poem

In the garden of code, a change took flight,
A version updated, shining bright.
With hooks now fetching, swift and clear,
The rabbit hops on, spreading cheer!
Data flows smoothly, like a gentle stream,
In the world of code, we chase our dream! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e0d4ab0 and cefab3e.

📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/hooks/useStakingPool.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • package.json
🔇 Additional comments (2)
src/hooks/useStakingPool.ts (2)

35-37: LGTM! Query key and function updated correctly.

The changes to the query key and function are well-implemented:

  1. Using poolStakingConfig.network instead of chain?.id is consistent with the removal of chain from useAccount.
  2. The query function remains asynchronous, which is appropriate for fetching subgraph data.

These updates ensure that the correct network is referenced for the query, maintaining the functionality of the hook.


33-33: LGTM! Verify removal of chain.

The change to only destructure address from useAccount is correct and aligns with the updated usage in the component. However, please ensure that chain is not used elsewhere in the component, as its removal might affect other parts of the code.

Let's verify if chain is used elsewhere in this file:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MohammadPCh MohammadPCh merged commit 78554a2 into develop Oct 1, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

2 participants