Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applet.display.hd44780: modify to use port groups. #604

Merged
merged 1 commit into from
Jun 27, 2024
Merged

applet.display.hd44780: modify to use port groups. #604

merged 1 commit into from
Jun 27, 2024

Conversation

q3k
Copy link
Contributor

@q3k q3k commented Jun 26, 2024

Part of #599

I feel like in this case it would be better to keep calling {rs,rw,d,e}_t instead of {rs,rw,d,e}_buffer just to have an easier to review diff..?

@q3k q3k requested a review from whitequark as a code owner June 26, 2024 22:56
whitequark
whitequark approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@whitequark whitequark enabled auto-merge June 26, 2024 23:13
auto-merge was automatically disabled June 26, 2024 23:50

Head branch was pushed to by a user without write access

@q3k q3k force-pushed the q3k/hd44780-padless branch from aeba384 to 7454be0 Compare June 26, 2024 23:50
@whitequark whitequark enabled auto-merge June 26, 2024 23:50
@q3k
Copy link
Contributor Author

q3k commented Jun 26, 2024 •
edited
Loading

Need another automerge/approval after rebase (flaked on Check for dead links in CI before that…).

EDIT: you were faster.

@whitequark whitequark added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@whitequark whitequark added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@whitequark whitequark added this pull request to the merge queue Jun 27, 2024
Merged via the queue into GlasgowEmbedded:main with commit 97a8794 Jun 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q3k @whitequark