This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Added extra rotations for 1.8 #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.degree = degree; | ||
| } | ||
|
|
||
| public int getDegree() { |
| this.degree = degree; | ||
| } | ||
|
|
||
| public double getDegree() { |
| @@ -5,26 +5,37 @@ | |||
| * <p> | |||
| * It represents how something is viewed, as opposed to cardinal directions. | |||
There was a problem hiding this comment.
Missing documentation on deprecation reason.
/**
* ...
* @deprecated This does not handle the various degrees of rotation available
*/
|
Is this API used where arbitrary rotation angles are possible? (given the deprecation of enum values in favor of |
deathcap
referenced
this pull request
in GlowstoneMC/Glowstone
Apr 6, 2015
…nstead of doubles Modification to: #514 Continuation of @wow4201's Item Frames instead of taking the Glowkit change to add getRotationAngle() etc.: https://github.com/GlowstoneMC/Glowkit/pull/52 Add degree-based rotations change the implementation to use new rotation values in the enum: GlowstonePlusPlus/Glowkit-Legacy@b6c156d Support the new Rotation values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited by turt2live
Related links: