This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
forked from Bukkit/Bukkit
-
Notifications
You must be signed in to change notification settings - Fork 12
Added extra rotations for 1.8 #52
Open
Aaron1011
wants to merge
4
commits into
GlowstoneMC:master
Choose a base branch
from
Aaron1011:rotation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,15 +25,35 @@ public interface ItemFrame extends Hanging { | |
/** | ||
* Get the rotation of the frame's item | ||
* | ||
* @deprecated This does not handle the various degrees of rotation available. | ||
* @return the direction | ||
*/ | ||
@Deprecated | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing documentation for deprecation (see last comment) |
||
public Rotation getRotation(); | ||
|
||
/** | ||
* Get the rotation of the frame's item | ||
* | ||
* @return the rotation, in degrees | ||
*/ | ||
public double getRotationAngle(); | ||
|
||
/** | ||
* Set the rotation of the frame's item | ||
* | ||
* @param rotation the new rotation | ||
* @deprecated This does not handle the various degrees of rotation available. | ||
* @throws IllegalArgumentException if rotation is null | ||
*/ | ||
@Deprecated | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing documentation for deprecation (see last comment) |
||
public void setRotation(Rotation rotation) throws IllegalArgumentException; | ||
|
||
/** | ||
* Set the rotation of the frame's item, in degrees | ||
* | ||
* Values will be rounded to the closest 45-degree interval | ||
* | ||
* @param rotation the new rotation (0 degrees is north) | ||
*/ | ||
public void setRotationAngle(double rotation); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing documentation on deprecation reason.