chore(kfp): bump to python 3.9 #2078
Conversation
Signed-off-by: David van der Spek <[email protected]>
google-oss-prow
bot
requested review from
chensun,
connor-mccarthy and
zijianjoy
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DavidSpek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @davidspek. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -156,7 +156,7 @@ presubmits: | |||
| run_if_changed: "^(components/.*\\.yaml)|(test/presubmit-component-yaml.sh)|(sdk/python/.*)$" | |||
| spec: | |||
| containers: | |||
| - image: python:3.7 | |||
| - image: python:3.9 | |||
There was a problem hiding this comment.
In places where we are testing potential user code paths, I think it still makes sense to test this on the lowest (least feature-rich) version of Python supported by the KFP SDK: Python 3.7. This is the most aggressive form of testing.
Practically speaking, this applies for every presubmit that invokes KFP SDK code.
There was a problem hiding this comment.
Would you mind pushing a commit to my branch here that has the changes you have in mind. You're obviously much more aware of the current testing setup and which things should change and which ones shouldn't. You should be able to push to my branch since I have allowed maintainers t commit to it.
There was a problem hiding this comment.
Hey, David. I added comments throughout for where I think we should not bump to Python 3.9 and cc'd others where I do not have enough information to say. To unblock yourself, I recommend ignoring the places where we are waiting on input from others. We can always come back to them.
| @@ -327,7 +327,7 @@ presubmits: | |||
| run_if_changed: "^(sdk/python/.*)|(test/presubmit-test-sdk-upgrade.sh)$" | |||
| spec: | |||
| containers: | |||
| - image: python:3.7 | |||
| - image: python:3.9 | |||
There was a problem hiding this comment.
I think we should leave this as python:3.7 since it is a test.
| @@ -317,7 +317,7 @@ presubmits: | |||
| spec: | |||
| containers: | |||
| # run on the lowest version of Python (with the least features) for most aggressive testing | |||
| - image: python:3.7 | |||
| - image: python:3.9 | |||
There was a problem hiding this comment.
I think we should leave this as python:3.7 since it is a test.
| @@ -254,7 +254,7 @@ presubmits: | |||
| - master | |||
| spec: | |||
| containers: | |||
| - image: python:3.7 | |||
| - image: python:3.9 | |||
There was a problem hiding this comment.
I think we should leave this as python:3.7 since it is a test.
| - name: kubeflow-pipelines-integration-v2 | ||
| run_if_changed: "^(samples/core/(parameterized_tfx_oss|dataflow)/.*)$" | ||
| cluster: build-kubeflow | ||
| decorate: true | ||
| spec: | ||
| containers: | ||
| - image: python:3.7 | ||
| - image: python:3.9 |
There was a problem hiding this comment.
cc @chensun for whether this is safe to bump to python:3.9
| @@ -188,19 +188,19 @@ presubmits: | |||
| optional: true | |||
| spec: | |||
| containers: | |||
| - image: python:3.7 | |||
| - image: python:3.9 | |||
There was a problem hiding this comment.
I think we should leave this as python:3.7 since it is a test.
| @@ -176,10 +176,10 @@ presubmits: | |||
| run_if_changed: "^(backend/src/apiserver/visualization/.*)|(test/presubmit-backend-visualization.sh)$" | |||
| spec: | |||
| containers: | |||
| - image: python:3.8 | |||
| - image: python:3.9 | |||
There was a problem hiding this comment.
cc @chensun for whether this is safe to bump to python:3.9
| @@ -156,7 +156,7 @@ presubmits: | |||
| run_if_changed: "^(components/.*\\.yaml)|(test/presubmit-component-yaml.sh)|(sdk/python/.*)$" | |||
| spec: | |||
| containers: | |||
| - image: python:3.7 | |||
| - image: python:3.9 | |||
There was a problem hiding this comment.
Hey, David. I added comments throughout for where I think we should not bump to Python 3.9 and cc'd others where I do not have enough information to say. To unblock yourself, I recommend ignoring the places where we are waiting on input from others. We can always come back to them.
| @@ -7,7 +7,7 @@ postsubmits: | |||
| decorate: true | |||
| spec: | |||
| containers: | |||
| - image: python:3.7 | |||
| - image: python:3.9 | |||
There was a problem hiding this comment.
cc @chensun for whether this is safe to bump to python:3.9
| @@ -13,7 +13,7 @@ periodics: | |||
| workdir: true | |||
| spec: | |||
| containers: | |||
| - image: python:3.7-slim | |||
| - image: python:3.9-slim | |||
There was a problem hiding this comment.
cc @chensun for whether this is safe to bump to python:3.9
This PR updates the default python version used by Kubeflow Pipelines to 3.9 since 3.7 is now EOL and causing conflicts with dependencies (such as
ml-metadata). This should solve the recent test failures on the master branch./cc @chensun @zijianjoy @connor-mccarthy