Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kfp): bump to python 3.9 #2078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −16
Open

chore(kfp): bump to python 3.9 #2078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-periodics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ periodics:
workdir: true
spec:
containers:
- image: python:3.7-slim
- image: python:3.9-slim
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @chensun for whether this is safe to bump to python:3.9

imagePullPolicy: Always
command:
- "./test/kfp-functional-test/kfp-functional-test.sh"
Expand Down
2 changes: 1 addition & 1 deletion prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-postsubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ postsubmits:
decorate: true
spec:
containers:
- image: python:3.7
- image: python:3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @chensun for whether this is safe to bump to python:3.9

command:
- ./backend/src/v2/test/integration-test.sh
annotations:
Expand Down
28 changes: 14 additions & 14 deletions prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ presubmits:
args:
# We cannot call the shell script directly because the shebang in script is /bin/bash,
# but the bash:alpine3.14 image has its bash in /usr/local/bin/bash.
- ./manifests/gcp_marketplace/test/presubmit.sh
- ./manifests/gcp_marketplace/test/presubmit.sh
- name: kubeflow-pipeline-upgrade-test
run_if_changed: "^(backend/.*)|(manifests/kustomize/.*)|(test/upgrade.*)$"
cluster: build-kubeflow
Expand Down Expand Up @@ -156,7 +156,7 @@ presubmits:
run_if_changed: "^(components/.*\\.yaml)|(test/presubmit-component-yaml.sh)|(sdk/python/.*)$"
spec:
containers:
- image: python:3.7
- image: python:3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In places where we are testing potential user code paths, I think it still makes sense to test this on the lowest (least feature-rich) version of Python supported by the KFP SDK: Python 3.7. This is the most aggressive form of testing.

Practically speaking, this applies for every presubmit that invokes KFP SDK code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind pushing a commit to my branch here that has the changes you have in mind. You're obviously much more aware of the current testing setup and which things should change and which ones shouldn't. You should be able to push to my branch since I have allowed maintainers t commit to it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, David. I added comments throughout for where I think we should not bump to Python 3.9 and cc'd others where I do not have enough information to say. To unblock yourself, I recommend ignoring the places where we are waiting on input from others. We can always come back to them.

command:
- ./test/presubmit-component-yaml.sh

Expand All @@ -176,10 +176,10 @@ presubmits:
run_if_changed: "^(backend/src/apiserver/visualization/.*)|(test/presubmit-backend-visualization.sh)$"
spec:
containers:
- image: python:3.8
- image: python:3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @chensun for whether this is safe to bump to python:3.9

command:
- ./test/presubmit-backend-visualization.sh

- name: kubeflow-pipelines-samples-v2
cluster: build-kubeflow
decorate: true
Expand All @@ -188,19 +188,19 @@ presubmits:
optional: true
spec:
containers:
- image: python:3.7
- image: python:3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave this as python:3.7 since it is a test.

command:
- ./backend/src/v2/test/sample-test.sh
skip_branches:
- ^sdk\/release-1.*$

- name: kubeflow-pipelines-integration-v2
run_if_changed: "^(samples/core/(parameterized_tfx_oss|dataflow)/.*)$"
cluster: build-kubeflow
decorate: true
spec:
containers:
- image: python:3.7
- image: python:3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @chensun for whether this is safe to bump to python:3.9

command:
- ./backend/src/v2/test/integration-test.sh

Expand All @@ -221,7 +221,7 @@ presubmits:
- master
spec:
containers:
- image: python:3.7
- image: python:3.9
command:
- ./test/presubmit-isort-sdk.sh
- name: kubeflow-pipelines-sdk-yapf
Expand All @@ -232,7 +232,7 @@ presubmits:
- master
spec:
containers:
- image: python:3.7
- image: python:3.9
command:
- ./test/presubmit-yapf-sdk.sh
- name: kubeflow-pipelines-sdk-docformatter
Expand All @@ -243,7 +243,7 @@ presubmits:
- master
spec:
containers:
- image: python:3.7
- image: python:3.9
command:
- ./test/presubmit-docformatter-sdk.sh
- name: kubeflow-pipelines-sdk-execution-tests
Expand All @@ -254,7 +254,7 @@ presubmits:
- master
spec:
containers:
- image: python:3.7
- image: python:3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave this as python:3.7 since it is a test.

command:
- ./test/presubmit-sdk-execution-tests.sh

Expand Down Expand Up @@ -298,7 +298,7 @@ presubmits:
- image: python:3.10
command:
- ./test/presubmit-test-kfp-kubernetes-library.sh

- name: kfp-kubernetes-test-python311
cluster: build-kubeflow
decorate: true
Expand All @@ -317,7 +317,7 @@ presubmits:
spec:
containers:
# run on the lowest version of Python (with the least features) for most aggressive testing
- image: python:3.7
- image: python:3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave this as python:3.7 since it is a test.

command:
- ./test/presubmit-test-run-all-gcpc-modules.sh

Expand All @@ -327,7 +327,7 @@ presubmits:
run_if_changed: "^(sdk/python/.*)|(test/presubmit-test-sdk-upgrade.sh)$"
spec:
containers:
- image: python:3.7
- image: python:3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave this as python:3.7 since it is a test.

command:
- ./test/presubmit-test-sdk-upgrade.sh

Expand Down