Alice spatial #6
Conversation
There was a problem hiding this comment.
This does not look like a "global" test that everyone can try on their own computer.
Unless it is the case, you should probably add the file to .gitignore so it is not tracked and only kept locally on your computer
| @@ -522,7 +530,8 @@ def compute_trsfs(self, p: trsf_parameters): | |||
| + init_trsf_command | |||
| + " -res-trsf " | |||
| + res_trsf | |||
| + " -composition-with-initial", | |||
| + " -composition-with-initial" | |||
| +th, | |||
There was a problem hiding this comment.
Can you please run a quick black to ensure that the spacings are correct
| @@ -553,11 +562,12 @@ def compute_trsfs(self, p: trsf_parameters): | |||
| + res_trsf | |||
| + # ' -res-voxel-trsf ' + res_voxel_trsf + \ | |||
| # ' -res ' + flo_out +\ | |||
| " -composition-with-initial", | |||
| #" -composition-with-initial" | |||
| th, | |||
There was a problem hiding this comment.
Is there a reason why you remove the composition with the initial transformation? It does not seem correct but I might be wrong.
| shell=True, | ||
| ) | ||
| call( | ||
| p.path_to_bin + "invTrsf %s %s" % (res_trsf, res_inv_trsf), | ||
| p.path_to_bin + "invTrsf %s %s" % (res_trsf, res_inv_trsf) +th, |
There was a problem hiding this comment.
Why do you need to add the threshold part? I would think that it is only necessary to compute the transformation.
|
About that : this few modifcations were just rapid unsuccessful tests (i guess the commit was a mistake ?), we can discard the changes. |
No description provided.