Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: OPTIC-7: Sum lead time from previous draft on annotation submission #223

Merged
merged 10 commits into from
Sep 11, 2023

Conversation

Travis1282
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

https://labelstudio.aha.io/develop/features/OPTIC-7

What does this fix?

Adds lead time from draft to lead time calculation

What is the new behavior?

lead time is accurate

What is the current behavior?

lead time is only calculated from the current session

What libraries were added/updated?

none

Does this change affect performance?

no

Does this change affect security?

no

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

src/sdk/lsf-sdk.js Outdated Show resolved Hide resolved
src/sdk/lsf-sdk.js Outdated Show resolved Hide resolved
src/sdk/lsf-sdk.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@hlomzik hlomzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only global lead_time should be used

@hlomzik
Copy link
Collaborator

hlomzik commented Aug 24, 2023

/git merge master

Already up-to-date. Nothing to commit.

Workflow run

@Travis1282 Travis1282 merged commit 4c702ac into master Sep 11, 2023
5 checks passed
@Travis1282 Travis1282 deleted the fb-optic-7/draft-lead-time-added branch September 11, 2023 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants