Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: OPTIC-7: Sum lead time from previous draft on annotation submission #223

Merged
merged 10 commits into from
Sep 11, 2023
Merged

fix: OPTIC-7: Sum lead time from previous draft on annotation submission #223

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2d66bd3
fix: optic-7: sum lead time from previous draft on annotation submission
Travis1282 Aug 18, 2023
2b00ddf
remove consoloe
Travis1282 Aug 18, 2023
90788bb
move logic to prepare data and imporve session time calculation
Travis1282 Aug 23, 2023
d29e562
cleanup
Travis1282 Aug 23, 2023
96c376c
remove unused
Travis1282 Aug 23, 2023
43ccf00
fix updated_at typo
Travis1282 Aug 23, 2023
b6c1e32
session time is always from loaded date
Travis1282 Aug 23, 2023
8572002
lead time in seconds
Travis1282 Aug 30, 2023
b6eba86
fix lead time ms to s conversion
Travis1282 Sep 1, 2023
20f87c1
adjust lead time calculation, only convert session time to seconds
Travis1282 Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/sdk/lsf-sdk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,6 @@ export class LSFWrapper {
c = cs.annotations.find(c => c.pk === draftAnnotationPk);
if (c) {
c.history.freeze();
console.log("Applying draft");
c.addVersions({ draft: draft.result });
c.deleteAllRegions({ deleteReadOnly: true });
} else {
Expand Down Expand Up @@ -799,11 +798,14 @@ export class LSFWrapper {
prepareData(annotation, { includeId, draft } = {}) {
const userGenerate =
!annotation.userGenerate || annotation.sentUserGenerate;

const sessionTime = (new Date() - annotation.loadedDate) / 1000;
const submittedTime = Number(annotation.leadTime ?? 0);
const draftTime = Number(this.task.drafts[0]?.lead_time ?? 0);
const lead_time = sessionTime + submittedTime + draftTime;

const result = {
// task execution time, always summed up with previous values
lead_time: (new Date() - annotation.loadedDate) / 1000 + Number(annotation.leadTime ?? 0),
// don't serialize annotations twice for drafts
lead_time,
result: (draft ? annotation.versions.draft : annotation.serializeAnnotation()) ?? [],
draft_id: annotation.draftId,
parent_prediction: annotation.parent_prediction,
Expand Down