This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: OPTIC-218: 'Annotation saved successfully' message is NOT displayed when user exit label stream using 'Submit and exit' option #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yed when user exit label stream using 'Submit and exit' option
hlomzik
suggested changes
Jan 27, 2024
| @@ -586,11 +586,14 @@ export class LSFWrapper { | |||
| // don't react on duplicated annotations error | |||
| { errorHandler: result => result.status === 409 }, | |||
| ); | |||
| }, false, loadNext, exitStream); | |||
There was a problem hiding this comment.
the only place passed this parameter in is this place, so please remove exiStream from submitCurrentAnnotation() as well.
hlomzik
reviewed
Jan 30, 2024
Comment on lines
+594
to
+596
|
|
||
| if (exitStream) return this.exitStream(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| if (exitStream) return this.exitStream(); | |
| if (exitStream) return this.exitStream(); |
hlomzik
approved these changes
Jan 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
minor tweak to give feedback to user on successful annotation save and exiting labeling flow