Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: OPTIC-218: 'Annotation saved successfully' message is NOT displayed when user exit label stream using 'Submit and exit' option #293

Merged
merged 6 commits into from
Feb 1, 2024
Merged

fix: OPTIC-218: 'Annotation saved successfully' message is NOT displayed when user exit label stream using 'Submit and exit' option #293

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4432712
fix: OPTIC-218: 'Annotation saved successfully' message is NOT displa…
yyassi-heartex Jan 25, 2024
416535b
Update src/sdk/lsf-sdk.js
yyassi-heartex Jan 29, 2024
d9f2b08
Merge branch 'master' into fb-optic-218/confirm-message
yyassi-heartex Jan 30, 2024
27d758a
clean up based on feedback
yyassi-heartex Jan 30, 2024
7070901
Merge branch 'master' into fb-optic-218/confirm-message
yyassi-heartex Jan 31, 2024
713dc29
Merge branch 'master' into fb-optic-218/confirm-message
yyassi-heartex Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/sdk/lsf-sdk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,11 +586,14 @@ export class LSFWrapper {
// don't react on duplicated annotations error
{ errorHandler: result => result.status === 409 },
);
}, false, loadNext, exitStream);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only place passed this parameter in is this place, so please remove exiStream from submitCurrentAnnotation() as well.

}, false, loadNext);
const status = result?.$meta?.status;

if (status === 200 || status === 201) this.datamanager.invoke("toast", { message: "Annotation saved successfully", type: "info" });
else if (status !== undefined) this.datamanager.invoke("toast", { message: "There was an error saving your Annotation", type: "error" });

if (exitStream) return this.exitStream();

Comment on lines +594 to +596
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (exitStream) return this.exitStream();
if (exitStream) return this.exitStream();

};

/** @private */
Expand Down Expand Up @@ -854,7 +857,7 @@ export class LSFWrapper {
if (isFF(FF_OPTIC_2)) this.saveDraft();
this.loadTask(prevTaskId, prevAnnotationId, true);
}
async submitCurrentAnnotation(eventName, submit, includeId = false, loadNext = true, exitStream) {
async submitCurrentAnnotation(eventName, submit, includeId = false, loadNext = true) {
const { taskID, currentAnnotation } = this;
const unique_id = this.task.unique_lock_id;
const serializedAnnotation = this.prepareData(currentAnnotation, { includeId });
Expand Down Expand Up @@ -889,7 +892,6 @@ export class LSFWrapper {
}

this.setLoading(false);
if (exitStream) return this.exitStream();

if (!loadNext || this.datamanager.isExplorer) {
await this.loadTask(taskID, currentAnnotation.pk, true);
Expand Down
Loading