Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades and linting #894

Merged
merged 9 commits into from
Dec 10, 2024
Merged

Upgrades and linting #894

merged 9 commits into from
Dec 10, 2024

Conversation

tillywoodfield
Copy link
Contributor

@tillywoodfield tillywoodfield commented Oct 15, 2024 •
edited
Loading

  • Upgrade node v16 -> v20
  • Update linting config to match other repos and make sure it runs as part of CI pipeline
  • Fix linting errors
  • Format project
  • Fix 2 broken integration tests, which were expecting a list to be populated at a specific time, and failed if it wasn't loaded in time

Related: IATI/validator-services#472

@tillywoodfield tillywoodfield changed the title Upgrade node v16 -> v20 Upgrades and linting Oct 15, 2024
@tillywoodfield tillywoodfield mentioned this pull request Oct 15, 2024
Merged
@tillywoodfield tillywoodfield force-pushed the linting branch 3 times, most recently from 68627d9 to 7ca7c0a Compare October 15, 2024 13:16
@tillywoodfield tillywoodfield requested a review from a team November 12, 2024 10:56
tillywoodfield
tillywoodfield commented Nov 20, 2024
View reviewed changes
eslint.config.js
@@ -14,20 +13,15 @@ export default [
...globals.node,
...globals.browser,
},
parserOptions: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simon-20 this is what was missing in order for it to be able to parse the Vue import.meta.env object which was initially erroring when I removed the typescript configs

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful to know, thanks Tilly

@tillywoodfield tillywoodfield merged commit 639968a into develop Dec 10, 2024
2 checks passed
@tillywoodfield tillywoodfield deleted the linting branch December 10, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-20 simon-20 simon-20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tillywoodfield @simon-20