Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting #472

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Linting #472

merged 3 commits into from
Oct 16, 2024

Conversation

tillywoodfield
Copy link
Contributor

@tillywoodfield tillywoodfield commented Oct 15, 2024 •
edited
Loading

Bring linting setup inline with validator-web and design-system, with the aim to roll this out to other IATI JS repositories as we find time.

  • Use ESLint's new flat configuration file format
  • Run linting as part of the CI pipeline, so that code doesn't get out of sync with linting rules
  • Make sure that precommit uses the same linting config as CI
  • Remove custom eslint/prettier config and instead rely on defaults, to favour consistency over each repository having its own set of custom rules
  • Reformat entire project using new config

Related: IATI/datastore-search#894

tillywoodfield and others added 2 commits October 15, 2024 12:48
@tillywoodfield
chore: update linting config
48a6f73 
Use new eslint flat config, remove custom rules, run linting as part of CI pipeline
@tillywoodfield
style: format project using new config
4758f76
@tillywoodfield tillywoodfield marked this pull request as draft October 15, 2024 09:59
@tillywoodfield tillywoodfield marked this pull request as ready for review October 15, 2024 11:19
@tillywoodfield tillywoodfield mentioned this pull request Oct 15, 2024
Merged
@tillywoodfield tillywoodfield merged commit 65db4c9 into develop Oct 16, 2024
3 checks passed
@tillywoodfield tillywoodfield deleted the linting branch October 16, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-20 simon-20 simon-20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tillywoodfield @simon-20