This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Rendering refactor #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f implicit, will anyway call super no-args constructor
- Unify catch clauses that do the same
… as the executor is anyway single thread and all are cancelled on repaint. - Medium quality dummy tasks is removed, as it's not needed anymore
porst17
suggested changes
Jun 7, 2018
There was a problem hiding this comment.
Please adjust the commit messages of your commits (e.g. by interactive rebase + force push). The general rule of thumb in most git projects (including the Linux kernel) is to split the commit messages in two parts separated by a blank line:
Short description (Subject line)
Long description or additional information
A properly formed git commit subject line should always be able to complete the following sentence:
If applied, this commit will <your subject line here>
It starts with a capital letter and has no period at the end.
It never starts with a dash -
You can find more details here.
As the executor is single-thread, they can be submitted directly in the desired execution order. They will anyway be all cancelled if a repaint is triggered
By treating render size and antialising information together as an entity in itself, it's easier to pass them around and reason about them.
|
I followed instructions here to change the commit messages, and it looks from here like they are changed... could you check again? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.