Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Rendering refactor #31

Open
wants to merge 35 commits into
base: surfer-javafx8
Choose a base branch
from
Open

Rendering refactor #31

wants to merge 35 commits into from

Commits on Jun 6, 2018

  1. - remove unneeded constructor declaration: the default constructor, i… 

    …f implicit, will anyway call super no-args constructor
    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    64705f7 View commit details
    Browse the repository at this point in the history

  2. - Move members to the top of the class

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    d4e3860 View commit details
    Browse the repository at this point in the history

  3. - create auxiliary methods for the creation of rendering and stopping… 

    … of tasks
    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    d2a4e6b View commit details
    Browse the repository at this point in the history

  4. - create auxiliary method for checking if the render area is valid

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    8a3903f View commit details
    Browse the repository at this point in the history

  5. - Use auxiliary method to create render tasks

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    41baf0d View commit details
    Browse the repository at this point in the history

  6. - Move the scheduling and waiting to a separate method 

    - Unify catch clauses that do the same
    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    1a11fc3 View commit details
    Browse the repository at this point in the history

  7. - Move creation of Rendering Task to an auxiliary method

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    1246738 View commit details
    Browse the repository at this point in the history

  8. - RenderingTasks are scheduled always and in order from low -> ultra,… 

    … as the executor is anyway single thread and all are cancelled on repaint.

- Medium quality dummy tasks is removed, as it's not needed anymore
    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    5f1c25b View commit details
    Browse the repository at this point in the history

  9. - Move separate concerns of repaint triggering into separate methods

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    6b95c34 View commit details
    Browse the repository at this point in the history

  10. - using the try-with-resources on Scanner, to avoid leaks

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    7d71453 View commit details
    Browse the repository at this point in the history

  11. - Added explicit type to generics

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    490cd6e View commit details
    Browse the repository at this point in the history

  12. - referenced function statically instead of with an instance

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    ea50cd6 View commit details
    Browse the repository at this point in the history

  13. - removed unused imports

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    6729736 View commit details
    Browse the repository at this point in the history

  14. - removed unused variables

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    35f7378 View commit details
    Browse the repository at this point in the history

  15. - access static constant from static context

    @seuribe
    seuribe committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    a03c59d View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. Remove unneeded empty constructor

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    91fe9f3 View commit details
    Browse the repository at this point in the history

  2. Move class members to the top of the file

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    fc0baba View commit details
    Browse the repository at this point in the history

  3. Create auxiliary methods rendering task control

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    998d7fa View commit details
    Browse the repository at this point in the history

  4. Create auxiliary method for checking render area validity

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    b90b354 View commit details
    Browse the repository at this point in the history

  5. Create auxiliary method to create render tasks

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    6e13c1f View commit details
    Browse the repository at this point in the history

  6. Refactor methods to improve readability

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    ea8eaa9 View commit details
    Browse the repository at this point in the history

  7. Move creation of Rendering Task to an auxiliary method

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    2e09b3d View commit details
    Browse the repository at this point in the history

  8. Rearrange the scheduling of RenderingTasks 

    As the executor is single-thread, they can be submitted directly in the
desired execution order. They will anyway be all cancelled if a repaint is
triggered
    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    200fe05 View commit details
    Browse the repository at this point in the history

  9. Move separate concerns of repaint triggering into separate methods

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    5fc6773 View commit details
    Browse the repository at this point in the history

  10. Use try-with-resources on Scanner, to avoid leaks

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    f4a2db1 View commit details
    Browse the repository at this point in the history

  11. Add explicit type to generics

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    e534ff5 View commit details
    Browse the repository at this point in the history

  12. Reference function statically instead of with an instance

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    65332bb View commit details
    Browse the repository at this point in the history

  13. Remove unused imports

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    c4e5ba7 View commit details
    Browse the repository at this point in the history

  14. Remove unused variables

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    050e989 View commit details
    Browse the repository at this point in the history

  15. Change static constant access

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    09861e8 View commit details
    Browse the repository at this point in the history

  16. Use try-with-resources for avoiding leaks with the Scanner

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    9445282 View commit details
    Browse the repository at this point in the history

  17. Unify catch clauses when they do the same

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    b390af1 View commit details
    Browse the repository at this point in the history

  18. Move rendering resolution information to its own class 

    By treating render size and antialising information together
as an entity in itself, it's easier to pass them around and
reason about them.
    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    14fdca4 View commit details
    Browse the repository at this point in the history

  19. Move image creation utility function to its own class

    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    29d33ed View commit details
    Browse the repository at this point in the history

  20. Merge branch 'rendering_refactor' of https://github.com/IMAGINARY/SURFER 

     into rendering_refactor
    @seuribe
    seuribe committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    941bd9d View commit details
    Browse the repository at this point in the history