-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] v0.3 refactor #28
base: main
Are you sure you want to change the base?
Conversation
test/test_basics.jl
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we now have downstream tests, I think it does not make too much sense to try and maintain a full SparseArrayDOKs
implementation as a test here. Instead, I tried to include some manual small overloads and unit tests with minimal dependencies, and am counting on the testsuite of SparseArraysBase.
This leads to a bit of an annoying mess whenever there is a breaking change, since then the CI would not automatically be able to run the downstream tests, but I think it is fine to be able to manually check that in these cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
- Coverage 72.89% 71.50% -1.40%
==========================================
Files 9 8 -1
Lines 321 200 -121
==========================================
- Hits 234 143 -91
+ Misses 87 57 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I've added some more changes, and I'm happy to report that I think I at least fixed some of the linenumber problems (although not all of them, I've noticed...). One interesting problem I ran into: I can't have |
Great!
Exporting |
This is a rather large refactor that aims to resolve some inconveniences.
AbstractArrayInterface
is now no longer opinionatedAbstractArrayOps
is now no longer supported and we require more explicit usage of@derive
It is built on top of #18 so that one should be merged first.
To do