Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] v0.3 refactor #28

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
4a7a52c
Add cat proposition
lkdvos Feb 4, 2025
efd288c
Formatter
lkdvos Feb 4, 2025
399b82f
Rework cat to include `Concatenated` object
lkdvos Feb 11, 2025
e29b271
Fix some docstrings
lkdvos Feb 11, 2025
3ad0b84
simplify some functions
lkdvos Feb 11, 2025
13e97a9
remove out-of-date comments
lkdvos Feb 11, 2025
4363c3c
rename and include file
lkdvos Feb 11, 2025
1889807
small simplifications
lkdvos Feb 11, 2025
00c30a2
remove previous implementation
lkdvos Feb 11, 2025
eff68ce
remove arraytype in favor of `similar(interface, T, ax)`
lkdvos Feb 11, 2025
0293917
Various fixes
lkdvos Feb 11, 2025
d074033
formatter
lkdvos Feb 11, 2025
11f2013
Avoid `Base._copy_or_fill!`
lkdvos Feb 18, 2025
4c70818
rename `concatenate(!)` to `cat(!)`
lkdvos Feb 18, 2025
af8c0ed
Add comment about overloading `Base._cat`
lkdvos Feb 18, 2025
e4f0d89
remove specialization points and simplify
lkdvos Feb 18, 2025
db1054e
remove traits
lkdvos Feb 18, 2025
3650f1d
Refactor overdubbing
lkdvos Feb 18, 2025
a93b7d7
refactor AbstractArrayInterface and DefaultArrayInterface
lkdvos Feb 18, 2025
219c752
Re-enable aqua tests
lkdvos Feb 18, 2025
e078710
remove stale dependency
lkdvos Feb 18, 2025
ac8bf84
fix method ambiguity
lkdvos Feb 18, 2025
a9be4c2
Fix `@derive (T=...,) f(x)` without module
lkdvos Feb 18, 2025
79f9a82
refactor tests
lkdvos Feb 18, 2025
f11399b
mention infinite recursion
lkdvos Feb 18, 2025
c6e506a
update skeleton
lkdvos Feb 18, 2025
52514c2
remove default fallback implementation
lkdvos Feb 18, 2025
a011cbd
Add dedicated `zero!`
lkdvos Feb 26, 2025
d5378a7
Add exports
lkdvos Feb 26, 2025
ced87b6
Fix linenumbers
lkdvos Feb 26, 2025
67f3a3d
Fix types
lkdvos Feb 26, 2025
857d86d
remove `ndims` type parameter
lkdvos Feb 26, 2025
fe8031b
start adding fallbacks
lkdvos Feb 26, 2025
3c7eee8
improve testing
lkdvos Feb 26, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/IntegrationTestRequest.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: "Integration Test Request"

on:
issue_comment:
types: [created]

jobs:
integrationrequest:
if: |
github.event.issue.pull_request &&
contains(fromJSON('["OWNER", "COLLABORATOR", "MEMBER"]'), github.event.comment.author_association)
uses: ITensor/ITensorActions/.github/workflows/IntegrationTestRequest.yml@main
with:
localregistry: https://github.com/ITensor/ITensorRegistry.git
6 changes: 2 additions & 4 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,17 @@ version = "0.3.15"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
ExproniconLite = "55351af7-c7e9-48d6-89ff-24e801d99491"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
MLStyle = "d8e11817-5142-5d16-987a-aa16d5891078"
MapBroadcast = "ebd9b9da-f48d-417c-9660-449667d60261"
TypeParameterAccessors = "7e5a90cf-f82e-492e-a09b-e3e26432c138"

[compat]
Adapt = "4.1.1"
ArrayLayouts = "1.11.0"
Compat = "3.47,4.10"
ExproniconLite = "0.10.13"
LinearAlgebra = "1.10"
MLStyle = "0.4.17"
MapBroadcast = "0.1.5"
TypeParameterAccessors = "0.2, 0.3"
julia = "1.10"
2 changes: 1 addition & 1 deletion docs/make.jl
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ makedocs(;
edit_link="main",
assets=String[],
),
pages=["Home" => "index.md"],
pages=["Home" => "index.md", "Reference" => "reference.md"],
)

deploydocs(;
Expand Down
5 changes: 5 additions & 0 deletions docs/src/reference.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Reference

```@autodocs
Modules = [DerivableInterfaces]
```
13 changes: 10 additions & 3 deletions src/DerivableInterfaces.jl
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
module DerivableInterfaces

export @derive, @interface
export interface, AbstractInterface, AbstractArrayInterface
export zero!

include("interface_function.jl")
include("abstractinterface.jl")
include("derive_macro.jl")
include("interface_macro.jl")
include("wrappedarrays.jl")
include("abstractarrayinterface.jl")
include("defaultarrayinterface.jl")
include("traits.jl")
include("arrayinterface.jl")

# Specific AbstractArray alternatives

include("concatenate.jl")
include("zero.jl")

end
Loading
Loading