Fix for issue #78 loading yarn.txt with \r\n lines #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading a yarn.txt file, Yarn was expecting lines to end only with \n and didn't handle properly lines ending with \r\n. Yarn saves files using only \n, even on Windows, but if the user modify the file manually, some editors on Windows will convert \n to \r\n, so it must be taken into account.
|
ah sorry, I didnt realize you have already fixed it. I will revert the fix in my pull #80 |
|
All good @blurymind 👌 |
|
it would be nice if this project had more than one maintainers. From my understanding it's only @charblar |
|
btw I fixed the issues noted in #83 |
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a yarn.txt file, Yarn was expecting lines to end only with
\n and didn't handle properly lines ending with \r\n.
Yarn saves files using only \n, even on Windows, but if the user modify
the file manually, some editors on Windows will convert \n to \r\n, so
it must be taken into account.