-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yarn - electron - lots of new features #80
Conversation
This also add the feature of showing tags and title of active nodes
@charblar and @julsam requested me to unbeautify the code, which I ran beautify on in a previous commit -That is included in this pull request |
@charblar can you review this please? I added some new features, merged changes from master/electron (here), updated bondage.js to the latest version |
you can download a build here btw: the linux build hasnt been tested and was cross compiled |
fixed #78 |
fixed #83 |
added new bbcode and [[ autocompletion features + bb format preview features |
replaced typo.js with nspell -as typo.js hasnt seen an update in over 3 years, it has a serious delay on some word suggestions and is much less maintained. Made pull here too |
…pace selection by mistake
I think I'm getting closer to a milestone on this. Will do a bit of re-factoring and testing, then do another build |
well anyways, if nobody is maintaining this repository, I might have to make my fork of this project a new project. :) @julsam has added node resizing and fixed a bug, so I want to get his changes into my fork, but his pull is still not being reviewed either |
I’ll review this in the next 48h! |
This is really, really good. When should we consider merging this into master? |
Thank you! I will also upload a portable electron version soon, so people
won't have to build it to try it =)
…On Mon, Jan 21, 2019, 9:29 AM Jon Manning ***@***.*** wrote:
Merged #80 <#80> into
electron.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#80 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGMbVaIZM6ThmkXvla0WD-Xzu9lXylZNks5vFYiHgaJpZM4WWu-s>
.
|
Something that we should discuss soon is setting up a CI server of some kind to automate the builds. Travis CI has worked well for Yarn Spinner.
|
Just to chime in on the CI server front, this is something I'm dealing with right now for https://github.com/lazerwalker/tracery-dot-app. For Windows builds, you want Appveyor or Azure Pipelines; Travis CI's Windows setup is slow and flaky. You can check out Tracery.app's Appveyor config file, although my deployment setup is a bit different from yours since I'm using electron-forge/electron-builder to manage that instead of vanilla Electron. It's set up really nicely to automatically upload a new prerelease binary to the GitHub 'releases' section of the repo every time code is pushed/merged. I'm still figuring out how to properly generate macOS builds on CI (since you ideally need to both codesign and notarize builds to avoid users needing to jump through onerous "this app is dangerous!" security hoops), but the data I've gathered so far suggests CircleCI is going to be the simplest way to configure a CI setup that can properly codesign/notarize given proper credentials. |
I made some builds here, but they are only for windows server builds would be fantastic to have! |
This also adds the feature of showing tags and title of active nodes:
As well as fixes some code that can make easier to embed in other electron software
Tags and node titles can be used to trigger events in game, such as change of avatars or animations during cutscenes
Also updating bondage.js after I made some changes:
hylyh/bondage.js#39 (comment)
hylyh/bondage.js#40
hylyh/bondage.js#41
you can download a build here btw:
https://github.com/blurymind/Yarn/releases/tag/v0.3.2 (outdated build)
added after build: