Add golden tests to ProtocolParameters serialization
#457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
force-pushed
the
unify-json-instances
branch
4 times, most recently
from
18c228d to
1fecdea
Compare
palas
force-pushed
the
unify-json-instances
branch
2 times, most recently
from
f9359fd to
0a37fa1
Compare
palas
changed the title
ProtocolParameters serializationProtocolParameters serialization
9 tasks
palas
force-pushed
the
unify-json-instances
branch
from
1c8a727 to
902285b
Compare
palas
requested review from
Jimbo4350,
newhoggy,
carbolymer,
dcoutts,
erikd,
CarlosLopezDeLara and
disassembler
as code owners
palas
force-pushed
the
unify-json-instances
branch
4 times, most recently
from
f9d86e1 to
2f0e2e4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cardano-api/test/cardano-api-test/Test/Cardano/Api/ProtocolParameters.hs
Fixed
Show resolved
Hide resolved
Jimbo4350
reviewed
Mar 1, 2024
cardano-api/test/cardano-api-golden/Test/Golden/Cardano/Api/ProtocolParameters.hs
Outdated
Show resolved
Hide resolved
cardano-api/test/cardano-api-golden/Test/Golden/Cardano/Api/ProtocolParameters.hs
Outdated
Show resolved
Hide resolved
cardano-api/test/cardano-api-golden/files/golden/ProtocolParameters
Outdated
Show resolved
Hide resolved
cardano-api/test/cardano-api-test/Test/Cardano/Api/ProtocolParameters.hs
Outdated
Show resolved
Hide resolved
cardano-api/test/cardano-api-test/Test/Cardano/Api/ProtocolParameters.hs
Fixed
Show resolved
Hide resolved
cardano-api/test/cardano-api-test/Test/Cardano/Api/ProtocolParameters.hs
Outdated
Show resolved
Hide resolved
cardano-api/test/cardano-api-test/Test/Cardano/Api/ProtocolParameters.hs
Outdated
Show resolved
Hide resolved
cardano-api/test/cardano-api-test/Test/Cardano/Api/ProtocolParameters.hs
Show resolved
Hide resolved
cardano-api/test/cardano-api-test/Test/Cardano/Api/ProtocolParameters.hs
Outdated
Show resolved
Hide resolved
cardano-api/test/cardano-api-test/Test/Cardano/Api/ProtocolParameters.hs
Outdated
Show resolved
Hide resolved
newhoggy
pushed a commit
that referenced
this pull request
Mar 11, 2024
…ed-to-non-extended-golden-tests Add one missing extended to non extended golden tests
palas
force-pushed
the
unify-json-instances
branch
3 times, most recently
from
7389451 to
6cceb23
Compare
palas
force-pushed
the
unify-json-instances
branch
from
6abcb58 to
4ac07fa
Compare
…rametersToPParams`and add comment
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Contributes to fixing #384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
toAlonzoPParamsIn order to make the tests work, this PR is built upon a branch of an old commit of
cardano-ledger.The rebased version of this branch is proposed in this PR in cardano-ledger.
Changelog
Context
This is part of an effort to unify the JSON instances of
ProtocolParametersandPParamsto eventually migrate and usePParamsdirectly incardano-apiinstead ofProtocolParametersHow to trust this PR
Check that the properties and golden tests are the right ones. And check that the changes I did to the conversion functions make sense. Possible check together with this PR in cardano-ledger.
Checklist