-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify PParams to use similar naming to ProtocolParams in cardano-api
#4129
Conversation
85ad4c3
to
01f523c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much in favor of this change. Few important notes on the PR:
- We need to be careful to preserve JSON serialization of Genesis files
- BoundedRational JSON serialization has been fixed in Fix
ToJSON
instance ofBoundedRatio
to avoid precision loss #4058 so we can use it instead doing the conversion to Rational and back everywhere
5edcee4
to
90ef09b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. There are only two problems left to resolve. We need some input from @Jimbo4350 for one of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. I agree with @lehins wrt not including deprecated protocol parameters. cardano-api
incorrectly rendered deprecated protocol parameters.
9ea3db6
to
6f24134
Compare
cardano-api
6f24134
to
e4e0d47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
e4e0d47
to
198786e
Compare
Description
This PR modifies
FromJSON
andToJSON
instances forPParams
of all eras so that they match those ofProtocolParams
. That waycardano-api
can move to usePParams
directly.See the corresponding cardano-api PR.
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)