Replace a call to error in our FFI with a safe alternative
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no need to be unsafe here. Our code just happened to not match on that proof, but this could have broken at any time when doing refactoring. In the Consensus spec, this actually caused a crash.
Soupstraw
reviewed
Feb 3, 2025
Soupstraw
approved these changes
Feb 3, 2025
Co-authored-by: Joosep Jääger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was no need to be unsafe here. Our code just happened to not match on that proof, but this could have broken at any time when doing refactoring. In the Consensus spec (which copies our code), this actually caused a crash.
Checklist
CHANGELOG.md