Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a call to error in our FFI with a safe alternative #650

Merged
merged 2 commits into from
Feb 3, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Ledger/Conway/Foreign/HSLedger/ExternalStructures.agda
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ instance
{ Implementation
; isSigned = λ a b m → extIsSigned (HSVKey.hvkVKey a) b m ≡ true
; sign = λ _ _ → zero
-- we can't prove these properties since the functions are provided by the Haskell implementation
-- we can't prove correctness since the function is provided by the Haskell implementation
; isSigned-correct = error "isSigned-correct evaluated"
; Dec-isSigned = λ { {vk} {ser} {sig} → ⁇ (extIsSigned (HSVKey.hvkVKey vk) ser sig because error "Dec-isSigned evaluated") }
; Dec-isSigned = ⁇ (_ ≟ _)
}

-- No P2 scripts for now
Expand Down
Loading