Cosmic Reach Model Editor plugin

[zHoeshin]

Add the Cosmic Reach Model Editor plugin to the list of Blockbench plugins

[Malik12tree]

Please make use of originalJavaBlockCond, To clarify again, the original condition might be changed within Blockbench or by other plugins. Instead, use the saved condition within your new condition. This will protect your plugin from breaking Blockbench or other plugins in the future.

[zHoeshin]

@Malik12tree , I'm not sure what you mean? The condition gets set back to originalJavaBlockCond on unload(). Did you expect me to change java_block condition to the following code?

(mode) => {
    if (mode.cuboids) return true;
    return originalJavaBlockCond(model);
}

Please note, I cannot avoid modufying the original condition. To make sure the open_model() action(baritem) works correctly, I have to prevent the java_block's condition from giving false positives.
The only way I'm able not to change the condition is to not support the open_model() action at all, which is a major inconvenience when working with models.

[Malik12tree]

Yeah of course! But only to give your plugin more availability in case the original condition (model.parent || model.elements || model.textures) changes, instead of hard coding it in your code, just change it to call the original condition. It will behave exactly as it's behaving now, only less subject to break things in the future.

(mode) => {
    return !mode.cuboids && originalJavaBlockCond(model);
}

[zHoeshin]

@Malik12tree , the issue's long ago fixed

[Malik12tree]

@zHoeshin Yeah totally aware. Jannis is the only person that can merge pull requests in this repo, sometimes pull requests may take long if he's busy

[JannisX11]

Thanks for your help @Malik12tree !

There are two breaking issure remaining:

• Codec.java_block does not exist. Use Codecs.java_block instead in the 2 places where it's misspelled
• plugins.json has a trailing comma, as you can seen from the automatic check above

I would also strongly recommend to add icons to your model format and your actions.
Once this is fixed, you may update the creation date field to the current date so it'll show up as new.

[JannisX11]

The new icons are not working correctly.
It's a good practice to always test all the changes that you make.