Bugfix: Rough edges in JFactoryPodioT and JMultifactory #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses almost everything in the following issues:
The only remaining issue is in #247, regarding Set<>() not checking if the collection is already in the frame. This issue is pretty subtle: a user would have to go reasonably far off the beaten path for it to crop up, and it's not obvious to me how JANA ought to recover, anyhow. I think we can worry about it after this release. It would make the most sense to revisit the issue when we address issue #254.