Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Rough edges in JFactoryPodioT and JMultifactory #266

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Bugfix: Rough edges in JFactoryPodioT and JMultifactory #266

merged 8 commits into from
Nov 21, 2023

Commits on Nov 21, 2023

  1. Fix PODIO perf test

    @nathanwbrei
    nathanwbrei committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ba1de47 View commit details
    Browse the repository at this point in the history

  2. Fix PODIO unit test

    @nathanwbrei
    nathanwbrei committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    c725d4e View commit details
    Browse the repository at this point in the history

  3. JMultifactory no longer suffixes output collection names 

    This feature never worked right, and the functionality has been moved to a higher level. See EICrecon's JOmnifactory.
    @nathanwbrei
    nathanwbrei committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2a49b30 View commit details
    Browse the repository at this point in the history

  4. Verify correct behavior of JFactoryPodioT::Insert

    @nathanwbrei
    nathanwbrei committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    20a6276 View commit details
    Browse the repository at this point in the history

  5. JMultifactory catches std::exception and rethrows as a JException

    @nathanwbrei
    nathanwbrei committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    5ae2275 View commit details
    Browse the repository at this point in the history

  6. JFactoryGenerators now have a pointer to JApplication 

    This means we can get rid of the extra 'app' argument when declaring OmniFactories and ChainFactories
    @nathanwbrei
    nathanwbrei committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a229aa7 View commit details
    Browse the repository at this point in the history

  7. Fix memory leak in JFactoryPodioT::Set 

    This resolves issue #235.
    @nathanwbrei
    nathanwbrei committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    160bcdb View commit details
    Browse the repository at this point in the history

  8. Fix C++20 warning about implicit capture of 'this'

    @nathanwbrei
    nathanwbrei committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    47f7f41 View commit details
    Browse the repository at this point in the history