-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create_fresh_base_sysimage()
: Pass ""
as the BUILDROOT for Julia 1.12+
#996
Conversation
""
as the BUILDROOT for Julia 1.12+
""
as the BUILDROOT for Julia 1.12+create_fresh_base_sysimage()
: Pass ""
as the BUILDROOT for Julia 1.12+
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #996 +/- ##
=======================================
Coverage 84.56% 84.56%
=======================================
Files 3 3
Lines 823 823
=======================================
Hits 696 696
Misses 127 127 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
87bac82
to
6e15a4e
Compare
I think that it's fine to just always pass this argument unconditionally, because AFAICT it will just be ignored on older Julia versions. But if we want, we could instead gate this behind an |
Also, I went ahead and bumped the version number (from 2.1.22 to 2.1.23), so that we can tag a new release after we merge this PR. I determined the bump as follows:
|
@KristofferC Any objection to moving forward with this PR as a bug fix (and then doing the more involved work in #997)? |
Closing in favor of #1002. |
Fixes #989.
This fixes the immediate bug in #989, which is that Base.jl incorrectly assumes that our first positional argument is the value of the
BUILDROOT
. The fix is to pass a second positional argument""
, which is then taken by Base.jl to be theBUILDROOT
.This bugfix PR will eventually be followed up by #997, which is a larger PR that will actually take advantage of the new BuildSettings mechanism added to Julia 1.12 in JuliaLang/julia#54387