In Julia 1.12+, in create_fresh_base_sysimage(), use the BuildSettings mechanism to pass the list of sysimages to include in the fresh (non-incremental) base sysimage
#997
+46
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ysimages to include in the fresh (non-incremental) base sysimage
DilumAluthge
force-pushed
the
dpa/buildsettings-1.12
branch
from
dc93d91 to
de49c5a
Compare
DilumAluthge
changed the title
create_fresh_base_sysimage(), use the BuildSettings mechanism to pass the list of sysimages to include in the fresh (non-incremental) base sysimage
This was referenced Nov 1, 2024
KristofferC
reviewed
Nov 25, 2024
| # The --build-settings argument is to pass our BuildSettings file. | ||
| # BuildSettings is only available in Julia 1.12+ | ||
| # https://github.com/JuliaLang/julia/pull/54387 | ||
| buildsettings_args = `$new_sysimage_source_path "" --build-settings $(build_settings_source_path)` |
There was a problem hiding this comment.
I would move all the logic for rewriting the sysimage.jl file into the else branch to show that it is dead on newer julia versions and just use the Base.find_source_file("sysimg.jl") as the argument here to show nothing weird is going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #989 (comment)
Follow-up to #996.
This uses the BuildSettings mechanism added to Julia 1.12 in JuliaLang/julia#54387.
On Julia 1.11 and earlier, we will continue to use the old method (rewriting
sysimg.jlwith the list of stdlibs that we want to include in the fresh base sysimage).