Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.17.0: splintering and migration of specialized functionalities to new packages #218

Open
wants to merge 121 commits into
base: master
Choose a base branch
from

Conversation

cecileane
Copy link
Member

major changes to make PhyloNetworks into a better "core".
new packages to host functionalities removed from here: SNaQ, PhyloTraits, PhyLiNC.

cecileane and others added 30 commits July 25, 2024 11:11
…onetworks. All are exported. Functions are currently unchanged.
Split the test into normal and a ! variety that tries to fix missing edges.
These functions use the recursion preorder format and should facilitate ease oof coding istimeconsistent and fixmissingedges style functions.

I added some tests but still need to add more tests to cover all edge cases.
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 90.31877% with 82 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/auxiliary.jl 85.06% 33 Missing ⚠️
src/bootstrap.jl 67.44% 14 Missing ⚠️
src/addHybrid.jl 80.35% 11 Missing ⚠️
src/parsimony.jl 89.70% 7 Missing ⚠️
src/manipulateNet.jl 95.83% 6 Missing ⚠️
src/descriptive.jl 80.00% 3 Missing ⚠️
src/moves_semidirected.jl 93.47% 3 Missing ⚠️
src/compareNetworks.jl 96.22% 2 Missing ⚠️
src/pairwiseDistanceLS.jl 98.18% 2 Missing ⚠️
src/nj.jl 96.55% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/generate_topology.jl 100.00% <100.00%> (ø)
src/graph_components.jl 99.15% <100.00%> (ø)
src/interop.jl 100.00% <100.00%> (ø)
src/readwrite.jl 90.37% <ø> (+8.61%) ⬆️
src/recursion_matrices.jl 89.02% <ø> (ø)
src/recursion_routines.jl 100.00% <ø> (ø)
src/types.jl 65.62% <ø> (-17.10%) ⬇️
src/nj.jl 92.04% <96.55%> (-0.73%) ⬇️
src/compareNetworks.jl 87.83% <96.22%> (-11.49%) ⬇️
src/pairwiseDistanceLS.jl 95.18% <98.18%> (-0.55%) ⬇️
... and 7 more

... and 1 file with indirect coverage changes


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants