-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
populate optsum in prfit! #801
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
- Coverage 97.27% 97.20% -0.07%
==========================================
Files 35 35
Lines 3409 3434 +25
==========================================
+ Hits 3316 3338 +22
- Misses 93 96 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The documentation says that the Did you intend to modify it? It also looks as if optsum.finitial is not reset. |
BTW, thanks for the very rapid response on this. I was in the library downstairs then came up to our condo and by the time I got here you had a complete PR created. |
Good catch on both fronts -- I think I've addressed them now. |
Two small problems, which I am happy to look at if you wish. The progress bar information is overwritten by the display of the fitted model. Was there an extra println() in the The optsum.fitlog doesn't include the evaluation at the initial parameter estimates in prfit! but it does in fit! Just let me know if you would prefer that I look into these changes. |
@dmbates I think I got those fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work on this.
docs/NEWS-update.jl
to update the cross-references.