Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate optsum in prfit! #801

Merged
merged 8 commits into from
Jan 22, 2025
Merged

populate optsum in prfit! #801

merged 8 commits into from
Jan 22, 2025

Conversation

palday
Copy link
Member

@palday palday commented Jan 22, 2025

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

@palday palday requested a review from dmbates January 22, 2025 18:00
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.20%. Comparing base (3f81dc2) to head (15ae929).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ext/MixedModelsPRIMAExt.jl 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
- Coverage   97.27%   97.20%   -0.07%     
==========================================
  Files          35       35              
  Lines        3409     3434      +25     
==========================================
+ Hits         3316     3338      +22     
- Misses         93       96       +3     
Flag Coverage Δ
current 96.85% <96.29%> (-0.07%) ⬇️
minimum 97.20% <96.29%> (-0.07%) ⬇️
nightly 96.78% <96.29%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmbates
Copy link
Collaborator

dmbates commented Jan 22, 2025

The documentation says that the optimizer field contains a dummy value to indicate PRIMA but it seems not to have been changed from :LN_BOBYQA

Did you intend to modify it?

It also looks as if optsum.finitial is not reset.

@dmbates
Copy link
Collaborator

dmbates commented Jan 22, 2025

BTW, thanks for the very rapid response on this. I was in the library downstairs then came up to our condo and by the time I got here you had a complete PR created.

@palday
Copy link
Member Author

palday commented Jan 22, 2025

The documentation says that the optimizer field contains a dummy value to indicate PRIMA but it seems not to have been changed from :LN_BOBYQA

Did you intend to modify it?

It also looks as if optsum.finitial is not reset.

Good catch on both fronts -- I think I've addressed them now.

@dmbates
Copy link
Collaborator

dmbates commented Jan 22, 2025

Two small problems, which I am happy to look at if you wish.

The progress bar information is overwritten by the display of the fitted model. Was there an extra println() in the fit! function to prevent that overwriting?

The optsum.fitlog doesn't include the evaluation at the initial parameter estimates in prfit! but it does in fit!

Just let me know if you would prefer that I look into these changes.

@palday
Copy link
Member Author

palday commented Jan 22, 2025

@dmbates I think I got those fixed now!

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on this.

@palday palday merged commit 1ea4083 into main Jan 22, 2025
10 of 12 checks passed
@palday palday deleted the pa/prfit_optsum branch January 22, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants