[SPIR-V 1.4] Support OpPtrEqual, OpPtrNotEqual and OpPtrDiff to compare pointers #2482
Conversation
|
Please take a look @MrSidims @LU-JOHN @asudarsa @bwlodarcz @VyacheslavLevytskyy |
| "Invalid type for Binary Ptr instruction"); | ||
| assert(static_cast<SPIRVTypePointer *>(Op1Ty)->getElementType() == | ||
| static_cast<SPIRVTypePointer *>(Op2Ty)->getElementType() && | ||
| "Invalid types for Binary Ptr instruction"); | ||
| } else { | ||
| assert(0 && "Invalid op code!"); |
There was a problem hiding this comment.
It's a nice occasion to improve diagnostics in this place and add precise info about op code that is not supported. I've once hit this exactly line when SPIRV Backend generated code for missed OpPtrEqual/NotEqual and spent some time on debugging. To avoid this in future we may want to improve diagnostics right in this place and give a user-friendly description of what exactly SPIRV Translator doesn't have support for.
@MrSidims @asudarsa what do you think? ^
There was a problem hiding this comment.
I think the subsequent change from @vmaksimo does provide more information. One issue I see here is our reliance on 'assert'. Should we try to provide an error mechanism which will stop translation in such cases? This can be made as a separate effort.
Thanks
| @@ -0,0 +1,50 @@ | |||
| ; RUN: llvm-as %s -o %t.bc | |||
There was a problem hiding this comment.
Please add a small test description (one-liner). Thanks
| @@ -0,0 +1,58 @@ | |||
| ; RUN: llvm-as %s -o %t.bc | |||
There was a problem hiding this comment.
Please add a small test description (one-liner). Thanks
This addresses p.2 and p.3 of #2460