building AMS with adiak #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koparasy
reviewed
Oct 2, 2023
Comment on lines
+93
to
+99
| if (WITH_ADIAK) | ||
| find_package(adiak REQUIRED) | ||
| list(APPEND AMS_APP_INCLUDES ${adiak_INCLUDE_DIR}) | ||
| list(APPEND AMS_APP_LIBRARIES adiak::adiak) | ||
| list(APPEND AMS_APP_DEFINES "-D__ENABLE_ADIAK__") | ||
| endif() | ||
|
|
There was a problem hiding this comment.
If only the example file calls the adiak API you don't need these lines here. You need to find_package at line 346.
koparasy
reviewed
Oct 2, 2023
Comment on lines
+78
to
+100
| // add adiak init here | ||
| // ------------------------------------------------------------------------ | ||
| adiak::init(nullptr); | ||
|
|
||
| // adiak::value("compiler", adiak::version("[email protected]")); | ||
| const adiak::path adiak_ams_compiler = std::string("@RAJAPERF_COMPILER@"); | ||
| adiak::uid(); | ||
| adiak::launchdate(); | ||
| adiak::launchday(); | ||
| adiak::executable(); | ||
| adiak::executablepath(); | ||
| adiak::workdir(); | ||
| adiak::libraries(); | ||
| adiak::cmdline(); | ||
| adiak::hostname(); | ||
| adiak::clustername(); | ||
| adiak::walltime(); | ||
| adiak::systime(); | ||
| adiak::cputime(); | ||
| adiak::jobsize(); | ||
| adiak::hostlist(); | ||
| adiak::numhosts(); | ||
|
|
There was a problem hiding this comment.
Can you add all this init functions in a separate function and call it?
koparasy
reviewed
Oct 2, 2023
There was a problem hiding this comment.
Please remove this file from the commit. We are not uploading setup recipes in the repository. Keep a copy of this on your local system.
koparasy
requested changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Adiak options to CMakeList to support Adiak calls inside main.cpp