Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build option for adiak #56

Merged
merged 5 commits into from
Mar 8, 2024
Merged

add build option for adiak #56

merged 5 commits into from
Mar 8, 2024

Conversation

slabasan
Copy link
Contributor

@slabasan slabasan commented Mar 6, 2024

FYI: Update adiak call to adiak::collect_all() once adiak is updated to 0.4.0.

Metadata before:

$ CALI_CONFIG=runtime-report,print.metadata ./ams_example --precision double --uqtype faiss-mean -S ../../tests/AMSlib/debug_model.pt -H ../../tests/AMSlib/example_faiss.idx -e 100

mpi.world.size       : 1 
cali.caliper.version : 2.9.0
cali.channel         : runtime-report
...

Metadata after:

$ CALI_CONFIG=runtime-report,print.metadata ./ams_example --precision double --uqtype faiss-mean -S ../../tests/AMSlib/debug_model.pt -H ../../tests/AMSlib/example_faiss.idx -e 100

mpi.world.size       :          1 
cali.caliper.version : 2.9.0
walltime             :   5.814216 
systime              :   1.040000 
cputime              :  33.830000 
compiler             : @RAJAPERF_COMPILER@
numhosts             :          1 
cluster              : lassen
hostname             : lassen23
cmdline              : [./ams_example,--precisio~~example_faiss.idx,-e,100]
libraries            : [.../lib64/libnss_files.so.2]
working_directory    : <redacting>
executablepath       : <redacting>
executable           : ams_example
launchday            : 1709683200 
launchdate           : 1709757169 
uid                  : Stephanie
cali.channel         : runtime-report
...

@slabasan
Copy link
Contributor Author

slabasan commented Mar 6, 2024

Supercedes #10

@koparasy This is ready for your review

Copy link
Member

@koparasy koparasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good to me. Thank you for updating the tests as well. Could you please fix the minor comments? I will merge after.

examples/main.cpp Outdated Show resolved Hide resolved
examples/main.cpp Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Copy link
Member

@koparasy koparasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for setting adiak by default off.

@koparasy koparasy merged commit db88f2e into LLNL:develop Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants