Utilize MFEM's petsc/ slepc wrappers #1138
Conversation
chapman39
commented
Jun 12, 2024
•
chapman39
commented
- Let MFEM manage petsc/ slepc TPLs
- Build MFEM with petsc/ slepc wrappers
- Change smoke tests to use MFEM's examples instead
…mfem-petsc-wrapper
…mfem-petsc-wrapper
…mfem-petsc-wrapper
…L/serac into feature/chapman39/mfem-petsc-wrapper
…mfem-petsc-wrapper
…L/serac into feature/chapman39/mfem-petsc-wrapper
chapman39
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
cmake/thirdparty/FindARPACK.cmake
Outdated
|
|
||
| foreach(_lib_dir ${ARPACK_DIR}/lib;${ARPACK_DIR}/lib64) | ||
| if (EXISTS ${_lib_dir}) | ||
| set(ARPACK_LIBRARIES "${_lib_dir}/libparpack.so") |
There was a problem hiding this comment.
This line is an issue for MacOS builds -- I need set(ARPACK_LIBRARIES "${_lib_dir}/libparpack.dylib")
There was a problem hiding this comment.
Can we not use the pkgconfig files generated by ARPACK?
There was a problem hiding this comment.
Other than this minor issue, this builds fine locally!
There was a problem hiding this comment.
@zatkins-work Let me know if my recent changes resolves your build issues on mac
There was a problem hiding this comment.
You should be using find_library:
https://cmake.org/cmake/help/latest/command/find_library.html
This will toggle lib and lib64 and the file extension as well:
find_library(_arpack_library parpack PATHS ${ARPACK_DIR}/lib)
There was a problem hiding this comment.
You should also search for a specific header so you know that the installation works. Here is an example:
https://github.com/LLNL/axom/blob/develop/src/cmake/thirdparty/FindC2C.cmake
There was a problem hiding this comment.
just fixed that, thanks
| #------------------------------------------------------------------------------ | ||
| # SLEPc | ||
| #------------------------------------------------------------------------------ | ||
| if (SLEPC_DIR AND SERAC_USE_PETSC) |
There was a problem hiding this comment.
Should this also be inside of the if(PETSC_DIR) section like below?
There was a problem hiding this comment.
I guess that is what the SERAC_USE_PETSC does...
| # List of MFEM dependencies, that require the *_LIB variable to be non-empty | ||
| MFEM_REQ_LIB_DEPS = ENZYME SUPERLU MUMPS METIS FMS CONDUIT SIDRE LAPACK SUNDIALS\ | ||
| - SUITESPARSE STRUMPACK GINKGO GNUTLS NETCDF PETSC SLEPC MPFR PUMI HIOP\ | ||
| + SUITESPARSE STRUMPACK GINKGO GNUTLS NETCDF SLEPC PETSC MPFR PUMI HIOP\ |
There was a problem hiding this comment.
Does this need to go into spack or mfem?
There was a problem hiding this comment.
MFEM. I have a PR for it here mfem/mfem#4363
| @@ -204,6 +206,8 @@ class Serac(CachedCMakePackage, CudaPackage): | |||
| # Conflicts | |||
| # | |||
|
|
|||
| conflicts("~petsc", when="+slepc", msg="PETSc must be built when building with SLEPc!") | |||
