U/jrbogart/create reorg #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… solar SED file internally
jchiang87
approved these changes
Sep 18, 2024
skycatalogs/flux_catalog_creator.py
Outdated
| return out_dict | ||
|
|
||
|
|
||
| def _do_star_flux_chunk(send_conn, star_collection, instrument_needed, |
There was a problem hiding this comment.
The code for _do_galaxy_flux_chunk and _do_star_flux_chunk seems to be identical except for the column name for the id field. Can we just have one function that passes that column name as a parameter?
2. Eliminate unused --dc2 option from create_flux.py
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chiefly this addresses issue #119. The old script
create_sc.pyis replaced bycreate_main.pyandcreate_flux.py. Also the bulk of the implementation which had been incatalog_creator.pyis now split intomain_catalog_creator.pyandflux_catalog_creator.py.SSOs were mostly handled in a separate file,
sso_catalog_creator.py. This is still the case, but the old classSsoCatalogCreatorhas been replaced by classesSsoMainCatalogCreatorandSsoFluxCatalogCreator. This was made simpler by addressing a couple of the items in issue #87. The solar SED is now kept in the repo as a text file which galsim can read directly. And the path to SSO truth may now be passed in as an argument to the create script, as is the case for other object types.This update just reorganizes code and should not change any values in output skyCatalogs (except possibly metadata). In order to make it easy to confirm that, I've added a script
compare.py