Fix "compare" function in "RunDownBean.getTopLeaks". #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagisha
approved these changes
Mar 26, 2024
|
You may want to target the 23.11-SNAPSHOT branch for this one. |
…getLeakMemoryAverage.
labkey-jeckels
pushed a commit
that referenced
this pull request
Oct 23, 2024
Rationale The Skyline Nightly Test Results page displays an error if there are a lot of leaks reported because the "Compare" method implementation in "getTopLeaks" does not return consistent results. This was because it was mistakenly comparing the wrong set of numbers (comparing number of bytes leaked in one test to handle leaks in the other test) such that Compare(a, b) was not necessarily the opposite of Compare(b, a).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The Skyline Nightly Test Results page displays an error if there are a lot of leaks reported because the "Compare" method implementation in "getTopLeaks" does not exhibit the "transitive" property. It returns "0" when two doubles differ by less than 1, which means there are cases where A == B, B==C, but A < C.