Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "compare" function in "RunDownBean.getTopLeaks". #411

Merged
merged 2 commits into from
Mar 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions testresults/src/org/labkey/testresults/view/RunDownBean.java
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,15 @@ public Map<String, List<TestLeakDetail>> getTopLeaks(int n, boolean isStatRun) {
}

double mem1 = getLeakMemoryAverage(l1);
double mem2 = getLeakHandleAverage(l2);
if (mem1 != mem2)
double mem2 = getLeakMemoryAverage(l2);
if (Double.compare(mem2, mem1) != 0)
{
return (int)(mem2 - mem1);
return Double.compare(mem2, mem1);
}

double handle1 = getLeakHandleAverage(l1);
double handle2 = getLeakHandleAverage(l2);
return (int)(handle2 - handle1);
return Double.compare(handle2, handle1);
});
Map<String, List<TestLeakDetail>> newMap = new LinkedHashMap<>();
if (n == 0)
Expand Down