Allow adding alternate keys to dataiterator #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2024
labkey-matthewb
approved these changes
Oct 28, 2024
| return Collections.unmodifiableSet(_alternateKeys); | ||
| } | ||
|
|
||
| public void addAlternateKeys(Set<String> alternateKeys) |
There was a problem hiding this comment.
I might have gone with set() instead of add(), but this is much better.
There was a problem hiding this comment.
yeah I thought about that, just noticed all the usages were just adding to the existing set so just gave that level of access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Add adder and update getter for alt keys.
Related Pull Requests
Changes