Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use eventId event notes merge #242

Closed
wants to merge 2 commits into from
Closed

Use eventId event notes merge #242

wants to merge 2 commits into from

Conversation

labkey-martyp
Copy link
Contributor

Rationale

Since the event note may not have an event note Id when ETLing data, use the eventId when merging.

Also do a little cleanup on error handling when updating narrative caches.

Related Pull Requests

Changes

  • Override configureDataIteratorContext to use EventId as a key when doing a merge.
  • Ensure errors are caught and don't continue if delete narrative cache fails.

@labkey-martyp labkey-martyp mentioned this pull request Oct 28, 2024
Merged
@labkey-martyp
Copy link
Contributor Author

This was merged to this PR, #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-matthewb labkey-matthewb labkey-matthewb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-martyp @labkey-matthewb