Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Merge on EventId for EventNotes and Speed up NarrativeCache population for iterative updates #243

Merged
merged 17 commits into from
Nov 1, 2024

Conversation

jallentxbiomed
Copy link
Collaborator

@jallentxbiomed jallentxbiomed commented Oct 30, 2024

  • Added commits from Marty's feature branch 24.7_fb_di_alt_key
  • Updated SND Sequencer default values
  • Added isFullReload flag to populateNarrativeCache method and functionality in getBulkSuperPkgs. This prevents the process from getting the entire SuperPackage table from the database when the update is only for a small set of eventIds, and speeds up the ETLs by a lot for iterative updates/merges
  • Generate narratives in the EventNotes ETL so that standalone eventNotes receive narratives in EventCache

Copy link
Collaborator

@spamhurts spamhurts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@labkey-martyp labkey-martyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jallentxbiomed I have another update here to give you a little better performance, so you don't have to traverse the result set an additional time to get the event ids. Can I push it to this fb?

@jallentxbiomed
Copy link
Collaborator Author

@labkey-martyp yep, that sounds good.

@labkey-martyp
Copy link
Contributor

@labkey-martyp yep, that sounds good.

Ok try it out when you get a chance.

@labkey-martyp labkey-martyp self-requested a review October 31, 2024 00:00
@jallentxbiomed jallentxbiomed merged commit c7708e4 into release24.7-SNAPSHOT Nov 1, 2024
2 checks passed
@jallentxbiomed jallentxbiomed deleted the 24.7_fb_fixETLMissingEventNoteId branch November 1, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants