This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
forked from ampproject/amphtml
-
Notifications
You must be signed in to change notification settings - Fork 11
Try to pull in changes from google:master #1
Open
dawehner
wants to merge
1,723
commits into
Lullabot:php-validator-generated
Choose a base branch
from
dawehner:php-validator-generated
base: php-validator-generated
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Try to pull in changes from google:master #1
dawehner
wants to merge
1,723
commits into
Lullabot:php-validator-generated
from
dawehner:php-validator-generated
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix * fix * fix * size * fix
* Fix an un-closed amp-ad tag in example. Fix some bad indentation. * style fixes * single quote to double quote
Validator Rollup
* Pass down experiment toggles to 3p iframes. * Fix type checks. * Fix tests. * update test
* Tweak regex to allow \n in variable values. Fixes ampproject#6885
…y YT (ampproject#6915) * Remove the layout wait, issue seems to have been fixed by YT * Lint
* initial commit for bind/form integration * fix type error * fix unit test * PR comments
* wip * first version test * dispatch scroll event * wip * wip * push to heroku * make it work * enable io for fake3pad example * fix test * fix * add validateDate check to _ping_ * use platform isChrome * nit
…pproject#6895) The backends expect vid to be of a particular format: NNNNNN.NNNNNN. Whereas cid can be of arbitrary format (as is the case for AMP). Fixes ampproject#6379
…mainRenderingUntilDeprecated" feature. (ampproject#6924)
* update doc * small fix * update * nit
ampproject#6803) * Merges isDevChannel() and isDevChannelVersionDoNotUse_(). * Update js doc * Remove unnecessary dep-checks. * fix
* initial commit for bind expression AST * fix lint and type errors * rename ASTType to ASTNodeType * move try/catch to evaluator * add some comments * move other try/catch to evaluator * PR comments * change enum to number, fix type errors * justin's comments
…mpproject#6920) * Added IE11 Compatible Charset for SVGs As the title States, added IE11 compatible charset for CSS SVGs. Shorthands will break SVG support * Made All utf8 svg's IE11 compatible
* Launch amp-playbuzz experiment * notes
…mpproject#6917) * Fix structured return from key signing in a number of negative cases. Refactor for cleanliness. Add tests.
* Default requireAmpResponseSourceOrigin to true. * Fix type checks.
* Squash commits for bind mutation flow refactor * extend amp css regexp to include i-amphtml- * PR comments * PR comments * tweak mutate callback to pass non-string-cast result, also ignore unused old value * justin's comments * fix type error * fix rebase errors * justin's comment, fix callback triggering incorrectly for boolean attrs
* write out css files to build and dist folders * temp
…ect#6937) * Reorganize karma config files. * Remove unused code. * Simplify logic. * Some more improvements. * Avoid using a karma config file. Put everything into a config object instead. This completely solves the hard-to-explain config overridden problem. * Document hardcoded log level constants. * Import gulp server into Karma server as a middleware
These contain zero information and so we only care about the count, but not about getting every single one. See ampproject#7353 for context.
…oject#7358) …and then catching the `error` event. Part of ampproject#7353
* Address issue 6780 * Move crypto into its own service; add test coverage * fix merge conflicts * PR review * Move amp analytics into crypto service * PR review * PR reviews * test/presubmit fixes * fix linter error
…atest details (ampproject#7385) * updating weekly status and design doc sections * Update CONTRIBUTING.md
* Remove GPU rasterizaton reasoning for viewport * Add links for remaining analytics vendors
* avoid referencing Chunks in extension * fix unit test * fix presubmit * malte's comment
* Visibility-v2: use IntersectionObserverPolyfill * Address comments
…roject#7409) Makes it easier to identify problems in tests.
dawehner
changed the title
Try to pull in changes to google:master
Try to pull in changes from google:master
Feb 8, 2017
dawehner
added a commit
to dawehner/amp-library
that referenced
this pull request
Feb 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal was to integrate the amp-hulu tag into the amp php library,
see PR Lullabot/amp-library#162
Steps executed:
[[build.py GenValidatorProtoascii]] - ... done [[build.py GenValidatorGeneratedJs]] - entering ... [[build.py GenValidatorGeneratedJs]] - ... done [[build.py GenValidatorGeneratedPHP]] - entering ... [[build.py GenValidatorGeneratedPHP]] - ... done [[build.py GenValidatorGeneratedMd]] - entering ... [[build.py GenValidatorGeneratedMd]] - ... done [[build.py CompileValidatorMinified]] - entering ... [[build.py CompileValidatorMinified]] - ... done [[build.py RunSmokeTest]] - entering ... smoke test failed. Expected p.returncode==1, saw: 0 ~
so it seems to be the changed spec files have never been written.