Try to pull in changes from google:master #1

dawehner · 2017-02-08T14:49:38Z

My goal was to integrate the amp-hulu tag into the amp php library,
see PR Lullabot/amp-library#162

Steps executed:

Used a simple docker file to get a reproducable environment:

FROM phusion/baseimage:0.9.18

CMD ["/sbin/my_init"]

RUN apt-get update && apt-get install protobuf-compiler python-protobuf nodejs npm openjdk-7-jre -y

RUN apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

Build the image and run build.py
Sadly the smoke tests failed: [[build.py GenValidatorProtoascii]] - ... done [[build.py GenValidatorGeneratedJs]] - entering ... [[build.py GenValidatorGeneratedJs]] - ... done [[build.py GenValidatorGeneratedPHP]] - entering ... [[build.py GenValidatorGeneratedPHP]] - ... done [[build.py GenValidatorGeneratedMd]] - entering ... [[build.py GenValidatorGeneratedMd]] - ... done [[build.py CompileValidatorMinified]] - entering ... [[build.py CompileValidatorMinified]] - ... done [[build.py RunSmokeTest]] - entering ... smoke test failed. Expected p.returncode==1, saw: 0 ~ so it seems to be the changed spec files have never been written.

* fix * fix * fix * size * fix

* Fix an un-closed amp-ad tag in example. Fix some bad indentation. * style fixes * single quote to double quote

Validator Rollup

* Pass down experiment toggles to 3p iframes. * Fix type checks. * Fix tests. * update test

…ampproject#6903)

* Tweak regex to allow \n in variable values. Fixes ampproject#6885

…y YT (ampproject#6915) * Remove the layout wait, issue seems to have been fixed by YT * Lint

* initial commit for bind/form integration * fix type error * fix unit test * PR comments

…mpproject#6911)

* wip * first version test * dispatch scroll event * wip * wip * push to heroku * make it work * enable io for fake3pad example * fix test * fix * add validateDate check to _ping_ * use platform isChrome * nit

…pproject#6895) The backends expect vid to be of a particular format: NNNNNN.NNNNNN. Whereas cid can be of arbitrary format (as is the case for AMP). Fixes ampproject#6379

…mainRenderingUntilDeprecated" feature. (ampproject#6924)

* update doc * small fix * update * nit

ampproject#6803) * Merges isDevChannel() and isDevChannelVersionDoNotUse_(). * Update js doc * Remove unnecessary dep-checks. * fix

* initial commit for bind expression AST * fix lint and type errors * rename ASTType to ASTNodeType * move try/catch to evaluator * add some comments * move other try/catch to evaluator * PR comments * change enum to number, fix type errors * justin's comments

…est (ampproject#6908)

…mpproject#6920) * Added IE11 Compatible Charset for SVGs As the title States, added IE11 compatible charset for CSS SVGs. Shorthands will break SVG support * Made All utf8 svg's IE11 compatible

* Launch amp-playbuzz experiment * notes

…mpproject#6917) * Fix structured return from key signing in a number of negative cases. Refactor for cleanliness. Add tests.

* Default requireAmpResponseSourceOrigin to true. * Fix type checks.

* Squash commits for bind mutation flow refactor * extend amp css regexp to include i-amphtml- * PR comments * PR comments * tweak mutate callback to pass non-string-cast result, also ignore unused old value * justin's comments * fix type error * fix rebase errors * justin's comment, fix callback triggering incorrectly for boolean attrs

* write out css files to build and dist folders * temp

…ect#6937) * Reorganize karma config files. * Remove unused code. * Simplify logic. * Some more improvements. * Avoid using a karma config file. Put everything into a config object instead. This completely solves the hard-to-explain config overridden problem. * Document hardcoded log level constants. * Import gulp server into Karma server as a middleware

These contain zero information and so we only care about the count, but not about getting every single one. See ampproject#7353 for context.

…oject#7358) …and then catching the `error` event. Part of ampproject#7353

* Address issue 6780 * Move crypto into its own service; add test coverage * fix merge conflicts * PR review * Move amp analytics into crypto service * PR review * PR reviews * test/presubmit fixes * fix linter error

…atest details (ampproject#7385) * updating weekly status and design doc sections * Update CONTRIBUTING.md

* Remove GPU rasterizaton reasoning for viewport * Add links for remaining analytics vendors

* avoid referencing Chunks in extension * fix unit test * fix presubmit * malte's comment

Part of ampproject#7353

Fixes ampproject#7404

…#7410) This reverts commit e63b410.

* Visibility-v2: use IntersectionObserverPolyfill * Address comments

…#7408)

…mpproject#7417)

…roject#7409) Makes it easier to identify problems in tests.

chenshay and others added 30 commits January 5, 2017 11:21

Lazily allocate observables (ampproject#6839)

9fbd67f

* fix * fix * fix * size * fix

Fix an un-closed amp-ad tag in example. (ampproject#6889)

185ca00

* Fix an un-closed amp-ad tag in example. Fix some bad indentation. * style fixes * single quote to double quote

Validator Rollup (ampproject#6898)

4e365e5

Validator Rollup

Add amp.cloudflare.com to forms testcase. (ampproject#6899)

527f16e

Pass down experiment toggles to 3p iframes. (ampproject#6801)

100a029

* Pass down experiment toggles to 3p iframes. * Fix type checks. * Fix tests. * update test

Make the mask the child of the document body and not the fixed layer. (…

fdf2220

…ampproject#6903)

Remove whitelist for ooyala-player validator (ampproject#6904)

17cd61a

Tweak regex to allow \n in variable values. (ampproject#6896)

0978711

* Tweak regex to allow \n in variable values. Fixes ampproject#6885

amp-youtube: Remove the layout wait, issue seems to have been fixed b…

c6a09a5

…y YT (ampproject#6915) * Remove the layout wait, issue seems to have been fixed by YT * Lint

Allow amp-form to update amp-state (ampproject#6820)

d6eb7ff

* initial commit for bind/form integration * fix type error * fix unit test * PR comments

Revert "Proxying the form to call the prototype methods/properties" (a…

514c255

…mpproject#6911)

add integration test to 3p ad (ampproject#6789)

e61445a

* wip * first version test * dispatch scroll event * wip * wip * push to heroku * make it work * enable io for fake3pad example * fix test * fix * add validateDate check to _ping_ * use platform isChrome * nit

Switched from vid to cid for adsense and doubleclick integrations (am…

494f6fb

…pproject#6895) The backends expect vid to be of a particular format: NNNNNN.NNNNNN. Whereas cid can be of arbitrary format (as is the case for AMP). Fixes ampproject#6379

Update doubleclick.md to properly reflect the state of the "useSameDo…

021c613

…mainRenderingUntilDeprecated" feature. (ampproject#6924)

doc change on amp-accordion (ampproject#6448)

d07856b

* update doc * small fix * update * nit

actually generate ampcontext-v0.js (ampproject#6919)

2f6d82d

Merges isDevChannel() and isDevChannelVersionDoNotUse_() to isCanary() (

c7631f9

ampproject#6803) * Merges isDevChannel() and isDevChannelVersionDoNotUse_(). * Update js doc * Remove unnecessary dep-checks. * fix

Add whatsapp to default config for amp-social-share and update pinter…

8033713

…est (ampproject#6908)

Fixed Carousel Arrow SVGs - Added IE11 Compatible Charset for SVGs (a…

33739b9

…mpproject#6920) * Added IE11 Compatible Charset for SVGs As the title States, added IE11 compatible charset for CSS SVGs. Shorthands will break SVG support * Made All utf8 svg's IE11 compatible

remove 2 vp length check (ampproject#6907)

bcaa1ca

Launch amp-playbuzz experiment (ampproject#6947)

adb6015

* Launch amp-playbuzz experiment * notes

Fix structured return from key signing in a number of negative cases (a…

5624059

…mpproject#6917) * Fix structured return from key signing in a number of negative cases. Refactor for cleanliness. Add tests.

Fixing broken carousel snap on master (ampproject#6949)

f11a5da

Default requireAmpResponseSourceOrigin to true. (ampproject#6744)

98fdc2b

* Default requireAmpResponseSourceOrigin to true. * Fix type checks.

Allow data-amp-replace on input[type=hidden]. (ampproject#6952)

5199aa0

write out css files to build and dist folders (ampproject#6946)

a95aaf9

* write out css files to build and dist folders * temp

Launch amp-selector (ampproject#6969)

f627a36

cramforce and others added 26 commits February 6, 2017 10:54

Throttle "Script error." reports. (ampproject#7371)

9605919

These contain zero information and so we only care about the count, but not about getting every single one. See ampproject#7353 for context.

Turn on ad loading ux on prod. (ampproject#7315)

e63b410

Remove amp-video from list of built-ins (ampproject#7311)

c0f6e75

Directly report logged errors instead of relying on rethrowing (amppr…

7e15764

…oject#7358) …and then catching the `error` event. Part of ampproject#7353

Rename messaging request string in history (ampproject#7382)

cb74df7

use source url instead of window.location (ampproject#7302)

b9a0974

rename goToSlide event to slideChange (ampproject#7387)

ad9d07a

Fix race condition within A4A verify (ampproject#6837)

211119b

* Address issue 6780 * Move crypto into its own service; add test coverage * fix merge conflicts * PR review * Move amp analytics into crypto service * PR review * PR reviews * test/presubmit fixes * fix linter error

Fix article-fixed-header example (ampproject#7356)

4d8f17b

Update CONTRIBUTING Weekly Status & Design Review sections with the l…

fbc0bc2

…atest details (ampproject#7385) * updating weekly status and design doc sections * Update CONTRIBUTING.md

Docs add links for analytics vendors (ampproject#7375)

26b636b

* Remove GPU rasterizaton reasoning for viewport * Add links for remaining analytics vendors

Fix Chunks in extensions (ampproject#7374)

483e227

* avoid referencing Chunks in extension * fix unit test * fix presubmit * malte's comment

Remove GPU rasterizaton reasoning for viewport (ampproject#7373)

a427135

Directly report errors for browser events and timer. (ampproject#7363)

6a97771

Part of ampproject#7353

Launch make-body-relative (ampproject#7403)

eeebd93

bump amphtml-validator version (ampproject#7407)

76a39ec

Fixes ampproject#7404

Fix history.pushState /undefined on Edge. (ampproject#7386)

184c0c9

Revert "Turn on ad loading ux on prod. (ampproject#7315)" (ampproject…

fa407ec

…#7410) This reverts commit e63b410.

Visibility-v2: use IntersectionObserverPolyfill (ampproject#7383)

f1e09f0

* Visibility-v2: use IntersectionObserverPolyfill * Address comments

Split up variable substitutions in forms for POST submits (ampproject…

8a06609

…#7408)

Cleanup amp-form-custom-validations experiment (ampproject#7405)

8cefbe6

Refactor spy/stub called expectations (ampproject#7412)

deda591

Document amp-selector's select event (ampproject#7411)

47b8140

Fix visibility test failed on browsers without IntersectionObserver (a…

b9bf1f9

…mpproject#7417)

Fix all errors that we throw during tests that throw no errors. (ampp…

7ed7a89

…roject#7409) Makes it easier to identify problems in tests.

Merge branch 'master' into php-validator-generated

bc0812e

dawehner changed the title ~~Try to pull in changes to google:master~~ Try to pull in changes from google:master Feb 8, 2017

dawehner mentioned this pull request Feb 10, 2017

Try to integrate the amp-hulu tag Lullabot/amp-library#162

Open

dawehner added a commit to dawehner/amp-library that referenced this pull request Feb 13, 2017

Update the specfile generated by Lullabot/amphtml#1

dda5e38

obeyer mentioned this pull request May 10, 2017

question: validator-generated.php Lullabot/amp-library#181

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try to pull in changes from google:master #1

Try to pull in changes from google:master #1

dawehner commented Feb 8, 2017 •

edited

Loading

Try to pull in changes from google:master #1

Are you sure you want to change the base?

Try to pull in changes from google:master #1

Conversation

dawehner commented Feb 8, 2017 • edited Loading

dawehner commented Feb 8, 2017 •

edited

Loading