-
Notifications
You must be signed in to change notification settings - Fork 11
Try to pull in changes from google:master #1
base: php-validator-generated
Are you sure you want to change the base?
Try to pull in changes from google:master #1
Commits on Jan 5, 2017
-
Lazily allocate observables (ampproject#6839)
* fix * fix * fix * size * fix
Configuration menu - View commit details
-
Copy full SHA for 9fbd67f - Browse repository at this point
Copy the full SHA 9fbd67fView commit details -
Fix an un-closed amp-ad tag in example. (ampproject#6889)
* Fix an un-closed amp-ad tag in example. Fix some bad indentation. * style fixes * single quote to double quote
Configuration menu - View commit details
-
Copy full SHA for 185ca00 - Browse repository at this point
Copy the full SHA 185ca00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e365e5 - Browse repository at this point
Copy the full SHA 4e365e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 527f16e - Browse repository at this point
Copy the full SHA 527f16eView commit details -
Pass down experiment toggles to 3p iframes. (ampproject#6801)
* Pass down experiment toggles to 3p iframes. * Fix type checks. * Fix tests. * update test
Configuration menu - View commit details
-
Copy full SHA for 100a029 - Browse repository at this point
Copy the full SHA 100a029View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdf2220 - Browse repository at this point
Copy the full SHA fdf2220View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17cd61a - Browse repository at this point
Copy the full SHA 17cd61aView commit details
Commits on Jan 6, 2017
-
Tweak regex to allow \n in variable values. (ampproject#6896)
* Tweak regex to allow \n in variable values. Fixes ampproject#6885
Configuration menu - View commit details
-
Copy full SHA for 0978711 - Browse repository at this point
Copy the full SHA 0978711View commit details -
amp-youtube: Remove the layout wait, issue seems to have been fixed b…
…y YT (ampproject#6915) * Remove the layout wait, issue seems to have been fixed by YT * Lint
Configuration menu - View commit details
-
Copy full SHA for c6a09a5 - Browse repository at this point
Copy the full SHA c6a09a5View commit details -
Allow amp-form to update amp-state (ampproject#6820)
* initial commit for bind/form integration * fix type error * fix unit test * PR comments
William Chou authoredJan 6, 2017 Configuration menu - View commit details
-
Copy full SHA for d6eb7ff - Browse repository at this point
Copy the full SHA d6eb7ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 514c255 - Browse repository at this point
Copy the full SHA 514c255View commit details -
add integration test to 3p ad (ampproject#6789)
* wip * first version test * dispatch scroll event * wip * wip * push to heroku * make it work * enable io for fake3pad example * fix test * fix * add validateDate check to _ping_ * use platform isChrome * nit
Configuration menu - View commit details
-
Copy full SHA for e61445a - Browse repository at this point
Copy the full SHA e61445aView commit details -
Switched from vid to cid for adsense and doubleclick integrations (am…
…pproject#6895) The backends expect vid to be of a particular format: NNNNNN.NNNNNN. Whereas cid can be of arbitrary format (as is the case for AMP). Fixes ampproject#6379
Configuration menu - View commit details
-
Copy full SHA for 494f6fb - Browse repository at this point
Copy the full SHA 494f6fbView commit details -
Update doubleclick.md to properly reflect the state of the "useSameDo…
…mainRenderingUntilDeprecated" feature. (ampproject#6924)
Configuration menu - View commit details
-
Copy full SHA for 021c613 - Browse repository at this point
Copy the full SHA 021c613View commit details -
doc change on amp-accordion (ampproject#6448)
* update doc * small fix * update * nit
Configuration menu - View commit details
-
Copy full SHA for d07856b - Browse repository at this point
Copy the full SHA d07856bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f6d82d - Browse repository at this point
Copy the full SHA 2f6d82dView commit details
Commits on Jan 7, 2017
-
Merges isDevChannel() and isDevChannelVersionDoNotUse_() to isCanary() (
ampproject#6803) * Merges isDevChannel() and isDevChannelVersionDoNotUse_(). * Update js doc * Remove unnecessary dep-checks. * fix
Configuration menu - View commit details
-
Copy full SHA for c7631f9 - Browse repository at this point
Copy the full SHA c7631f9View commit details -
Use intermediary AST for Bind expression evaluation (ampproject#6840)
* initial commit for bind expression AST * fix lint and type errors * rename ASTType to ASTNodeType * move try/catch to evaluator * add some comments * move other try/catch to evaluator * PR comments * change enum to number, fix type errors * justin's comments
William Chou authoredJan 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 06836b7 - Browse repository at this point
Copy the full SHA 06836b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8033713 - Browse repository at this point
Copy the full SHA 8033713View commit details
Commits on Jan 9, 2017
-
Fixed Carousel Arrow SVGs - Added IE11 Compatible Charset for SVGs (a…
…mpproject#6920) * Added IE11 Compatible Charset for SVGs As the title States, added IE11 compatible charset for CSS SVGs. Shorthands will break SVG support * Made All utf8 svg's IE11 compatible
Configuration menu - View commit details
-
Copy full SHA for 33739b9 - Browse repository at this point
Copy the full SHA 33739b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcaa1ca - Browse repository at this point
Copy the full SHA bcaa1caView commit details -
Launch amp-playbuzz experiment (ampproject#6947)
* Launch amp-playbuzz experiment * notes
Dima Voytenko authoredJan 9, 2017 Configuration menu - View commit details
-
Copy full SHA for adb6015 - Browse repository at this point
Copy the full SHA adb6015View commit details -
Fix structured return from key signing in a number of negative cases (a…
…mpproject#6917) * Fix structured return from key signing in a number of negative cases. Refactor for cleanliness. Add tests.
Configuration menu - View commit details
-
Copy full SHA for 5624059 - Browse repository at this point
Copy the full SHA 5624059View commit details -
Configuration menu - View commit details
-
Copy full SHA for f11a5da - Browse repository at this point
Copy the full SHA f11a5daView commit details -
Default requireAmpResponseSourceOrigin to true. (ampproject#6744)
* Default requireAmpResponseSourceOrigin to true. * Fix type checks.
Configuration menu - View commit details
-
Copy full SHA for 98fdc2b - Browse repository at this point
Copy the full SHA 98fdc2bView commit details
Commits on Jan 10, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5199aa0 - Browse repository at this point
Copy the full SHA 5199aa0View commit details -
amp-bind: Refactor attribute mutation flow (ampproject#6779)
* Squash commits for bind mutation flow refactor * extend amp css regexp to include i-amphtml- * PR comments * PR comments * tweak mutate callback to pass non-string-cast result, also ignore unused old value * justin's comments * fix type error * fix rebase errors * justin's comment, fix callback triggering incorrectly for boolean attrs
William Chou authoredJan 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 379c8a3 - Browse repository at this point
Copy the full SHA 379c8a3View commit details -
write out css files to build and dist folders (ampproject#6946)
* write out css files to build and dist folders * temp
Configuration menu - View commit details
-
Copy full SHA for a95aaf9 - Browse repository at this point
Copy the full SHA a95aaf9View commit details -
Import Gulp webserver as a middleware into Karma test server (ampproj…
…ect#6937) * Reorganize karma config files. * Remove unused code. * Simplify logic. * Some more improvements. * Avoid using a karma config file. Put everything into a config object instead. This completely solves the hard-to-explain config overridden problem. * Document hardcoded log level constants. * Import gulp server into Karma server as a middleware
Configuration menu - View commit details
-
Copy full SHA for f7f408e - Browse repository at this point
Copy the full SHA f7f408eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f627a36 - Browse repository at this point
Copy the full SHA f627a36View commit details -
Scan used extension in HTML head, instead whole document. (ampprojec…
…t#6954) * Scan used extension in HTML head, instead whole document. * Fix test.
Configuration menu - View commit details
-
Copy full SHA for 2a123e6 - Browse repository at this point
Copy the full SHA 2a123e6View commit details -
Allow experiments being opted in at document level. (ampproject#6938)
* Allow experiments being opted in at document level. * Update README. * Update readme. * Update README.
Configuration menu - View commit details
-
Copy full SHA for 1f620b6 - Browse repository at this point
Copy the full SHA 1f620b6View commit details -
Proxying the form to call the prototype methods/properties, incl Chro…
…me 45 (ampproject#6944) * Proxying the form to call the prototype methods/properties, incl Chrome 45 support * Support legacy properties * review fixes * review fixes
Dima Voytenko authoredJan 10, 2017 Configuration menu - View commit details
-
Copy full SHA for 5443d59 - Browse repository at this point
Copy the full SHA 5443d59View commit details -
Added initial version of amp-anlaytics variable filters. (ampproject#…
…6560) Closes ampproject#5621.
Configuration menu - View commit details
-
Copy full SHA for 69c6baf - Browse repository at this point
Copy the full SHA 69c6bafView commit details
Commits on Jan 11, 2017
-
Bind validator (ampproject#6665)
* squash bind-validation commits * fix inconsistencies after rebase * externalize createRules to avoid dupe work * lint and type errors * one more lint error
William Chou authoredJan 11, 2017 Configuration menu - View commit details
-
Copy full SHA for daf326a - Browse repository at this point
Copy the full SHA daf326aView commit details -
Ensure that iframe is fully x-origin for 3p case (ampproject#6979)
Dima Voytenko authoredJan 11, 2017 Configuration menu - View commit details
-
Copy full SHA for 1181681 - Browse repository at this point
Copy the full SHA 1181681View commit details -
Ad type adverticumv.2 (ampproject#6493)
* adTypeAdverticum integration v2 * Mistakes were made. Fixed them. * more type and code style fix * example fix * code style and typo fixes added validateData function * Missing ; ... * Removed IF by mistake * Codestyle fix * Update adverticum.js * Update adverticum.js
Configuration menu - View commit details
-
Copy full SHA for 2c6e6f7 - Browse repository at this point
Copy the full SHA 2c6e6f7View commit details -
Reverts ampproject#6952 but keep the removal of default-value (amppro…
…ject#6983) * Revert ampproject#6952 but keep the removal of default-value
Configuration menu - View commit details
-
Copy full SHA for 633d45b - Browse repository at this point
Copy the full SHA 633d45bView commit details -
amp-viewer-integration handshake updates (ampproject#6845)
* example * fix * fix * new message format * fix * tests * typedef * test fixes * fixes * tests * error logging * type fix * type fix * viewerorigin -> origin * fixes * amp-handshake-request -> channelOpen * more fixes * logging fixes * error messaging * more fixes * test fix
Configuration menu - View commit details
-
Copy full SHA for 9ee7c1f - Browse repository at this point
Copy the full SHA 9ee7c1fView commit details -
Introduces logic for A4A Multisize implementation. (ampproject#6677)
* Factored out multi-size logic into its own module. * Added some debugging infrastructure. * Debug code. * Added frontend logic. * Client now makes appropriate resize request of amp-ad element. * Modified sz url parameter to accomodate multi-size. * Code cleanup. * Reverted example page. * Added example page + logic for 3p case. * Unit tests. * Added some unit tests for a4a multisize. * Rebased and fixed merges. * Reintroduced a4a carveout for multisize until BOW release is unfrozen. * Corrected comments. * Fixed types which were broken when carve-out was carved out. * Removed dead code. * Addressing feedback. * Removing accidentally added files. * Changed how multiSizeValidation boolean is handled. * Factored out existence check for creativeParts. * Clarified doc string. * Updated doc string & minor changes. * Removed extraneous comment. * Removed unneeded Number cast. * Moved missing signature check upstream. * Reinstated missing signature check downstream. * Removed unnecessary call to handleResize.
Configuration menu - View commit details
-
Copy full SHA for 155e23b - Browse repository at this point
Copy the full SHA 155e23bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83d40e0 - Browse repository at this point
Copy the full SHA 83d40e0View commit details
Commits on Jan 12, 2017
-
Configuration menu - View commit details
-
Copy full SHA for fa63c19 - Browse repository at this point
Copy the full SHA fa63c19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0027e1d - Browse repository at this point
Copy the full SHA 0027e1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ab78ba8 - Browse repository at this point
Copy the full SHA ab78ba8View commit details -
Add support for Bind's linked carousels use case (ampproject#6797)
* initial commit for linked carousels support * fix lint and type errors * PR comments * more PR comments * add unit tests * PR comments and API updates * add tag to warn()
William Chou authoredJan 12, 2017 Configuration menu - View commit details
-
Copy full SHA for eca0ca6 - Browse repository at this point
Copy the full SHA eca0ca6View commit details -
Add amp-bind support to amp-video (ampproject#6905)
* initial commit for bind support in amp-video * type cast to mollify closure * fix presubmit error, api updates * fix unit test
William Chou authoredJan 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 73d66af - Browse repository at this point
Copy the full SHA 73d66afView commit details -
Assorted Bind validator fixes (ampproject#7005)
* validator follow-up from ali's comments * ali's comment
William Chou authoredJan 12, 2017 Configuration menu - View commit details
-
Copy full SHA for ff76164 - Browse repository at this point
Copy the full SHA ff76164View commit details -
Let all async gulp tasks return Promise. (ampproject#6844)
* Let all async gulp tasks return Promise. * Fix buildSw. * fix bad merge * fix merge
Configuration menu - View commit details
-
Copy full SHA for fa5c6cc - Browse repository at this point
Copy the full SHA fa5c6ccView commit details -
Expose move to slide method on slidescroll to enable flim-strip exper…
…ience (ampproject#6914) * testing gallery with amp-selector * Plausible gallery experience * Review changes * Adding tests
Configuration menu - View commit details
-
Copy full SHA for 9e555b7 - Browse repository at this point
Copy the full SHA 9e555b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad75d41 - Browse repository at this point
Copy the full SHA ad75d41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 663f1f4 - Browse repository at this point
Copy the full SHA 663f1f4View commit details -
Pixel re-implemented to trigger immediately on visibility (ampproject…
…#6988) * Pixel re-implemented to trigger immediately on visibility * review fixes * lints * test fixes * lints
Dima Voytenko authoredJan 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 04d1d8e - Browse repository at this point
Copy the full SHA 04d1d8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed05a09 - Browse repository at this point
Copy the full SHA ed05a09View commit details -
Unlaunch ios-embed-wrapper for iOS8 to avoid scroll freezing issues (a…
Dima Voytenko authoredJan 12, 2017 Configuration menu - View commit details
-
Copy full SHA for 4adf4df - Browse repository at this point
Copy the full SHA 4adf4dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80ff445 - Browse repository at this point
Copy the full SHA 80ff445View commit details -
Configuration menu - View commit details
-
Copy full SHA for f069143 - Browse repository at this point
Copy the full SHA f069143View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2bac16 - Browse repository at this point
Copy the full SHA f2bac16View commit details -
Configuration menu - View commit details
-
Copy full SHA for e56601a - Browse repository at this point
Copy the full SHA e56601aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5d305c - Browse repository at this point
Copy the full SHA c5d305cView commit details
Commits on Jan 13, 2017
-
skeleton for amp-tabs (ampproject#7003)
* skeleton for amp-tabs * lint fix * fix * added experiment
Configuration menu - View commit details
-
Copy full SHA for a72a54f - Browse repository at this point
Copy the full SHA a72a54fView commit details -
Validator rollup (ampproject#7023)
* Disallow id="AMP" for all elements. * More disallowed id and name attribute values. * Remove old code for generating manufactured body tag warnings. * Refactoring: Remove template_spec_url field from ParsedTagSpec; access validator rules via Context instance instead. * Make the unused extension warning more descriptive. * Revision bump for input change. * `<amp-analytics>` is required by `<amp-access>`. Fix this warning message. * Remove unused field.
Configuration menu - View commit details
-
Copy full SHA for 9b66415 - Browse repository at this point
Copy the full SHA 9b66415View commit details -
Laterpay validator config (ampproject#6974)
* Laterpay validator config * test files * review fixes
Dima Voytenko authoredJan 13, 2017 Configuration menu - View commit details
-
Copy full SHA for f17c0f5 - Browse repository at this point
Copy the full SHA f17c0f5View commit details -
Avoid duplicating server-layout (ampproject#7021)
* Avoid duplicating server-layout * fixe * pass the signal back to viewer * ensure that sizer can be read immediately or later * lints * test fixes
Dima Voytenko authoredJan 13, 2017 Configuration menu - View commit details
-
Copy full SHA for bb087e3 - Browse repository at this point
Copy the full SHA bb087e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0eaea8 - Browse repository at this point
Copy the full SHA b0eaea8View commit details -
Use URL replacer from embed for pixel (ampproject#7029)
Dima Voytenko authoredJan 13, 2017 Configuration menu - View commit details
-
Copy full SHA for fd2cfc7 - Browse repository at this point
Copy the full SHA fd2cfc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93b67b0 - Browse repository at this point
Copy the full SHA 93b67b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c882ba1 - Browse repository at this point
Copy the full SHA c882ba1View commit details -
Moves closure sha384 into a new extension amp-crypto-polyfill for laz…
…y load (ampproject#7006) * Moves closure sha384 into a new extension amp-crypto-polyfill for lazy load. * fix * Update tests. Remove base64 polyfill from lib. * Fix presubmit * Address comments * Fix test.
Configuration menu - View commit details
-
Copy full SHA for 17136cf - Browse repository at this point
Copy the full SHA 17136cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b12f9e - Browse repository at this point
Copy the full SHA 8b12f9eView commit details
Commits on Jan 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for af21b1b - Browse repository at this point
Copy the full SHA af21b1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3209535 - Browse repository at this point
Copy the full SHA 3209535View commit details -
Update csa.md to remove non-required parameters (ampproject#6902)
* Update csa.md to remove non-required parameters Removed non-required parameters (width, layout) from the amp-ad tag. * Updated csa.md to combine text in multiple lines
Configuration menu - View commit details
-
Copy full SHA for 01bb681 - Browse repository at this point
Copy the full SHA 01bb681View commit details
Commits on Jan 17, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5fddb61 - Browse repository at this point
Copy the full SHA 5fddb61View commit details -
Early implementation of amp-access-laterpay (ampproject#5920)
* Early implementation of amp-access-laterpay * Remove unused amp-access-laterpay config params * Code cleanup issues from PR * Expose response in error object for assertSuccess * Further work on amp-access-laterpay - Remove unnecessary pingback skeleton - Add jsdoc annotations for existing code - Laterpay config retrieval based on draft spec - Improve rendering of the purchase overlay - Price formatting and localization * Expose adapter config on AccessService * Fix pingback detection in amp-access-vendor * Allow amp-access login flow with url only Create new methods loginWithType_ (similar to old login method) and loginWithUrl as entry points to old login method (now private). * Fix exposure of amp access vendor config * Add "already purchased" link * Add CSS for amp-access-laterpay * PR feedback fixes: - add private tag - ensure assert comes first * Add event label to loginWithUrl calls * Also check if we're on localdev mode * Fix amp-access login tests * Fix amp-access-vendor tests * Use id instead of custom element for amp-access-laterpay * Override pingback in amp-access-laterpay * Expose buildUrl in amp-access * Add tests for amp-access-laterpay * Simplify example page * Apply labels properly based on purchase type Also rename i18n keys for clarity. * Add readme for amp-access-laterpay * Typos, cleanup, linting * Add option for scrolling to top after auth * Add header/footer to amp-access-laterpay * Fix some default styling issues * Address PR feedback and update LaterPay description * Address more PR feedback fixes * Add validator info to amp-access-laterpay readme * Add types for missing config options * Add sandbox flag to LaterPay config options * Fix some linting and rules issues - add license to css file - rename property to avoid scrollTop check
Configuration menu - View commit details
-
Copy full SHA for 1972fac - Browse repository at this point
Copy the full SHA 1972facView commit details -
Overflow element must have position:relative style (ampproject#7061)
Dima Voytenko authoredJan 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 9b2d835 - Browse repository at this point
Copy the full SHA 9b2d835View commit details -
Temporary solution for most common form-proxy failures (ampproject#7065)
* Temporary solution for most common form-proxy failures * tests fixed
Dima Voytenko authoredJan 17, 2017 Configuration menu - View commit details
-
Copy full SHA for ec96f9f - Browse repository at this point
Copy the full SHA ec96f9fView commit details -
Add Carousel and Selector to Bind validator (ampproject#7067)
* fix missing bind validator support and other small fixes * update test-bind-validator.js * avoid early-out in amp-selector [selected] mutate when value == 0
William Chou authoredJan 17, 2017 Configuration menu - View commit details
-
Copy full SHA for f77fe08 - Browse repository at this point
Copy the full SHA f77fe08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c9cdcf - Browse repository at this point
Copy the full SHA 4c9cdcfView commit details
Commits on Jan 18, 2017
-
Changing the <amp-auto-ads> config URL code for AdSense to use the pa…
…ge's canonical URL (ampproject#6753)
Configuration menu - View commit details
-
Copy full SHA for 766b89c - Browse repository at this point
Copy the full SHA 766b89cView commit details -
add a way to override hostname (ampproject#6972)
* add a way to override hostname * rollback 3p url change * org -> net
Configuration menu - View commit details
-
Copy full SHA for 2a7cfaa - Browse repository at this point
Copy the full SHA 2a7cfaaView commit details -
Reuse resource when reparented for some extensions (ampproject#7035)
* Reuse resource when reparented for some extensions * examples in docs
Dima Voytenko authoredJan 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 49f80f9 - Browse repository at this point
Copy the full SHA 49f80f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bbc9fb - Browse repository at this point
Copy the full SHA 9bbc9fbView commit details -
Fix incorrect documentation for extended templates (ampproject#7068)
Extended templates are loaded by including a `<script>` tag with a `custom-template` attribute rather than a `custom-element` attribute.
Configuration menu - View commit details
-
Copy full SHA for eda679b - Browse repository at this point
Copy the full SHA eda679bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a456ff8 - Browse repository at this point
Copy the full SHA a456ff8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51762e9 - Browse repository at this point
Copy the full SHA 51762e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5475006 - Browse repository at this point
Copy the full SHA 5475006View commit details -
Make zid optional (ampproject#7071)
* make zid optional * formatting
Configuration menu - View commit details
-
Copy full SHA for 43c7963 - Browse repository at this point
Copy the full SHA 43c7963View commit details -
Append CSA container to 'c' container (ampproject#7083)
* Set container style to absolute * Append CSA container to 'c' element, not body * update unit tests to include c div
Configuration menu - View commit details
-
Copy full SHA for bbe4f48 - Browse repository at this point
Copy the full SHA bbe4f48View commit details -
Fix broken shields (ampproject#7051)
* Fix broken shields Seems like issuestats has died :( Just removed the broken images and changed them to be shield.io shields and link to their respective tabs on github. * Remove shields
Configuration menu - View commit details
-
Copy full SHA for 330fdb2 - Browse repository at this point
Copy the full SHA 330fdb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd9f04d - Browse repository at this point
Copy the full SHA bd9f04dView commit details -
Changed amp3pSentinel to sentinel with exp flag (ampproject#6922)
* Changed amp3pSentinel to sentinel with exp flag * Fixed flagging all uses of amp3pSentinel to sentinel change * Fixed presubmit issues * Whitelisted dist.3p/current/integration.js for cookie related presubmit stuff * Fixed dependency issue * Properly test both cases of the experiment * Added cleanup issue * Fixed lint issue * Addressed comments to test both cases of experiment * Fixed toggling off exp and using correct win * Removed unneeded complexity * Reverted presubmit-checks
Configuration menu - View commit details
-
Copy full SHA for fe7e0ae - Browse repository at this point
Copy the full SHA fe7e0aeView commit details -
<amp-apester-media> out of experiment (ampproject#7055)
* feat(apester-media): apester out of experiments This changes amp-apester-media status from experiments to stable, also include update to apester custom-loader (urgent fix) * refactor: remove whitespace * fix: removed unused line * fix: lint, change innerHTML to DOM api
Configuration menu - View commit details
-
Copy full SHA for 8a02253 - Browse repository at this point
Copy the full SHA 8a02253View commit details -
use switch statement in mergeShadowHead and ignore other link relatio…
…n values (ampproject#7069)
William Chou authoredJan 18, 2017 Configuration menu - View commit details
-
Copy full SHA for 904490d - Browse repository at this point
Copy the full SHA 904490dView commit details -
Update ads/README.md to mention the container div. (ampproject#7090)
* Update ads/README.md to mention the container div. * improve wording
Configuration menu - View commit details
-
Copy full SHA for 390ee71 - Browse repository at this point
Copy the full SHA 390ee71View commit details -
Use resource.layoutBox instead of change.boundingClientRect to calcu…
…late elementX, elementY in amp-analytics visiblity tracking. (ampproject#7089)
Configuration menu - View commit details
-
Copy full SHA for 78de1c5 - Browse repository at this point
Copy the full SHA 78de1c5View commit details -
Removes multi-size carveout from Fast Fetch. (ampproject#7092)
* Removed multi-size carveout from Fast Fetch. * Actually removed carveout this time. * Removed unused element parameter.
Configuration menu - View commit details
-
Copy full SHA for c0a5834 - Browse repository at this point
Copy the full SHA c0a5834View commit details
Commits on Jan 19, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 984dd5f - Browse repository at this point
Copy the full SHA 984dd5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 337bd04 - Browse repository at this point
Copy the full SHA 337bd04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b77dd9 - Browse repository at this point
Copy the full SHA 7b77dd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eb6f9a - Browse repository at this point
Copy the full SHA 8eb6f9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3827c5f - Browse repository at this point
Copy the full SHA 3827c5fView commit details -
Add base implementation getHTML (ampproject#6818)
* Add base implementation getHTML * Fix codestyle * CR fix * fix linting error * CR fix * fix * fix * fix * fix * fix * fix
Configuration menu - View commit details
-
Copy full SHA for d5ebb22 - Browse repository at this point
Copy the full SHA d5ebb22View commit details -
Removed iframeContextInName flag for experiment (ampproject#7107)
* Removed flag for context in name experiment * Removed flag from prod and canary config
Configuration menu - View commit details
-
Copy full SHA for d2029fd - Browse repository at this point
Copy the full SHA d2029fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb2768b - Browse repository at this point
Copy the full SHA bb2768bView commit details -
Introduce field "runtime=inabox" in error reporting to differentiate …
…errors generated from inabox JS. (ampproject#7099)
Configuration menu - View commit details
-
Copy full SHA for 68e0349 - Browse repository at this point
Copy the full SHA 68e0349View commit details
Commits on Jan 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for aa7ebcb - Browse repository at this point
Copy the full SHA aa7ebcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e88a6e0 - Browse repository at this point
Copy the full SHA e88a6e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b2453c - Browse repository at this point
Copy the full SHA 1b2453cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bdb2f7 - Browse repository at this point
Copy the full SHA 3bdb2f7View commit details -
Validator rollup (ampproject#7137)
* Make tagSpecById array; add comment about ids. Remove unused type decl. * Allow SRI attributes for stylesheets. * Object<number, x> -> Array<x> and remove extensionUnusedUnless... * Construct ParsedAttrSpec objects lazily. * Generate a synthetic field ValidatorRules.dispatchKeyByTagSpecId and populate it. * Make the ParsedTagSpec instantiation lazy. * Reduce greediness of i-amphtml- blacklist regex. * More disallowed id and name attribute values. * Allow `nonce` attribute on <script> and <style> tags. * Make validator protoascii usage more consistent. * Allow async attr on font link tag. * Allow <meta http-equiv=origin-trial ...>
Configuration menu - View commit details
-
Copy full SHA for d17e7e2 - Browse repository at this point
Copy the full SHA d17e7e2View commit details
Commits on Jan 21, 2017
-
Configuration menu - View commit details
-
Copy full SHA for e88bd6d - Browse repository at this point
Copy the full SHA e88bd6dView commit details
Commits on Jan 23, 2017
-
ampproject#7045 | Adding Acquia as vendor (ampproject#7103)
* Adding Acquia as vendor * Remove wrong comment * Fix comma-typo * Fix comma-typo * Adding tests to vendor-requests.json * Typo in default causing test failures in the vendor test * Removing unnecessary comment and plus-character * change identity source to tracking and correct the default url * update fixtures * Revert to amp for identity source * remove acquia specific example * Removing json comments
Configuration menu - View commit details
-
Copy full SHA for 52c5f71 - Browse repository at this point
Copy the full SHA 52c5f71View commit details -
Configuration menu - View commit details
-
Copy full SHA for c195bdd - Browse repository at this point
Copy the full SHA c195bddView commit details -
Add amp-bind experiment (ampproject#7157)
* add amp-bind experiment * add experiment check to amp-state * fix unit test
William Chou authoredJan 23, 2017 Configuration menu - View commit details
-
Copy full SHA for 9a464b2 - Browse repository at this point
Copy the full SHA 9a464b2View commit details -
Use proper application/json response header instead of arraybuffer. (a…
…mpproject#7133) * Use proper application/json response header instead of arraybuffer. * fix lints
Configuration menu - View commit details
-
Copy full SHA for 27d6886 - Browse repository at this point
Copy the full SHA 27d6886View commit details -
Fix incorrect nesting of doublequote and square bracket that was brea…
…king some tests on Safari (ampproject#7146) * Add oid param to A4A-generated ad requests to enable ActiveView * Fix incorrect nesting of doublequote and square bracket that was breaking some tests on Safari * Undo adding blank line
Configuration menu - View commit details
-
Copy full SHA for cbf5313 - Browse repository at this point
Copy the full SHA cbf5313View commit details -
Configuration menu - View commit details
-
Copy full SHA for e967073 - Browse repository at this point
Copy the full SHA e967073View commit details -
Configuration menu - View commit details
-
Copy full SHA for a77c434 - Browse repository at this point
Copy the full SHA a77c434View commit details
Commits on Jan 24, 2017
-
Configuration menu - View commit details
-
Copy full SHA for e9349d5 - Browse repository at this point
Copy the full SHA e9349d5View commit details -
Limit form variable substitutions to canonical-origin actions (amppro…
…ject#7169) * Limit form variable substitutions to canonical-origin actions * refactor
Configuration menu - View commit details
-
Copy full SHA for 74d85d6 - Browse repository at this point
Copy the full SHA 74d85d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ef0084 - Browse repository at this point
Copy the full SHA 9ef0084View commit details -
Enable "chunked-amp" in canary (ampproject#7182)
William Chou authoredJan 24, 2017 Configuration menu - View commit details
-
Copy full SHA for 97e17d6 - Browse repository at this point
Copy the full SHA 97e17d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1558a7f - Browse repository at this point
Copy the full SHA 1558a7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e29c339 - Browse repository at this point
Copy the full SHA e29c339View commit details -
Update ad loading UX. (ampproject#7167)
* Update ad loading UX. * Address comment.
Configuration menu - View commit details
-
Copy full SHA for 324d352 - Browse repository at this point
Copy the full SHA 324d352View commit details -
Shadow DOM v1 (ampproject#7059)
* Shadow DOM v1 API support * Removed unintended code comment * PR fixes Gives preference to Shadow DOM v1 over v0 * Fixed lint errors * Fixes to closure-compiler errors Checks again for CE v0 so we don't disable native Shadow DOM in browsers that don't support CE v1 * Fix closure compiler error * Added Shadow DOM v1 spec to Closure Compiler
Oliver Fernandez authored and Dima Voytenko committedJan 24, 2017 Configuration menu - View commit details
-
Copy full SHA for e0c9c88 - Browse repository at this point
Copy the full SHA e0c9c88View commit details
Commits on Jan 25, 2017
-
Configuration menu - View commit details
-
Copy full SHA for fa1bc77 - Browse repository at this point
Copy the full SHA fa1bc77View commit details -
Revert "Use max version on-demand loaded scripts in tests (ampproject…
…#7110)" (ampproject#7181) This reverts commit bb2768b.
Configuration menu - View commit details
-
Copy full SHA for b3719cd - Browse repository at this point
Copy the full SHA b3719cdView commit details -
Apply opacity to the loading line. (ampproject#7189)
* Apply opacity to the loading line. * Tweak color.
Configuration menu - View commit details
-
Copy full SHA for b831a02 - Browse repository at this point
Copy the full SHA b831a02View commit details -
Turn on amp-ad-loading-ux on canary. (ampproject#7187)
* Turn on amp-ad-loading-ux. * Turn off on prod.
Configuration menu - View commit details
-
Copy full SHA for c2b175e - Browse repository at this point
Copy the full SHA c2b175eView commit details -
Documentation about optout control (ampproject#7188)
* Documentation about optout control * fixes
Dima Voytenko authoredJan 25, 2017 Configuration menu - View commit details
-
Copy full SHA for c74c423 - Browse repository at this point
Copy the full SHA c74c423View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0004fb7 - Browse repository at this point
Copy the full SHA 0004fb7View commit details -
Adds way for Fast Fetch to collapse ads with 204 response code. (ampp…
…roject#7131) * Added way for Fast Fetch to collapse ads with 204 response code. * Addressing PR feedback. * Update test-amp-a4a.js * Added integration test for collapse behavior. * Added additional tests for response and response.arrayBuffer being null. * PR feedback. * PR feedback. * Removing test file. * Bumping to retrigger travis. * Travis.
Configuration menu - View commit details
-
Copy full SHA for add2c44 - Browse repository at this point
Copy the full SHA add2c44View commit details -
Clarify that assertString/Number allow empty string and zero (ampproj…
…ect#7202) * Clarify that assertString/Number allow empty string and zero * tests * include NaN in doca
Dima Voytenko authoredJan 25, 2017 Configuration menu - View commit details
-
Copy full SHA for ce82f49 - Browse repository at this point
Copy the full SHA ce82f49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60a0a68 - Browse repository at this point
Copy the full SHA 60a0a68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a547b9 - Browse repository at this point
Copy the full SHA 6a547b9View commit details -
Analytics root to separate top-level vs embed analytics for FIE (ampp…
…roject#7172) * Analytics root to separate top-level vs embed analytics for FIE * test fixes * more docs
Dima Voytenko authoredJan 25, 2017 Configuration menu - View commit details
-
Copy full SHA for 1736865 - Browse repository at this point
Copy the full SHA 1736865View commit details -
Create a pull request template for the project. (ampproject#7193)
The template should help make pull requests easier to read and overall more uniform. - Does not propose complicated syntax for titles (or rather forbids it). - Encourages referencing issues. This is a bit of an RFC. Feedback is welcome. One thing I don't actually know (and the GH docs don't say), is how this template influences auto-generated PR text. It would be really annoying if that no longer happened.
Configuration menu - View commit details
-
Copy full SHA for 96ad4af - Browse repository at this point
Copy the full SHA 96ad4afView commit details -
add yarn.lock file for deterministic builds (ampproject#7041)
* add yarn.lock file for deterministic builds * switch travis to use yarn * fix logic for package.json an yarn.lock check * make sure that it also errors if only yarn.lock exists * add back yarn.lock file * update serving/building docs
Configuration menu - View commit details
-
Copy full SHA for e9fd8e2 - Browse repository at this point
Copy the full SHA e9fd8e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02923dc - Browse repository at this point
Copy the full SHA 02923dcView commit details
Commits on Jan 26, 2017
-
Cloudflare ad network example (ampproject#6882)
* Local debug server changes to fake Cloudflare signing. * Changes to support a new A4A ad network with Cloudflare Signing
Configuration menu - View commit details
-
Copy full SHA for 298920c - Browse repository at this point
Copy the full SHA 298920cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3ca900 - Browse repository at this point
Copy the full SHA e3ca900View commit details -
Fix broken shadow embed test (ampproject#7213)
* Fix broken shadow embed test * fix lint
Configuration menu - View commit details
-
Copy full SHA for eb1acc8 - Browse repository at this point
Copy the full SHA eb1acc8View commit details -
Element-level signals for lifecycle events (ampproject#7205)
* Element-level signals for lifecycle events * fixing tests
Dima Voytenko authoredJan 26, 2017 Configuration menu - View commit details
-
Copy full SHA for 8be35f4 - Browse repository at this point
Copy the full SHA 8be35f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cb150d - Browse repository at this point
Copy the full SHA 0cb150dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c6cbe1 - Browse repository at this point
Copy the full SHA 1c6cbe1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4368b1e - Browse repository at this point
Copy the full SHA 4368b1eView commit details -
Revert "Fix build breakage" (ampproject#6568)
William Chou authoredJan 26, 2017 Configuration menu - View commit details
-
Copy full SHA for 81f7af3 - Browse repository at this point
Copy the full SHA 81f7af3View commit details
Commits on Jan 27, 2017
-
Add ValueCommerce support for amp-ad (ampproject#6962)
* 1st commit * add preconnect ValueCommerce add preconnect ValueCommerce * remove extra space remove extra space
Configuration menu - View commit details
-
Copy full SHA for c6dfcf4 - Browse repository at this point
Copy the full SHA c6dfcf4View commit details -
Update docs for goToSlide (ampproject#7223)
* Update docs for goToSlide * Update actions doc for goToSlide * Update carouse.md with type="slides" note * Update actions doc with type=slides
Configuration menu - View commit details
-
Copy full SHA for e78d99d - Browse repository at this point
Copy the full SHA e78d99dView commit details -
Update csa.md (ampproject#7148)
* Update csa.md Add note to indicate that only multiple-format AFSh ads are supported. * Update csa.md
Configuration menu - View commit details
-
Copy full SHA for 9acc6ad - Browse repository at this point
Copy the full SHA 9acc6adView commit details -
fix [slide]=0 bug (ampproject#7229)
William Chou authoredJan 27, 2017 Configuration menu - View commit details
-
Copy full SHA for 63bc93a - Browse repository at this point
Copy the full SHA 63bc93aView commit details -
Support generic chunking and chunk Bind's DOM scan (ampproject#6967)
* Squash chunk-scan commits * fix lint error * rename chunk to startupChunk, pass viewer from Chunks to StartupTask * fix lint and type errors * support timeRemaining in chunk tasks & misc clean up * justin's comments * dima's comments * malte's comments * style and lint fix * fix unit tests * missed a couple @Private declarations * fix scan iteration * remove for..of * more iteration on iteration * move element scan to helper method
William Chou authoredJan 27, 2017 Configuration menu - View commit details
-
Copy full SHA for 38afb0d - Browse repository at this point
Copy the full SHA 38afb0dView commit details -
Update amp-bind docs (ampproject#7216)
* update bind docs * barb's comments
William Chou authoredJan 27, 2017 Configuration menu - View commit details
-
Copy full SHA for f33b581 - Browse repository at this point
Copy the full SHA f33b581View commit details -
Add URL rewriting and
srcset
support to amp-bind (ampproject#7206)* add srcset support * fix types * rewrite urls for cache * ignore compiler warnings in third_party/caja * whitelist amp-bind to depend on sanitizer.js * ali's comments
William Chou authoredJan 27, 2017 Configuration menu - View commit details
-
Copy full SHA for 4ecfb21 - Browse repository at this point
Copy the full SHA 4ecfb21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78dd260 - Browse repository at this point
Copy the full SHA 78dd260View commit details -
More amp-bind examples in separate folder (ampproject#7127)
* move bind examples to bind/ folder * add sandbox example * add ecommerce example * update titles * replace shirt images * move amp-state to <body> * move <amp-state> to bottom of body * fix amp-bind validator html and output
William Chou authoredJan 27, 2017 Configuration menu - View commit details
-
Copy full SHA for 4224565 - Browse repository at this point
Copy the full SHA 4224565View commit details -
Reduce URL entropy for preconnect polyfill. (ampproject#7227)
A single AMP page would already only connect to a given origin once ever 180 seconds. With this change the URL for doing this will not change within that time interval. That means that all AMP pages that run on computers with roughly correct clocks will request the same URL within a 180 seconds interval, which should make it easier for CDNs to respond efficiently.
Configuration menu - View commit details
-
Copy full SHA for e81104a - Browse repository at this point
Copy the full SHA e81104aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b35ad5 - Browse repository at this point
Copy the full SHA 3b35ad5View commit details -
Configuration menu - View commit details
-
Copy full SHA for eda00e9 - Browse repository at this point
Copy the full SHA eda00e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fed17f - Browse repository at this point
Copy the full SHA 1fed17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecb6afd - Browse repository at this point
Copy the full SHA ecb6afdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eda4a8 - Browse repository at this point
Copy the full SHA 7eda4a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6de676 - Browse repository at this point
Copy the full SHA d6de676View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6c0ed4 - Browse repository at this point
Copy the full SHA f6c0ed4View commit details -
Configuration menu - View commit details
-
Copy full SHA for daf29d3 - Browse repository at this point
Copy the full SHA daf29d3View commit details
Commits on Jan 30, 2017
-
Extract signals into its own class (ampproject#7240)
Dima Voytenko authoredJan 30, 2017 Configuration menu - View commit details
-
Copy full SHA for 87b2dc4 - Browse repository at this point
Copy the full SHA 87b2dc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 487c9a8 - Browse repository at this point
Copy the full SHA 487c9a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 454bf58 - Browse repository at this point
Copy the full SHA 454bf58View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca45634 - Browse repository at this point
Copy the full SHA ca45634View commit details -
Relap support for amp-ads (ampproject#7011)
* Add ads/relap Partial commit Update Relap * Fix to pass CI build * Add renderStart support * Change attributes order * Add double quotes around attribute values
Configuration menu - View commit details
-
Copy full SHA for 5eb7fa9 - Browse repository at this point
Copy the full SHA 5eb7fa9View commit details -
add advance bidder support for openx amp ad (ampproject#7221)
* add advance bidder support for openx amp ad * update ads.extern.js for openx amp ad * add data.dfpSlot to ads.extern.js
Configuration menu - View commit details
-
Copy full SHA for f0b87e6 - Browse repository at this point
Copy the full SHA f0b87e6View commit details
Commits on Jan 31, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 780e896 - Browse repository at this point
Copy the full SHA 780e896View commit details -
Configuration menu - View commit details
-
Copy full SHA for bba72a8 - Browse repository at this point
Copy the full SHA bba72a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5b2be2 - Browse repository at this point
Copy the full SHA c5b2be2View commit details -
Ad type adverticum 3p script https/http support. (ampproject#7176)
* Ad type adverticum 3p script https/http support. * example change
Configuration menu - View commit details
-
Copy full SHA for 25413ae - Browse repository at this point
Copy the full SHA 25413aeView commit details -
Exposing play, pause, mute, unmute actions and making integration tes…
…ts run on iOS 10 (ampproject#7171)
Configuration menu - View commit details
-
Copy full SHA for cd884cf - Browse repository at this point
Copy the full SHA cd884cfView commit details -
Page-level visibility time for embed performance reporting (ampprojec…
…t#7241) * Page-level visibility time for embed performance reporting * ping URL parameters and layout ping
Dima Voytenko authoredJan 31, 2017 Configuration menu - View commit details
-
Copy full SHA for 8120601 - Browse repository at this point
Copy the full SHA 8120601View commit details -
Validator rollup (ampproject#7271)
* Move nonce test case to a more appropriate test file. * Remove no longer needed dispatch key generation from validator.js. * De-dupe all messages (subtrees of the rules object) and instantiate the parsed attr specs lazily. * Revision bump for validator-amp-analytics.protoascii * Update construction of blacklisted cdata regexp to no longer have a trailing `|` character. * Add a Closure define for disabling CSS parsing / validating.
Configuration menu - View commit details
-
Copy full SHA for ae9813a - Browse repository at this point
Copy the full SHA ae9813aView commit details -
Remove 'experimental' for custom validation as it's now launched (amp…
Barb Paduch authoredJan 31, 2017 Configuration menu - View commit details
-
Copy full SHA for 74cc272 - Browse repository at this point
Copy the full SHA 74cc272View commit details -
Fix bug when changing amp-carousel slides before layout (ampproject#7268
) * avoid calling showSlide_ when not laid out yet * fix lint and type errors * add unit test * comments for unit test
William Chou authoredJan 31, 2017 Configuration menu - View commit details
-
Copy full SHA for 81b8020 - Browse repository at this point
Copy the full SHA 81b8020View commit details -
Support <amp-social-share type="system"> (ampproject#6688)
* Add "native" share type * charset=utf8 -> charset=utf-8
Configuration menu - View commit details
-
Copy full SHA for 883053b - Browse repository at this point
Copy the full SHA 883053bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cc3c6a - Browse repository at this point
Copy the full SHA 3cc3c6aView commit details -
Implement mechanism for ensuring that all extensions share an AMP ver…
…sion with the main binary. (ampproject#7239) For each extension this checks the version, and if it is the wrong version, will ignore the JS file and initiate a load of the correct version. - experiment guarded. This is likely to break some stuff. - based on compiled-in version only. rtv is ignored, because we only care about code here, since config is only given in main binary. Implements locking part of ampproject#7238
Configuration menu - View commit details
-
Copy full SHA for a24dbda - Browse repository at this point
Copy the full SHA a24dbdaView commit details
Commits on Feb 1, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d3e96b8 - Browse repository at this point
Copy the full SHA d3e96b8View commit details -
Form Submit Accepts JSON Responses (ampproject#7139)
Part 2 to fixing ampproject#7119 ([Part 1](ampproject#7138)).
Configuration menu - View commit details
-
Copy full SHA for c897b7c - Browse repository at this point
Copy the full SHA c897b7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1767444 - Browse repository at this point
Copy the full SHA 1767444View commit details -
Configuration menu - View commit details
-
Copy full SHA for 079deaa - Browse repository at this point
Copy the full SHA 079deaaView commit details -
Created attributes.js (ampproject#7129)
* Created attributes.js * Whitelisted src/attributes for unconfirmed referrer url * Renamed attributes.js to iframe-attributes.js * Fixed name of file in presubmit-checks * Add sentinel name change exp / add func to generate sentinel and context * Refactored to use getContextMetadata * Removed blank line * Removed unneeded import * Moved function to fix check-types and fixed docstring * Made new test file / broke out tests * Changed test name * Revert "Changed test name" This reverts commit a509951. * Revert "Made new test file / broke out tests" This reverts commit 1961923. * Added todo
Configuration menu - View commit details
-
Copy full SHA for bbe8b35 - Browse repository at this point
Copy the full SHA bbe8b35View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2c1d39 - Browse repository at this point
Copy the full SHA d2c1d39View commit details -
Rambler SSP ad network (ampproject#7179)
* New ad network added * lint check done * Required changes was implemented * Implemented render API and requested changes * Pre-commit checker was added * Merge with master and remove pre-commit checker * Minor changes
Configuration menu - View commit details
-
Copy full SHA for 582d772 - Browse repository at this point
Copy the full SHA 582d772View commit details -
Make fetch "normal" (ampproject#7138)
* Revert "Use proper application/json response header instead of arraybuffer. (ampproject#7133)" This reverts commit 27d6886. * Make fetch "normal" Makes fetch a normal implementation. We implement `#arrayBuffer` by way of `utf8EncodeSync`, like it should have been. * Fix types * Test UTF8 in XHR's ArrayBuffer * Remove final uses of fetchJsonResponse
Configuration menu - View commit details
-
Copy full SHA for d9a1c7c - Browse repository at this point
Copy the full SHA d9a1c7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dca9e9a - Browse repository at this point
Copy the full SHA dca9e9aView commit details -
Update DEVELOPING.md (ampproject#7294)
We changed the label from 'Starter' to 'Great First Issues' Also, the link pointing here was not correct.
Configuration menu - View commit details
-
Copy full SHA for aa10e64 - Browse repository at this point
Copy the full SHA aa10e64View commit details -
Pass associated element directly to console (ampproject#7277)
William Chou authoredFeb 1, 2017 Configuration menu - View commit details
-
Copy full SHA for a7d39a7 - Browse repository at this point
Copy the full SHA a7d39a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a791b5 - Browse repository at this point
Copy the full SHA 2a791b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2edae9b - Browse repository at this point
Copy the full SHA 2edae9bView commit details
Commits on Feb 2, 2017
-
Fix computation of blacklisted_cdata_regex as well as code which was …
…hiding the error in our tests. (ampproject#7301)
Configuration menu - View commit details
-
Copy full SHA for 7845df7 - Browse repository at this point
Copy the full SHA 7845df7View commit details -
Add scopedQuerySelector helper (ampproject#7260)
* Eliminate uses of childElement and childElements * Forbid uses of buggy querySelector Anytime you select a descendant of a descendant (`div div`, or, really, `* *`), your matching against the entire document then filtering to elements inside the scope. This is **not** what you'd expect. Fixes a selector bug in `<amp-analytics>`. * Add tests * Use `Date.now` to avoid `.` class selector conflict * Merge latest master * Linting * Fix types * Fix merge conflict * Return NodeList * Fix tests
Configuration menu - View commit details
-
Copy full SHA for 57810d9 - Browse repository at this point
Copy the full SHA 57810d9View commit details -
Introduce an experiment to measure page jank via vsync. (ampproject#7293
Configuration menu - View commit details
-
Copy full SHA for 5b10381 - Browse repository at this point
Copy the full SHA 5b10381View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9de3239 - Browse repository at this point
Copy the full SHA 9de3239View commit details -
Render-start analytics event for documents and embeds (ampproject#7220)
* Render-start analytics event * resolve cyclical dependency * restrict render-start * tests and docs * working on docs * DOMReady * redo via signals * tests * Revert * Changes to the docs * tests * lints
Dima Voytenko authoredFeb 2, 2017 Configuration menu - View commit details
-
Copy full SHA for 12c9c61 - Browse repository at this point
Copy the full SHA 12c9c61View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8c2c6a - Browse repository at this point
Copy the full SHA d8c2c6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9b4f0d - Browse repository at this point
Copy the full SHA a9b4f0dView commit details -
Pass context down for a4a ad rendering to allow window.context to fun…
…ction (ampproject#7132) * Created attributes.js * Added context to direct frame rendering * Added context to rendering via nameframe * Removed unneeded files * Fixed lint and naming * Don't need to uriencode * Modified tests * Created generateSentinelAndContext and moved setStyle * Fixed test breakages, handled sentinel name change experiment * Addressed comments; ampContext now checks for window var; added/modified tests * Added docstring * Addressed comments * Added test * Attach data-amp-3p-sentinel attribute to frame * Fix a4a frames not having messages processed correctly * Added examples for manual testing * Addressed comments' * Revert "Addressed comments'" This reverts commit a61ddf8. * Changed name of function to hasSafeframeSentinel: * Added todo * Updated docstring and added todo * Fixed getListenForEvents * Collapse if block cases * Undid change to getListenForEvents * Fixed nameframe to keep context data on name * Broke out isAmpMessage function to use for parsing * Handle different ways of setting up AmpContext * Make test page take up multiple viewports * Fixed lint mistakes * Inlined ampcontext-creative.js into html * Addressed comments * Addressed comments * Add comments to explain setting of name on nameframe * removed comment
Configuration menu - View commit details
-
Copy full SHA for af90bed - Browse repository at this point
Copy the full SHA af90bedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f6930c - Browse repository at this point
Copy the full SHA 1f6930cView commit details -
TreeWalker in Bind & better variable names (ampproject#7288)
* rename 'bindings' to 'bound properties' * rename 'evaluatee' to 'binding' * use treewalker * minor tweak * justin's comments * simplify scan helper func
William Chou authoredFeb 2, 2017 Configuration menu - View commit details
-
Copy full SHA for df097a9 - Browse repository at this point
Copy the full SHA df097a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e5173b - Browse repository at this point
Copy the full SHA 5e5173bView commit details -
add fine logging to bind (ampproject#7314)
William Chou authoredFeb 2, 2017 Configuration menu - View commit details
-
Copy full SHA for 9b79e64 - Browse repository at this point
Copy the full SHA 9b79e64View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8e8685 - Browse repository at this point
Copy the full SHA b8e8685View commit details -
Add additional details for how community members can participate, inc…
…luding design reviews (ampproject#7281)
Configuration menu - View commit details
-
Copy full SHA for 42c0d28 - Browse repository at this point
Copy the full SHA 42c0d28View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7cb59f - Browse repository at this point
Copy the full SHA c7cb59fView commit details -
Factor out jank meter code into separate file (ampproject#7309)
* Factor out jank meter code into separate file * Rename jank-rate.js to jank-meter.js * Makes this.win_ private * address comment
Configuration menu - View commit details
-
Copy full SHA for 2ba97de - Browse repository at this point
Copy the full SHA 2ba97deView commit details
Commits on Feb 3, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 133cf10 - Browse repository at this point
Copy the full SHA 133cf10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41302da - Browse repository at this point
Copy the full SHA 41302daView commit details -
Configuration menu - View commit details
-
Copy full SHA for c65e52c - Browse repository at this point
Copy the full SHA c65e52cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f537db - Browse repository at this point
Copy the full SHA 1f537dbView commit details -
Update amp-analytics.js (ampproject#7318)
* Update amp-analytics.js * review feedback. * Update amp-analytics.js
Configuration menu - View commit details
-
Copy full SHA for 89a7cd0 - Browse repository at this point
Copy the full SHA 89a7cd0View commit details -
Improve reporting of amp-bind user errors (ampproject#7335)
* render affected elements in bind runtime errors * report evaluation and invalid [class] result errors * replace expr->element lookup with map object, add invalid css example * comments * fix unit tests * tweak example
William Chou authoredFeb 3, 2017 Configuration menu - View commit details
-
Copy full SHA for 0a02a99 - Browse repository at this point
Copy the full SHA 0a02a99View commit details
Commits on Feb 4, 2017
-
Configuration menu - View commit details
-
Copy full SHA for b96e7da - Browse repository at this point
Copy the full SHA b96e7daView commit details -
Limit URL replacement to secure origins. (ampproject#7347)
This is as designed and follows with web policy that powerful features are only available on HTTPS.
Configuration menu - View commit details
-
Copy full SHA for 52fddf4 - Browse repository at this point
Copy the full SHA 52fddf4View commit details
Commits on Feb 5, 2017
-
Classify new domain scheme traffic as coming from CDN. (ampproject#7348)
Adds support for the new domain scheme: https://domain-com.cdn.ampproject.org Fixes ampproject#7019
Configuration menu - View commit details
-
Copy full SHA for 434b503 - Browse repository at this point
Copy the full SHA 434b503View commit details
Commits on Feb 6, 2017
-
Rename brainy (ampproject#7224)
* Rename brainy * fix alphabetic order * Fix indent
Configuration menu - View commit details
-
Copy full SHA for 3a797d7 - Browse repository at this point
Copy the full SHA 3a797d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b22d50 - Browse repository at this point
Copy the full SHA 8b22d50View commit details -
Throttle "Script error." reports. (ampproject#7371)
These contain zero information and so we only care about the count, but not about getting every single one. See ampproject#7353 for context.
Configuration menu - View commit details
-
Copy full SHA for 9605919 - Browse repository at this point
Copy the full SHA 9605919View commit details -
Configuration menu - View commit details
-
Copy full SHA for e63b410 - Browse repository at this point
Copy the full SHA e63b410View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0f6e75 - Browse repository at this point
Copy the full SHA c0f6e75View commit details -
Directly report logged errors instead of relying on rethrowing (amppr…
…oject#7358) …and then catching the `error` event. Part of ampproject#7353
Configuration menu - View commit details
-
Copy full SHA for 7e15764 - Browse repository at this point
Copy the full SHA 7e15764View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb74df7 - Browse repository at this point
Copy the full SHA cb74df7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9a0974 - Browse repository at this point
Copy the full SHA b9a0974View commit details
Commits on Feb 7, 2017
-
rename goToSlide event to slideChange (ampproject#7387)
William Chou authoredFeb 7, 2017 Configuration menu - View commit details
-
Copy full SHA for ad9d07a - Browse repository at this point
Copy the full SHA ad9d07aView commit details -
Fix race condition within A4A verify (ampproject#6837)
* Address issue 6780 * Move crypto into its own service; add test coverage * fix merge conflicts * PR review * Move amp analytics into crypto service * PR review * PR reviews * test/presubmit fixes * fix linter error
Configuration menu - View commit details
-
Copy full SHA for 211119b - Browse repository at this point
Copy the full SHA 211119bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d8f17b - Browse repository at this point
Copy the full SHA 4d8f17bView commit details -
Update CONTRIBUTING Weekly Status & Design Review sections with the l…
…atest details (ampproject#7385) * updating weekly status and design doc sections * Update CONTRIBUTING.md
Configuration menu - View commit details
-
Copy full SHA for fbc0bc2 - Browse repository at this point
Copy the full SHA fbc0bc2View commit details -
Docs add links for analytics vendors (ampproject#7375)
* Remove GPU rasterizaton reasoning for viewport * Add links for remaining analytics vendors
Barb Paduch authoredFeb 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 26b636b - Browse repository at this point
Copy the full SHA 26b636bView commit details -
Fix Chunks in extensions (ampproject#7374)
* avoid referencing Chunks in extension * fix unit test * fix presubmit * malte's comment
William Chou authoredFeb 7, 2017 Configuration menu - View commit details
-
Copy full SHA for 483e227 - Browse repository at this point
Copy the full SHA 483e227View commit details -
Remove GPU rasterizaton reasoning for viewport (ampproject#7373)
Barb Paduch authoredFeb 7, 2017 Configuration menu - View commit details
-
Copy full SHA for a427135 - Browse repository at this point
Copy the full SHA a427135View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a97771 - Browse repository at this point
Copy the full SHA 6a97771View commit details -
Configuration menu - View commit details
-
Copy full SHA for eeebd93 - Browse repository at this point
Copy the full SHA eeebd93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76a39ec - Browse repository at this point
Copy the full SHA 76a39ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 184c0c9 - Browse repository at this point
Copy the full SHA 184c0c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa407ec - Browse repository at this point
Copy the full SHA fa407ecView commit details -
Visibility-v2: use IntersectionObserverPolyfill (ampproject#7383)
* Visibility-v2: use IntersectionObserverPolyfill * Address comments
Configuration menu - View commit details
-
Copy full SHA for f1e09f0 - Browse repository at this point
Copy the full SHA f1e09f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a06609 - Browse repository at this point
Copy the full SHA 8a06609View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cefbe6 - Browse repository at this point
Copy the full SHA 8cefbe6View commit details
Commits on Feb 8, 2017
-
Configuration menu - View commit details
-
Copy full SHA for deda591 - Browse repository at this point
Copy the full SHA deda591View commit details -
Document amp-selector's
select
event (ampproject#7411)William Chou authoredFeb 8, 2017 Configuration menu - View commit details
-
Copy full SHA for 47b8140 - Browse repository at this point
Copy the full SHA 47b8140View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9bf1f9 - Browse repository at this point
Copy the full SHA b9bf1f9View commit details -
Fix all errors that we throw during tests that throw no errors. (ampp…
…roject#7409) Makes it easier to identify problems in tests.
Configuration menu - View commit details
-
Copy full SHA for 7ed7a89 - Browse repository at this point
Copy the full SHA 7ed7a89View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc0812e - Browse repository at this point
Copy the full SHA bc0812eView commit details