Skip to content
This repository has been archived by the owner on Sep 10, 2022. It is now read-only.

Try to pull in changes from google:master #1

Open
wants to merge 1,723 commits into
base: php-validator-generated
Choose a base branch
from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jan 5, 2017

  1. Lazily allocate observables (ampproject#6839)

    * fix
    
    * fix
    
    * fix
    
    * size
    
    * fix
    chenshay authored Jan 5, 2017
    Configuration menu
    Copy the full SHA
    9fbd67f View commit details
    Browse the repository at this point in the history
  2. Fix an un-closed amp-ad tag in example. (ampproject#6889)

    * Fix an un-closed amp-ad tag in example. Fix some bad indentation.
    
    * style fixes
    
    * single quote to double quote
    lannka authored Jan 5, 2017
    Configuration menu
    Copy the full SHA
    185ca00 View commit details
    Browse the repository at this point in the history
  3. Validator Rollup (ampproject#6898)

    Validator Rollup
    honeybadgerdontcare authored Jan 5, 2017
    Configuration menu
    Copy the full SHA
    4e365e5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    527f16e View commit details
    Browse the repository at this point in the history
  5. Pass down experiment toggles to 3p iframes. (ampproject#6801)

    * Pass down experiment toggles to 3p iframes.
    
    * Fix type checks.
    
    * Fix tests.
    
    * update test
    lannka authored Jan 5, 2017
    Configuration menu
    Copy the full SHA
    100a029 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fdf2220 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    17cd61a View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2017

  1. Tweak regex to allow \n in variable values. (ampproject#6896)

    * Tweak regex to allow \n in variable values.
    
    Fixes ampproject#6885
    avimehta authored Jan 6, 2017
    Configuration menu
    Copy the full SHA
    0978711 View commit details
    Browse the repository at this point in the history
  2. amp-youtube: Remove the layout wait, issue seems to have been fixed b…

    …y YT (ampproject#6915)
    
    * Remove the layout wait, issue seems to have been fixed by YT
    
    * Lint
    aghassemi authored Jan 6, 2017
    Configuration menu
    Copy the full SHA
    c6a09a5 View commit details
    Browse the repository at this point in the history
  3. Allow amp-form to update amp-state (ampproject#6820)

    * initial commit for bind/form integration
    
    * fix type error
    
    * fix unit test
    
    * PR comments
    William Chou authored Jan 6, 2017
    Configuration menu
    Copy the full SHA
    d6eb7ff View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    514c255 View commit details
    Browse the repository at this point in the history
  5. add integration test to 3p ad (ampproject#6789)

    * wip
    
    * first version test
    
    * dispatch scroll event
    
    * wip
    
    * wip
    
    * push to heroku
    
    * make it work
    
    * enable io for fake3pad example
    
    * fix test
    
    * fix
    
    * add validateDate check to _ping_
    
    * use platform isChrome
    
    * nit
    zhouyx authored Jan 6, 2017
    Configuration menu
    Copy the full SHA
    e61445a View commit details
    Browse the repository at this point in the history
  6. Switched from vid to cid for adsense and doubleclick integrations (am…

    …pproject#6895)
    
    The backends expect vid to be of a particular format: NNNNNN.NNNNNN.
    Whereas cid can be of arbitrary format (as is the case for AMP).
    
    Fixes ampproject#6379
    avimehta authored Jan 6, 2017
    Configuration menu
    Copy the full SHA
    494f6fb View commit details
    Browse the repository at this point in the history
  7. Update doubleclick.md to properly reflect the state of the "useSameDo…

    …mainRenderingUntilDeprecated" feature. (ampproject#6924)
    mlb7687 authored and jridgewell committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    021c613 View commit details
    Browse the repository at this point in the history
  8. doc change on amp-accordion (ampproject#6448)

    * update doc
    
    * small fix
    
    * update
    
    * nit
    zhouyx authored Jan 6, 2017
    Configuration menu
    Copy the full SHA
    d07856b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2f6d82d View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2017

  1. Merges isDevChannel() and isDevChannelVersionDoNotUse_() to isCanary() (

    ampproject#6803)
    
    * Merges isDevChannel() and isDevChannelVersionDoNotUse_().
    
    * Update js doc
    
    * Remove unnecessary dep-checks.
    
    * fix
    lannka authored Jan 7, 2017
    Configuration menu
    Copy the full SHA
    c7631f9 View commit details
    Browse the repository at this point in the history
  2. Use intermediary AST for Bind expression evaluation (ampproject#6840)

    * initial commit for bind expression AST
    
    * fix lint and type errors
    
    * rename ASTType to ASTNodeType
    
    * move try/catch to evaluator
    
    * add some comments
    
    * move other try/catch to evaluator
    
    * PR comments
    
    * change enum to number, fix type errors
    
    * justin's comments
    William Chou authored Jan 7, 2017
    Configuration menu
    Copy the full SHA
    06836b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8033713 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2017

  1. Fixed Carousel Arrow SVGs - Added IE11 Compatible Charset for SVGs (a…

    …mpproject#6920)
    
    * Added IE11 Compatible Charset for SVGs
    As the title States, added IE11 compatible charset for CSS SVGs. Shorthands will break
    SVG support
    
    * Made All utf8 svg's IE11 compatible
    torch2424 authored and jridgewell committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    33739b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bcaa1ca View commit details
    Browse the repository at this point in the history
  3. Launch amp-playbuzz experiment (ampproject#6947)

    * Launch amp-playbuzz experiment
    
    * notes
    Dima Voytenko authored Jan 9, 2017
    Configuration menu
    Copy the full SHA
    adb6015 View commit details
    Browse the repository at this point in the history
  4. Fix structured return from key signing in a number of negative cases (a…

    …mpproject#6917)
    
    * Fix structured return from key signing in a number of negative cases.  Refactor for cleanliness.  Add tests.
    Terran Lane authored and muxin committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    5624059 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f11a5da View commit details
    Browse the repository at this point in the history
  6. Default requireAmpResponseSourceOrigin to true. (ampproject#6744)

    * Default requireAmpResponseSourceOrigin to true.
    
    * Fix type checks.
    lannka authored Jan 9, 2017
    Configuration menu
    Copy the full SHA
    98fdc2b View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2017

  1. Configuration menu
    Copy the full SHA
    5199aa0 View commit details
    Browse the repository at this point in the history
  2. amp-bind: Refactor attribute mutation flow (ampproject#6779)

    * Squash commits for bind mutation flow refactor
    
    * extend amp css regexp to include i-amphtml-
    
    * PR comments
    
    * PR comments
    
    * tweak mutate callback to pass non-string-cast result, also ignore unused old value
    
    * justin's comments
    
    * fix type error
    
    * fix rebase errors
    
    * justin's comment, fix callback triggering incorrectly for boolean attrs
    William Chou authored Jan 10, 2017
    Configuration menu
    Copy the full SHA
    379c8a3 View commit details
    Browse the repository at this point in the history
  3. write out css files to build and dist folders (ampproject#6946)

    * write out css files to build and dist folders
    
    * temp
    erwinmombay authored Jan 10, 2017
    Configuration menu
    Copy the full SHA
    a95aaf9 View commit details
    Browse the repository at this point in the history
  4. Import Gulp webserver as a middleware into Karma test server (ampproj…

    …ect#6937)
    
    * Reorganize karma config files.
    
    * Remove unused code.
    
    * Simplify logic.
    
    * Some more improvements.
    
    * Avoid using a karma config file. Put everything into a config object instead. This completely solves the hard-to-explain config overridden problem.
    
    * Document hardcoded log level constants.
    
    * Import gulp server into Karma server as a middleware
    lannka authored Jan 10, 2017
    Configuration menu
    Copy the full SHA
    f7f408e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f627a36 View commit details
    Browse the repository at this point in the history
  6. Scan used extension in HTML head, instead whole document. (ampprojec…

    …t#6954)
    
    *  Scan used extension in HTML head, instead whole document.
    
    * Fix test.
    lannka authored Jan 10, 2017
    Configuration menu
    Copy the full SHA
    2a123e6 View commit details
    Browse the repository at this point in the history
  7. Allow experiments being opted in at document level. (ampproject#6938)

    * Allow experiments being opted in at document level.
    
    * Update README.
    
    * Update readme.
    
    * Update README.
    lannka authored Jan 10, 2017
    Configuration menu
    Copy the full SHA
    1f620b6 View commit details
    Browse the repository at this point in the history
  8. Proxying the form to call the prototype methods/properties, incl Chro…

    …me 45 (ampproject#6944)
    
    * Proxying the form to call the prototype methods/properties, incl Chrome 45 support
    
    * Support legacy properties
    
    * review fixes
    
    * review fixes
    Dima Voytenko authored Jan 10, 2017
    Configuration menu
    Copy the full SHA
    5443d59 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    69c6baf View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2017

  1. Bind validator (ampproject#6665)

    * squash bind-validation commits
    
    * fix inconsistencies after rebase
    
    * externalize createRules to avoid dupe work
    
    * lint and type errors
    
    * one more lint error
    William Chou authored Jan 11, 2017
    Configuration menu
    Copy the full SHA
    daf326a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1181681 View commit details
    Browse the repository at this point in the history
  3. Ad type adverticumv.2 (ampproject#6493)

    * adTypeAdverticum integration v2
    
    * Mistakes were made. Fixed them.
    
    * more type and code style fix
    
    * example fix
    
    * code style and typo fixes
    added validateData function
    
    * Missing ; ...
    
    * Removed IF by mistake
    
    * Codestyle fix
    
    * Update adverticum.js
    
    * Update adverticum.js
    Adverticum authored and zhouyx committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    2c6e6f7 View commit details
    Browse the repository at this point in the history
  4. Reverts ampproject#6952 but keep the removal of default-value (amppro…

    …ject#6983)
    
    * Revert ampproject#6952 but keep the removal of default-value
    honeybadgerdontcare authored Jan 11, 2017
    Configuration menu
    Copy the full SHA
    633d45b View commit details
    Browse the repository at this point in the history
  5. amp-viewer-integration handshake updates (ampproject#6845)

    * example
    
    * fix
    
    * fix
    
    * new message format
    
    * fix
    
    * tests
    
    * typedef
    
    * test fixes
    
    * fixes
    
    * tests
    
    * error logging
    
    * type fix
    
    * type fix
    
    * viewerorigin -> origin
    
    * fixes
    
    * amp-handshake-request -> channelOpen
    
    * more fixes
    
    * logging fixes
    
    * error messaging
    
    * more fixes
    
    * test fix
    chenshay authored Jan 11, 2017
    Configuration menu
    Copy the full SHA
    9ee7c1f View commit details
    Browse the repository at this point in the history
  6. Introduces logic for A4A Multisize implementation. (ampproject#6677)

    * Factored out multi-size logic into its own module.
    
    * Added some debugging infrastructure.
    
    * Debug code.
    
    * Added frontend logic.
    
    * Client now makes appropriate resize request of amp-ad element.
    
    * Modified sz url parameter to accomodate multi-size.
    
    * Code cleanup.
    
    * Reverted example page.
    
    * Added example page + logic for 3p case.
    
    * Unit tests.
    
    * Added some unit tests for a4a multisize.
    
    * Rebased and fixed merges.
    
    * Reintroduced a4a carveout for multisize until BOW release is unfrozen.
    
    * Corrected comments.
    
    * Fixed types which were broken when carve-out was carved out.
    
    * Removed dead code.
    
    * Addressing feedback.
    
    * Removing accidentally added files.
    
    * Changed how multiSizeValidation boolean is handled.
    
    * Factored out existence check for creativeParts.
    
    * Clarified doc string.
    
    * Updated doc string & minor changes.
    
    * Removed extraneous comment.
    
    * Removed unneeded Number cast.
    
    * Moved missing signature check upstream.
    
    * Reinstated missing signature check downstream.
    
    * Removed unnecessary call to handleResize.
    glevitzky authored and lannka committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    155e23b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    83d40e0 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2017

  1. Configuration menu
    Copy the full SHA
    fa63c19 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0027e1d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ab78ba8 View commit details
    Browse the repository at this point in the history
  4. Add support for Bind's linked carousels use case (ampproject#6797)

    * initial commit for linked carousels support
    
    * fix lint and type errors
    
    * PR comments
    
    * more PR comments
    
    * add unit tests
    
    * PR comments and API updates
    
    * add tag to warn()
    William Chou authored Jan 12, 2017
    Configuration menu
    Copy the full SHA
    eca0ca6 View commit details
    Browse the repository at this point in the history
  5. Add amp-bind support to amp-video (ampproject#6905)

    * initial commit for bind support in amp-video
    
    * type cast to mollify closure
    
    * fix presubmit error, api updates
    
    * fix unit test
    William Chou authored Jan 12, 2017
    Configuration menu
    Copy the full SHA
    73d66af View commit details
    Browse the repository at this point in the history
  6. Assorted Bind validator fixes (ampproject#7005)

    * validator follow-up from ali's comments
    
    * ali's comment
    William Chou authored Jan 12, 2017
    Configuration menu
    Copy the full SHA
    ff76164 View commit details
    Browse the repository at this point in the history
  7. Let all async gulp tasks return Promise. (ampproject#6844)

    * Let all async gulp tasks return Promise.
    
    * Fix buildSw.
    
    * fix bad merge
    
    * fix merge
    lannka authored Jan 12, 2017
    Configuration menu
    Copy the full SHA
    fa5c6cc View commit details
    Browse the repository at this point in the history
  8. Expose move to slide method on slidescroll to enable flim-strip exper…

    …ience (ampproject#6914)
    
    * testing gallery with amp-selector
    
    * Plausible gallery experience
    
    * Review changes
    
    * Adding tests
    camelburrito authored Jan 12, 2017
    Configuration menu
    Copy the full SHA
    9e555b7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ad75d41 View commit details
    Browse the repository at this point in the history
  10. update doc (ampproject#7016)

    zhouyx authored Jan 12, 2017
    Configuration menu
    Copy the full SHA
    663f1f4 View commit details
    Browse the repository at this point in the history
  11. Pixel re-implemented to trigger immediately on visibility (ampproject…

    …#6988)
    
    * Pixel re-implemented to trigger immediately on visibility
    
    * review fixes
    
    * lints
    
    * test fixes
    
    * lints
    Dima Voytenko authored Jan 12, 2017
    Configuration menu
    Copy the full SHA
    04d1d8e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ed05a09 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    4adf4df View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    80ff445 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f069143 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    f2bac16 View commit details
    Browse the repository at this point in the history
  17. handle unload (ampproject#7001)

    * handle unload
    
    * fix+test
    chenshay authored Jan 12, 2017
    Configuration menu
    Copy the full SHA
    e56601a View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    c5d305c View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2017

  1. skeleton for amp-tabs (ampproject#7003)

    * skeleton for amp-tabs
    
    * lint fix
    
    * fix
    
    * added experiment
    chenshay authored Jan 13, 2017
    Configuration menu
    Copy the full SHA
    a72a54f View commit details
    Browse the repository at this point in the history
  2. Validator rollup (ampproject#7023)

    * Disallow id="AMP" for all elements.
    
    * More disallowed id and name attribute values.
    
    * Remove old code for generating manufactured body tag warnings.
    
    * Refactoring: Remove template_spec_url field from ParsedTagSpec; access validator rules via Context instance instead.
    
    * Make the unused extension warning more descriptive.
    
    * Revision bump for input change.
    
    * `<amp-analytics>` is required by `<amp-access>`. Fix this warning message.
    
    * Remove unused field.
    Gregable authored Jan 13, 2017
    Configuration menu
    Copy the full SHA
    9b66415 View commit details
    Browse the repository at this point in the history
  3. Laterpay validator config (ampproject#6974)

    * Laterpay validator config
    
    * test files
    
    * review fixes
    Dima Voytenko authored Jan 13, 2017
    Configuration menu
    Copy the full SHA
    f17c0f5 View commit details
    Browse the repository at this point in the history
  4. Avoid duplicating server-layout (ampproject#7021)

    * Avoid duplicating server-layout
    
    * fixe
    
    * pass the signal back to viewer
    
    * ensure that sizer can be read immediately or later
    
    * lints
    
    * test fixes
    Dima Voytenko authored Jan 13, 2017
    Configuration menu
    Copy the full SHA
    bb087e3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b0eaea8 View commit details
    Browse the repository at this point in the history
  6. Use URL replacer from embed for pixel (ampproject#7029)

    Dima Voytenko authored Jan 13, 2017
    Configuration menu
    Copy the full SHA
    fd2cfc7 View commit details
    Browse the repository at this point in the history
  7. resizing of margins (ampproject#6824)

    tlong2 authored and Dima Voytenko committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    93b67b0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c882ba1 View commit details
    Browse the repository at this point in the history
  9. Moves closure sha384 into a new extension amp-crypto-polyfill for laz…

    …y load (ampproject#7006)
    
    * Moves closure sha384 into a new extension amp-crypto-polyfill for lazy load.
    
    * fix
    
    * Update tests. Remove base64 polyfill from lib.
    
    * Fix presubmit
    
    * Address comments
    
    * Fix test.
    lannka authored Jan 13, 2017
    Configuration menu
    Copy the full SHA
    17136cf View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8b12f9e View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2017

  1. Configuration menu
    Copy the full SHA
    af21b1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3209535 View commit details
    Browse the repository at this point in the history
  3. Update csa.md to remove non-required parameters (ampproject#6902)

    * Update csa.md to remove non-required parameters 
    
    Removed non-required parameters (width, layout) from the amp-ad tag.
    
    * Updated csa.md to combine text in multiple lines
    mmcao authored and lannka committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    01bb681 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2017

  1. Configuration menu
    Copy the full SHA
    5fddb61 View commit details
    Browse the repository at this point in the history
  2. Early implementation of amp-access-laterpay (ampproject#5920)

    * Early implementation of amp-access-laterpay
    
    * Remove unused amp-access-laterpay config params
    
    * Code cleanup issues from PR
    
    * Expose response in error object for assertSuccess
    
    * Further work on amp-access-laterpay
    
    - Remove unnecessary pingback skeleton
    - Add jsdoc annotations for existing code
    - Laterpay config retrieval based on draft spec
    - Improve rendering of the purchase overlay
    - Price formatting and localization
    
    * Expose adapter config on AccessService
    
    * Fix pingback detection in amp-access-vendor
    
    * Allow amp-access login flow with url only
    
    Create new methods loginWithType_ (similar to old login method) and
    loginWithUrl as entry points to old login method (now private).
    
    * Fix exposure of amp access vendor config
    
    * Add "already purchased" link
    
    * Add CSS for amp-access-laterpay
    
    * PR feedback fixes:
    
    - add private tag
    - ensure assert comes first
    
    * Add event label to loginWithUrl calls
    
    * Also check if we're on localdev mode
    
    * Fix amp-access login tests
    
    * Fix amp-access-vendor tests
    
    * Use id instead of custom element for amp-access-laterpay
    
    * Override pingback in amp-access-laterpay
    
    * Expose buildUrl in amp-access
    
    * Add tests for amp-access-laterpay
    
    * Simplify example page
    
    * Apply labels properly based on purchase type
    
    Also rename i18n keys for clarity.
    
    * Add readme for amp-access-laterpay
    
    * Typos, cleanup, linting
    
    * Add option for scrolling to top after auth
    
    * Add header/footer to amp-access-laterpay
    
    * Fix some default styling issues
    
    * Address PR feedback and update LaterPay description
    
    * Address more PR feedback fixes
    
    * Add validator info to amp-access-laterpay readme
    
    * Add types for missing config options
    
    * Add sandbox flag to LaterPay config options
    
    * Fix some linting and rules issues
    
    - add license to css file
    - rename property to avoid scrollTop check
    trodrigues authored and Dima Voytenko committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    1972fac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b2d835 View commit details
    Browse the repository at this point in the history
  4. Temporary solution for most common form-proxy failures (ampproject#7065)

    * Temporary solution for most common form-proxy failures
    
    * tests fixed
    Dima Voytenko authored Jan 17, 2017
    Configuration menu
    Copy the full SHA
    ec96f9f View commit details
    Browse the repository at this point in the history
  5. Add Carousel and Selector to Bind validator (ampproject#7067)

    * fix missing bind validator support and other small fixes
    
    * update test-bind-validator.js
    
    * avoid early-out in amp-selector [selected] mutate when value == 0
    William Chou authored Jan 17, 2017
    Configuration menu
    Copy the full SHA
    f77fe08 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4c9cdcf View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2017

  1. Configuration menu
    Copy the full SHA
    766b89c View commit details
    Browse the repository at this point in the history
  2. add a way to override hostname (ampproject#6972)

    * add a way to override hostname
    
    * rollback 3p url change
    
    * org -> net
    erwinmombay authored Jan 18, 2017
    Configuration menu
    Copy the full SHA
    2a7cfaa View commit details
    Browse the repository at this point in the history
  3. Reuse resource when reparented for some extensions (ampproject#7035)

    * Reuse resource when reparented for some extensions
    
    * examples in docs
    Dima Voytenko authored Jan 18, 2017
    Configuration menu
    Copy the full SHA
    49f80f9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9bbc9fb View commit details
    Browse the repository at this point in the history
  5. Fix incorrect documentation for extended templates (ampproject#7068)

    Extended templates are loaded by including a `<script>` tag with a `custom-template` attribute rather than a `custom-element` attribute.
    tonyruscoe authored and Barb Paduch committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    eda679b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a456ff8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    51762e9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5475006 View commit details
    Browse the repository at this point in the history
  9. Make zid optional (ampproject#7071)

    * make zid optional
    
    * formatting
    jtsai783 authored and lannka committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    43c7963 View commit details
    Browse the repository at this point in the history
  10. Append CSA container to 'c' container (ampproject#7083)

    * Set container style to absolute
    
    * Append CSA container to 'c' element, not body
    
    * update unit tests to include c div
    megankj authored and lannka committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    bbe4f48 View commit details
    Browse the repository at this point in the history
  11. Fix broken shields (ampproject#7051)

    * Fix broken shields
    
    Seems like issuestats has died :(
    Just removed the broken images and changed them to be shield.io shields and link to their respective tabs on github.
    
    * Remove shields
    afischer authored and jridgewell committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    330fdb2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    bd9f04d View commit details
    Browse the repository at this point in the history
  13. Changed amp3pSentinel to sentinel with exp flag (ampproject#6922)

    * Changed amp3pSentinel to sentinel with exp flag
    
    * Fixed flagging all uses of amp3pSentinel to sentinel change
    
    * Fixed presubmit issues
    
    * Whitelisted dist.3p/current/integration.js for cookie related presubmit stuff
    
    * Fixed dependency issue
    
    * Properly test both cases of the experiment
    
    * Added cleanup issue
    
    * Fixed lint issue
    
    * Addressed comments to test both cases of experiment
    
    * Fixed toggling off exp and using correct win
    
    * Removed unneeded complexity
    
    * Reverted presubmit-checks
    bradfrizzell authored and lannka committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    fe7e0ae View commit details
    Browse the repository at this point in the history
  14. <amp-apester-media> out of experiment (ampproject#7055)

    * feat(apester-media): apester out of experiments
    
    This changes amp-apester-media status from experiments to stable, also include update to apester
    
    custom-loader (urgent fix)
    
    * refactor: remove whitespace
    
    * fix: removed unused line
    
    * fix: lint, change innerHTML to DOM api
    mrsufgi authored and Dima Voytenko committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    8a02253 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    904490d View commit details
    Browse the repository at this point in the history
  16. Update ads/README.md to mention the container div. (ampproject#7090)

    * Update ads/README.md to mention the container div.
    
    * improve wording
    lannka authored Jan 18, 2017
    Configuration menu
    Copy the full SHA
    390ee71 View commit details
    Browse the repository at this point in the history
  17. Use resource.layoutBox instead of change.boundingClientRect to calcu…

    …late elementX, elementY in amp-analytics visiblity tracking. (ampproject#7089)
    lannka authored Jan 18, 2017
    Configuration menu
    Copy the full SHA
    78de1c5 View commit details
    Browse the repository at this point in the history
  18. Removes multi-size carveout from Fast Fetch. (ampproject#7092)

    * Removed multi-size carveout from Fast Fetch.
    
    * Actually removed carveout this time.
    
    * Removed unused element parameter.
    glevitzky authored and lannka committed Jan 18, 2017
    Configuration menu
    Copy the full SHA
    c0a5834 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2017

  1. Configuration menu
    Copy the full SHA
    984dd5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    337bd04 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7b77dd9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8eb6f9a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3827c5f View commit details
    Browse the repository at this point in the history
  6. Add base implementation getHTML (ampproject#6818)

    * Add base implementation getHTML
    
    * Fix codestyle
    
    * CR fix
    
    * fix linting error
    
    * CR fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    
    * fix
    DiMurer authored and jridgewell committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    d5ebb22 View commit details
    Browse the repository at this point in the history
  7. Removed iframeContextInName flag for experiment (ampproject#7107)

    * Removed flag for context in name experiment
    
    * Removed flag from prod and canary config
    bradfrizzell authored and lannka committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    d2029fd View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bb2768b View commit details
    Browse the repository at this point in the history
  9. Introduce field "runtime=inabox" in error reporting to differentiate …

    …errors generated from inabox JS. (ampproject#7099)
    lannka authored Jan 19, 2017
    Configuration menu
    Copy the full SHA
    68e0349 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2017

  1. Configuration menu
    Copy the full SHA
    aa7ebcb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e88a6e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1b2453c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3bdb2f7 View commit details
    Browse the repository at this point in the history
  5. Validator rollup (ampproject#7137)

    * Make tagSpecById array; add comment about ids. Remove unused type decl.
    
    * Allow SRI attributes for stylesheets.
    
    * Object<number, x> -> Array<x> and remove extensionUnusedUnless...
    
    * Construct ParsedAttrSpec objects lazily.
    
    * Generate a synthetic field ValidatorRules.dispatchKeyByTagSpecId and populate it.
    
    * Make the ParsedTagSpec instantiation lazy.
    
    * Reduce greediness of i-amphtml- blacklist regex.
    
    * More disallowed id and name attribute values.
    
    * Allow `nonce` attribute on <script> and <style> tags.
    
    * Make validator protoascii usage more consistent.
    
    * Allow async attr on font link tag.
    
    * Allow <meta http-equiv=origin-trial ...>
    honeybadgerdontcare authored Jan 20, 2017
    Configuration menu
    Copy the full SHA
    d17e7e2 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2017

  1. Configuration menu
    Copy the full SHA
    e88bd6d View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2017

  1. ampproject#7045 | Adding Acquia as vendor (ampproject#7103)

    * Adding Acquia as vendor
    
    * Remove wrong comment
    
    * Fix comma-typo
    
    * Fix comma-typo
    
    * Adding tests to vendor-requests.json
    
    * Typo in default causing test failures in the vendor test
    
    * Removing unnecessary comment and plus-character
    
    * change identity source to tracking and correct the default url
    
    * update fixtures
    
    * Revert to amp for identity source
    
    * remove acquia specific example
    
    * Removing json comments
    nickveenhof authored and avimehta committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    52c5f71 View commit details
    Browse the repository at this point in the history
  2. Better English, more consistent style (ampproject#7155)

    dandv authored and Barb Paduch committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    c195bdd View commit details
    Browse the repository at this point in the history
  3. Add amp-bind experiment (ampproject#7157)

    * add amp-bind experiment
    
    * add experiment check to amp-state
    
    * fix unit test
    William Chou authored Jan 23, 2017
    Configuration menu
    Copy the full SHA
    9a464b2 View commit details
    Browse the repository at this point in the history
  4. Use proper application/json response header instead of arraybuffer. (a…

    …mpproject#7133)
    
    * Use proper application/json response header instead of arraybuffer.
    
    * fix lints
    mkhatib authored and William Chou committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    27d6886 View commit details
    Browse the repository at this point in the history
  5. Fix incorrect nesting of doublequote and square bracket that was brea…

    …king some tests on Safari (ampproject#7146)
    
    * Add oid param to A4A-generated ad requests to enable ActiveView
    
    * Fix incorrect nesting of doublequote and square bracket that was breaking some tests on Safari
    
    * Undo adding blank line
    jonkeller authored and jridgewell committed Jan 23, 2017
    Configuration menu
    Copy the full SHA
    cbf5313 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e967073 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a77c434 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2017

  1. Configuration menu
    Copy the full SHA
    e9349d5 View commit details
    Browse the repository at this point in the history
  2. Limit form variable substitutions to canonical-origin actions (amppro…

    …ject#7169)
    
    * Limit form variable substitutions to canonical-origin actions
    
    * refactor
    mkhatib authored Jan 24, 2017
    Configuration menu
    Copy the full SHA
    74d85d6 View commit details
    Browse the repository at this point in the history
  3. Fix mention of "third party components" section (ampproject#7164)

    dandv authored and Barb Paduch committed Jan 24, 2017
    Configuration menu
    Copy the full SHA
    9ef0084 View commit details
    Browse the repository at this point in the history
  4. Enable "chunked-amp" in canary (ampproject#7182)

    William Chou authored Jan 24, 2017
    Configuration menu
    Copy the full SHA
    97e17d6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1558a7f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e29c339 View commit details
    Browse the repository at this point in the history
  7. Update ad loading UX. (ampproject#7167)

    * Update ad loading UX.
    
    * Address comment.
    lannka authored Jan 24, 2017
    Configuration menu
    Copy the full SHA
    324d352 View commit details
    Browse the repository at this point in the history
  8. Shadow DOM v1 (ampproject#7059)

    * Shadow DOM v1 API support
    
    * Removed unintended code comment
    
    * PR fixes
    Gives preference to Shadow DOM v1 over v0
    
    * Fixed lint errors
    
    * Fixes to closure-compiler errors
    Checks again for CE v0 so we don't disable native Shadow DOM in browsers that don't support CE v1
    
    * Fix closure compiler error
    
    * Added Shadow DOM v1 spec to Closure Compiler
    Oliver Fernandez authored and Dima Voytenko committed Jan 24, 2017
    Configuration menu
    Copy the full SHA
    e0c9c88 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2017

  1. Configuration menu
    Copy the full SHA
    fa1bc77 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b3719cd View commit details
    Browse the repository at this point in the history
  3. Apply opacity to the loading line. (ampproject#7189)

    * Apply opacity to the loading line.
    
    * Tweak color.
    lannka authored Jan 25, 2017
    Configuration menu
    Copy the full SHA
    b831a02 View commit details
    Browse the repository at this point in the history
  4. Turn on amp-ad-loading-ux on canary. (ampproject#7187)

    * Turn on amp-ad-loading-ux.
    
    * Turn off on prod.
    lannka authored Jan 25, 2017
    Configuration menu
    Copy the full SHA
    c2b175e View commit details
    Browse the repository at this point in the history
  5. Documentation about optout control (ampproject#7188)

    * Documentation about optout control
    
    * fixes
    Dima Voytenko authored Jan 25, 2017
    Configuration menu
    Copy the full SHA
    c74c423 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0004fb7 View commit details
    Browse the repository at this point in the history
  7. Adds way for Fast Fetch to collapse ads with 204 response code. (ampp…

    …roject#7131)
    
    * Added way for Fast Fetch to collapse ads with 204 response code.
    
    * Addressing PR feedback.
    
    * Update test-amp-a4a.js
    
    * Added integration test for collapse behavior.
    
    * Added additional tests for response and response.arrayBuffer being null.
    
    * PR feedback.
    
    * PR feedback.
    
    * Removing test file.
    
    * Bumping to retrigger travis.
    
    * Travis.
    glevitzky authored and lannka committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    add2c44 View commit details
    Browse the repository at this point in the history
  8. Clarify that assertString/Number allow empty string and zero (ampproj…

    …ect#7202)
    
    * Clarify that assertString/Number allow empty string and zero
    
    * tests
    
    * include NaN in doca
    Dima Voytenko authored Jan 25, 2017
    Configuration menu
    Copy the full SHA
    ce82f49 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    60a0a68 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6a547b9 View commit details
    Browse the repository at this point in the history
  11. Analytics root to separate top-level vs embed analytics for FIE (ampp…

    …roject#7172)
    
    * Analytics root to separate top-level vs embed analytics for FIE
    
    * test fixes
    
    * more docs
    Dima Voytenko authored Jan 25, 2017
    Configuration menu
    Copy the full SHA
    1736865 View commit details
    Browse the repository at this point in the history
  12. Create a pull request template for the project. (ampproject#7193)

    The template should help make pull requests easier to read and overall more uniform.
    
    - Does not propose complicated syntax for titles (or rather forbids it).
    - Encourages referencing issues.
    
    This is a bit of an RFC. Feedback is welcome. One thing I don't actually know (and the GH docs don't say), is how this template influences auto-generated PR text. It would be really annoying if that no longer happened.
    cramforce authored Jan 25, 2017
    Configuration menu
    Copy the full SHA
    96ad4af View commit details
    Browse the repository at this point in the history
  13. add yarn.lock file for deterministic builds (ampproject#7041)

    * add yarn.lock file for deterministic builds
    
    * switch travis to use yarn
    
    * fix logic for package.json an yarn.lock check
    
    * make sure that it also errors if only yarn.lock exists
    
    * add back yarn.lock file
    
    * update serving/building docs
    erwinmombay authored Jan 25, 2017
    Configuration menu
    Copy the full SHA
    e9fd8e2 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    02923dc View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2017

  1. Cloudflare ad network example (ampproject#6882)

    * Local debug server changes to fake Cloudflare signing.
    
    * Changes to support a new A4A ad network with Cloudflare Signing
    oliy authored and lannka committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    298920c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3ca900 View commit details
    Browse the repository at this point in the history
  3. Fix broken shadow embed test (ampproject#7213)

    * Fix broken shadow embed test
    
    * fix lint
    mkhatib authored and camelburrito committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    eb1acc8 View commit details
    Browse the repository at this point in the history
  4. Element-level signals for lifecycle events (ampproject#7205)

    * Element-level signals for lifecycle events
    
    * fixing tests
    Dima Voytenko authored Jan 26, 2017
    Configuration menu
    Copy the full SHA
    8be35f4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0cb150d View commit details
    Browse the repository at this point in the history
  6. margins on placements (ampproject#7153)

    tlong2 authored and lannka committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    1c6cbe1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4368b1e View commit details
    Browse the repository at this point in the history
  8. Revert "Fix build breakage" (ampproject#6568)

    William Chou authored Jan 26, 2017
    Configuration menu
    Copy the full SHA
    81f7af3 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2017

  1. Add ValueCommerce support for amp-ad (ampproject#6962)

    * 1st commit
    
    * add preconnect ValueCommerce
    
    add preconnect ValueCommerce
    
    * remove extra space
    
    remove extra space
    MichinaoShimizu authored and lannka committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    c6dfcf4 View commit details
    Browse the repository at this point in the history
  2. Update docs for goToSlide (ampproject#7223)

    * Update docs for goToSlide
    
    * Update actions doc for goToSlide
    
    * Update carouse.md with type="slides" note
    
    * Update actions doc with type=slides
    ericlindley-g authored and camelburrito committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    e78d99d View commit details
    Browse the repository at this point in the history
  3. Update csa.md (ampproject#7148)

    * Update csa.md
    
    Add note to indicate that only multiple-format AFSh ads are supported.
    
    * Update csa.md
    mmcao authored and lannka committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    9acc6ad View commit details
    Browse the repository at this point in the history
  4. fix [slide]=0 bug (ampproject#7229)

    William Chou authored Jan 27, 2017
    Configuration menu
    Copy the full SHA
    63bc93a View commit details
    Browse the repository at this point in the history
  5. Support generic chunking and chunk Bind's DOM scan (ampproject#6967)

    * Squash chunk-scan commits
    
    * fix lint error
    
    * rename chunk to startupChunk, pass viewer from Chunks to StartupTask
    
    * fix lint and type errors
    
    * support timeRemaining in chunk tasks & misc clean up
    
    * justin's comments
    
    * dima's comments
    
    * malte's comments
    
    * style and lint fix
    
    * fix unit tests
    
    * missed a couple @Private declarations
    
    * fix scan iteration
    
    * remove for..of
    
    * more iteration on iteration
    
    * move element scan to helper method
    William Chou authored Jan 27, 2017
    Configuration menu
    Copy the full SHA
    38afb0d View commit details
    Browse the repository at this point in the history
  6. Update amp-bind docs (ampproject#7216)

    * update bind docs
    
    * barb's comments
    William Chou authored Jan 27, 2017
    Configuration menu
    Copy the full SHA
    f33b581 View commit details
    Browse the repository at this point in the history
  7. Add URL rewriting and srcset support to amp-bind (ampproject#7206)

    * add srcset support
    
    * fix types
    
    * rewrite urls for cache
    
    * ignore compiler warnings in third_party/caja
    
    * whitelist amp-bind to depend on sanitizer.js
    
    * ali's comments
    William Chou authored Jan 27, 2017
    Configuration menu
    Copy the full SHA
    4ecfb21 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    78dd260 View commit details
    Browse the repository at this point in the history
  9. More amp-bind examples in separate folder (ampproject#7127)

    * move bind examples to bind/ folder
    
    * add sandbox example
    
    * add ecommerce example
    
    * update titles
    
    * replace shirt images
    
    * move amp-state to <body>
    
    * move <amp-state> to bottom of body
    
    * fix amp-bind validator html and output
    William Chou authored Jan 27, 2017
    Configuration menu
    Copy the full SHA
    4224565 View commit details
    Browse the repository at this point in the history
  10. Reduce URL entropy for preconnect polyfill. (ampproject#7227)

    A single AMP page would already only connect to a given origin once ever 180 seconds. With this change the URL for doing this will not change within that time interval. That means that all AMP pages that run on computers with roughly correct clocks will request the same URL within a 180 seconds interval, which should make it easier for CDNs to respond efficiently.
    cramforce authored Jan 27, 2017
    Configuration menu
    Copy the full SHA
    e81104a View commit details
    Browse the repository at this point in the history
  11. Add link for analytics vendor - Yandex (ampproject#7232)

    Barb Paduch authored and camelburrito committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    3b35ad5 View commit details
    Browse the repository at this point in the history
  12. Fix typo (ampproject#7207)

    dandv authored and camelburrito committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    eda00e9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1fed17f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    ecb6afd View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7eda4a8 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    d6de676 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    f6c0ed4 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    daf29d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2017

  1. Extract signals into its own class (ampproject#7240)

    Dima Voytenko authored Jan 30, 2017
    Configuration menu
    Copy the full SHA
    87b2dc4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    487c9a8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    454bf58 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ca45634 View commit details
    Browse the repository at this point in the history
  5. Relap support for amp-ads (ampproject#7011)

    * Add ads/relap
    
    Partial commit
    
    Update Relap
    
    * Fix to pass CI build
    
    * Add renderStart support
    
    * Change attributes order
    
    * Add double quotes around attribute values
    advzr authored and lannka committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    5eb7fa9 View commit details
    Browse the repository at this point in the history
  6. add advance bidder support for openx amp ad (ampproject#7221)

    * add advance bidder support for openx amp ad
    
    * update ads.extern.js for openx amp ad
    
    * add data.dfpSlot to ads.extern.js
    rjvelicaria authored and erwinmombay committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    f0b87e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2017

  1. Configuration menu
    Copy the full SHA
    780e896 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bba72a8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c5b2be2 View commit details
    Browse the repository at this point in the history
  4. Ad type adverticum 3p script https/http support. (ampproject#7176)

    * Ad type adverticum 3p script https/http support.
    
    * example change
    Adverticum authored and lannka committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    25413ae View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cd884cf View commit details
    Browse the repository at this point in the history
  6. Page-level visibility time for embed performance reporting (ampprojec…

    …t#7241)
    
    * Page-level visibility time for embed performance reporting
    
    * ping URL parameters and layout ping
    Dima Voytenko authored Jan 31, 2017
    Configuration menu
    Copy the full SHA
    8120601 View commit details
    Browse the repository at this point in the history
  7. Validator rollup (ampproject#7271)

    * Move nonce test case to a more appropriate test file.
    
    * Remove no longer needed dispatch key generation from validator.js.
    
    * De-dupe all messages (subtrees of the rules object) and instantiate the parsed attr specs lazily.
    
    * Revision bump for validator-amp-analytics.protoascii
    
    * Update construction of blacklisted cdata regexp to no longer have a trailing `|` character.
    
    * Add a Closure define for disabling CSS parsing / validating.
    Gregable authored Jan 31, 2017
    Configuration menu
    Copy the full SHA
    ae9813a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    74cc272 View commit details
    Browse the repository at this point in the history
  9. Fix bug when changing amp-carousel slides before layout (ampproject#7268

    )
    
    * avoid calling showSlide_ when not laid out yet
    
    * fix lint and type errors
    
    * add unit test
    
    * comments for unit test
    William Chou authored Jan 31, 2017
    Configuration menu
    Copy the full SHA
    81b8020 View commit details
    Browse the repository at this point in the history
  10. Support <amp-social-share type="system"> (ampproject#6688)

    * Add "native" share type
    
    * charset=utf8 -> charset=utf-8
    ithinkihaveacat authored and jridgewell committed Jan 31, 2017
    Configuration menu
    Copy the full SHA
    883053b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3cc3c6a View commit details
    Browse the repository at this point in the history
  12. Implement mechanism for ensuring that all extensions share an AMP ver…

    …sion with the main binary. (ampproject#7239)
    
    For each extension this checks the version, and if it is the wrong version, will ignore the JS file and initiate a load of the correct version.
    
    - experiment guarded. This is likely to break some stuff.
    - based on compiled-in version only. rtv is ignored, because we only care about code here, since config is only given in main binary.
    
    Implements locking part of ampproject#7238
    cramforce authored Jan 31, 2017
    Configuration menu
    Copy the full SHA
    a24dbda View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2017

  1. Configuration menu
    Copy the full SHA
    d3e96b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c897b7c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1767444 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    079deaa View commit details
    Browse the repository at this point in the history
  5. Created attributes.js (ampproject#7129)

    * Created attributes.js
    
    * Whitelisted src/attributes for unconfirmed referrer url
    
    * Renamed attributes.js to iframe-attributes.js
    
    * Fixed name of file in presubmit-checks
    
    * Add sentinel name change exp / add func to generate sentinel and context
    
    * Refactored to use getContextMetadata
    
    * Removed blank line
    
    * Removed unneeded import
    
    * Moved function to fix check-types and fixed docstring
    
    * Made new test file / broke out tests
    
    * Changed test name
    
    * Revert "Changed test name"
    
    This reverts commit a509951.
    
    * Revert "Made new test file / broke out tests"
    
    This reverts commit 1961923.
    
    * Added todo
    bradfrizzell authored and lannka committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    bbe8b35 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d2c1d39 View commit details
    Browse the repository at this point in the history
  7. Rambler SSP ad network (ampproject#7179)

    * New ad network added
    
    * lint check done
    
    * Required changes was implemented
    
    * Implemented render API and requested changes
    
    * Pre-commit checker was added
    
    * Merge with master and remove pre-commit checker
    
    * Minor changes
    CrazySquirrel authored and lannka committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    582d772 View commit details
    Browse the repository at this point in the history
  8. Make fetch "normal" (ampproject#7138)

    * Revert "Use proper application/json response header instead of arraybuffer. (ampproject#7133)"
    
    This reverts commit 27d6886.
    
    * Make fetch "normal"
    
    Makes fetch a normal implementation. We implement `#arrayBuffer` by way
    of `utf8EncodeSync`, like it should have been.
    
    * Fix types
    
    * Test UTF8 in XHR's ArrayBuffer
    
    * Remove final uses of fetchJsonResponse
    jridgewell authored Feb 1, 2017
    Configuration menu
    Copy the full SHA
    d9a1c7c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dca9e9a View commit details
    Browse the repository at this point in the history
  10. Update DEVELOPING.md (ampproject#7294)

    We changed the label from 'Starter' to 'Great First Issues' 
    Also, the link pointing here was not correct.
    adelinamart authored and cramforce committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    aa10e64 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a7d39a7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2a791b5 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2edae9b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2017

  1. Fix computation of blacklisted_cdata_regex as well as code which was …

    …hiding the error in our tests. (ampproject#7301)
    Gregable authored Feb 2, 2017
    Configuration menu
    Copy the full SHA
    7845df7 View commit details
    Browse the repository at this point in the history
  2. Add scopedQuerySelector helper (ampproject#7260)

    * Eliminate uses of childElement and childElements
    
    * Forbid uses of buggy querySelector
    
    Anytime you select a descendant of a descendant (`div div`, or, really,
    `* *`), your matching against the entire document then filtering to
    elements inside the scope. This is **not** what you'd expect.
    
    Fixes a selector bug in `<amp-analytics>`.
    
    * Add tests
    
    * Use `Date.now` to avoid `.` class selector conflict
    
    * Merge latest master
    
    * Linting
    
    * Fix types
    
    * Fix merge conflict
    
    * Return NodeList
    
    * Fix tests
    jridgewell authored Feb 2, 2017
    Configuration menu
    Copy the full SHA
    57810d9 View commit details
    Browse the repository at this point in the history
  3. Introduce an experiment to measure page jank via vsync. (ampproject#7293

    )
    
    * Introduce an experiment to measure page jank via vsync.
    
    * log info
    
    * log info
    
    * fix type checks
    
    * pass presubmit check
    
    * innerText -> textContent
    lannka authored Feb 2, 2017
    Configuration menu
    Copy the full SHA
    5b10381 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9de3239 View commit details
    Browse the repository at this point in the history
  5. Render-start analytics event for documents and embeds (ampproject#7220)

    * Render-start analytics event
    
    * resolve cyclical dependency
    
    * restrict render-start
    
    * tests and docs
    
    * working on docs
    
    * DOMReady
    
    * redo via signals
    
    * tests
    
    * Revert
    
    * Changes to the docs
    
    * tests
    
    * lints
    Dima Voytenko authored Feb 2, 2017
    Configuration menu
    Copy the full SHA
    12c9c61 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d8c2c6a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a9b4f0d View commit details
    Browse the repository at this point in the history
  8. Pass context down for a4a ad rendering to allow window.context to fun…

    …ction (ampproject#7132)
    
    * Created attributes.js
    
    * Added context to direct frame rendering
    
    * Added context to rendering via nameframe
    
    * Removed unneeded files
    
    * Fixed lint and naming
    
    * Don't need to uriencode
    
    * Modified tests
    
    * Created generateSentinelAndContext and moved setStyle
    
    * Fixed test breakages, handled sentinel name change experiment
    
    * Addressed comments; ampContext now checks for window var; added/modified tests
    
    * Added docstring
    
    * Addressed comments
    
    * Added test
    
    * Attach data-amp-3p-sentinel attribute to frame
    
    * Fix a4a frames not having messages processed correctly
    
    * Added examples for manual testing
    
    * Addressed comments'
    
    * Revert "Addressed comments'"
    
    This reverts commit a61ddf8.
    
    * Changed name of function to hasSafeframeSentinel:
    
    * Added todo
    
    * Updated docstring and added todo
    
    * Fixed getListenForEvents
    
    * Collapse if block cases
    
    * Undid change to getListenForEvents
    
    * Fixed nameframe to keep context data on name
    
    * Broke out isAmpMessage function to use for parsing
    
    * Handle different ways of setting up AmpContext
    
    * Make test page take up multiple viewports
    
    * Fixed lint mistakes
    
    * Inlined ampcontext-creative.js into html
    
    * Addressed comments
    
    * Addressed comments
    
    * Add comments to explain setting of name on nameframe
    
    * removed comment
    bradfrizzell authored and lannka committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    af90bed View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1f6930c View commit details
    Browse the repository at this point in the history
  10. TreeWalker in Bind & better variable names (ampproject#7288)

    * rename 'bindings' to 'bound properties'
    
    * rename 'evaluatee' to 'binding'
    
    * use treewalker
    
    * minor tweak
    
    * justin's comments
    
    * simplify scan helper func
    William Chou authored Feb 2, 2017
    Configuration menu
    Copy the full SHA
    df097a9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5e5173b View commit details
    Browse the repository at this point in the history
  12. add fine logging to bind (ampproject#7314)

    William Chou authored Feb 2, 2017
    Configuration menu
    Copy the full SHA
    9b79e64 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b8e8685 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    42c0d28 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c7cb59f View commit details
    Browse the repository at this point in the history
  16. Factor out jank meter code into separate file (ampproject#7309)

    * Factor out jank meter code into separate file
    
    * Rename jank-rate.js to jank-meter.js
    
    * Makes this.win_ private
    
    * address comment
    lannka authored Feb 2, 2017
    Configuration menu
    Copy the full SHA
    2ba97de View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2017

  1. Configuration menu
    Copy the full SHA
    133cf10 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41302da View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c65e52c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1f537db View commit details
    Browse the repository at this point in the history
  5. Update amp-analytics.js (ampproject#7318)

    * Update amp-analytics.js
    
    * review feedback.
    
    * Update amp-analytics.js
    avimehta authored Feb 3, 2017
    Configuration menu
    Copy the full SHA
    89a7cd0 View commit details
    Browse the repository at this point in the history
  6. Improve reporting of amp-bind user errors (ampproject#7335)

    * render affected elements in bind runtime errors
    
    * report evaluation and invalid [class] result errors
    
    * replace expr->element lookup with map object, add invalid css example
    
    * comments
    
    * fix unit tests
    
    * tweak example
    William Chou authored Feb 3, 2017
    Configuration menu
    Copy the full SHA
    0a02a99 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2017

  1. Configuration menu
    Copy the full SHA
    b96e7da View commit details
    Browse the repository at this point in the history
  2. Limit URL replacement to secure origins. (ampproject#7347)

    This is as designed and follows with web policy that powerful features are only available on HTTPS.
    cramforce authored Feb 4, 2017
    Configuration menu
    Copy the full SHA
    52fddf4 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2017

  1. Configuration menu
    Copy the full SHA
    434b503 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2017

  1. Rename brainy (ampproject#7224)

    * Rename brainy
    
    * fix alphabetic order
    
    * Fix indent
    brainy authored and erwinmombay committed Feb 6, 2017
    Configuration menu
    Copy the full SHA
    3a797d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8b22d50 View commit details
    Browse the repository at this point in the history
  3. Throttle "Script error." reports. (ampproject#7371)

    These contain zero information and so we only care about the count, but not about getting every single one.
    
    See ampproject#7353 for context.
    cramforce authored Feb 6, 2017
    Configuration menu
    Copy the full SHA
    9605919 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e63b410 View commit details
    Browse the repository at this point in the history
  5. Remove amp-video from list of built-ins (ampproject#7311)

    Barb Paduch authored and aghassemi committed Feb 6, 2017
    Configuration menu
    Copy the full SHA
    c0f6e75 View commit details
    Browse the repository at this point in the history
  6. Directly report logged errors instead of relying on rethrowing (amppr…

    …oject#7358)
    
    
    …and then catching the `error` event.
    
    Part of ampproject#7353
    cramforce authored Feb 6, 2017
    Configuration menu
    Copy the full SHA
    7e15764 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cb74df7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b9a0974 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2017

  1. Configuration menu
    Copy the full SHA
    ad9d07a View commit details
    Browse the repository at this point in the history
  2. Fix race condition within A4A verify (ampproject#6837)

    * Address issue 6780
    
    * Move crypto into its own service; add test coverage
    
    * fix merge conflicts
    
    * PR review
    
    * Move amp analytics into crypto service
    
    * PR review
    
    * PR reviews
    
    * test/presubmit fixes
    
    * fix linter error
    keithwrightbos authored and lannka committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    211119b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4d8f17b View commit details
    Browse the repository at this point in the history
  4. Update CONTRIBUTING Weekly Status & Design Review sections with the l…

    …atest details (ampproject#7385)
    
    * updating weekly status and design doc sections
    
    * Update CONTRIBUTING.md
    mrjoro authored and Barb Paduch committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    fbc0bc2 View commit details
    Browse the repository at this point in the history
  5. Docs add links for analytics vendors (ampproject#7375)

    * Remove GPU rasterizaton reasoning for viewport
    
    * Add links for remaining analytics vendors
    Barb Paduch authored Feb 7, 2017
    Configuration menu
    Copy the full SHA
    26b636b View commit details
    Browse the repository at this point in the history
  6. Fix Chunks in extensions (ampproject#7374)

    * avoid referencing Chunks in extension
    
    * fix unit test
    
    * fix presubmit
    
    * malte's comment
    William Chou authored Feb 7, 2017
    Configuration menu
    Copy the full SHA
    483e227 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a427135 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6a97771 View commit details
    Browse the repository at this point in the history
  9. Launch make-body-relative (ampproject#7403)

    Dima Voytenko authored and erwinmombay committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    eeebd93 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    76a39ec View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    184c0c9 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fa407ec View commit details
    Browse the repository at this point in the history
  13. Visibility-v2: use IntersectionObserverPolyfill (ampproject#7383)

    * Visibility-v2: use IntersectionObserverPolyfill
    
    * Address comments
    lannka authored Feb 7, 2017
    Configuration menu
    Copy the full SHA
    f1e09f0 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    8a06609 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    8cefbe6 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2017

  1. Configuration menu
    Copy the full SHA
    deda591 View commit details
    Browse the repository at this point in the history
  2. Document amp-selector's select event (ampproject#7411)

    William Chou authored Feb 8, 2017
    Configuration menu
    Copy the full SHA
    47b8140 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9bf1f9 View commit details
    Browse the repository at this point in the history
  4. Fix all errors that we throw during tests that throw no errors. (ampp…

    …roject#7409)
    
    Makes it easier to identify problems in tests.
    cramforce authored Feb 8, 2017
    Configuration menu
    Copy the full SHA
    7ed7a89 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bc0812e View commit details
    Browse the repository at this point in the history