Add production tarball pypi builds to cron & ensure use of correct compiler [Issue #4223] #4240
Conversation
IAlibay
changed the title
.github/workflows/gh-ci-cron.yaml
Outdated
| @@ -3,6 +3,9 @@ on: | |||
| schedule: | |||
| # 3 am Tuesdays and Fridays | |||
| - cron: "0 3 * * 2,5" | |||
| pull_request: | |||
| python-version: ["3.9", "3.10", "3.11"] | ||
| wheels: ['true', 'false'] |
There was a problem hiding this comment.
For review context - we want to try to see what happens if you build either from the tarball or wheels, hence the need for this matrix entry.
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: setup_os |
There was a problem hiding this comment.
This is a fancy action for just setting flags like CXX properly.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4240 +/- ##
===========================================
- Coverage 93.62% 93.41% -0.21%
===========================================
Files 179 183 +4
Lines 24199 23309 -890
Branches 4064 4064
===========================================
- Hits 22657 21775 -882
+ Misses 1026 1018 -8
Partials 516 516 ☔ View full report in Codecov by Sentry. |
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
|
@MDAnalysis/coredevs this one's been ignored from review for ~ 2 week. Can anyone review? |
|
Self merging so I can move on with things. |
Fixes #4223
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4240.org.readthedocs.build/en/4240/