Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add production tarball pypi builds to cron & ensure use of correct compiler [Issue #4223] #4240

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Add production tarball pypi builds to cron & ensure use of correct compiler [Issue #4223] #4240

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
70bae35
Add tarball install tests and make sure we use clang with macos
IAlibay Aug 15, 2023
539b8b4
increase verbosity
IAlibay Aug 15, 2023
f0efe47
change flag order, no binary has to be just before mdanalysis
IAlibay Aug 15, 2023
adef56b
some comments
IAlibay Aug 15, 2023
a8950c7
Update gh-ci-cron.yaml
IAlibay Aug 16, 2023
4254151
Update gh-ci-cron.yaml
IAlibay Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions .github/workflows/gh-ci-cron.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,16 +211,21 @@ jobs:
conda-latest-release:
# A set of runner to check that the latest conda release works as expected
if: "github.repository == 'MDAnalysis/mdanalysis'"
runs-on: ${{ matrix.os }}
runs-on: ${{ matrix.os }}-latest
timeout-minutes: 60
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
os: [ubuntu, macos]
python-version: ["3.9", "3.10", "3.11"]
steps:
- uses: actions/checkout@v3

- name: setup_os
uses: ./.github/actions/setup-os
with:
os-type: ${{ matrix.os }}

- name: setup_micromamba
uses: mamba-org/setup-micromamba@v1
with:
Expand Down Expand Up @@ -253,22 +258,37 @@ jobs:
pypi-latest-release:
# A set of runner to check that the latest conda release works as expected
if: "github.repository == 'MDAnalysis/mdanalysis'"
runs-on: ${{ matrix.os }}
runs-on: ${{ matrix.os }}-latest
timeout-minutes: 60
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu, macos, windows]
python-version: ["3.9", "3.10", "3.11"]
wheels: ['true', 'false']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For review context - we want to try to see what happens if you build either from the tarball or wheels, hence the need for this matrix entry.

steps:
# Checkout to have access to local actions (i.e. setup-os)
- uses: actions/checkout@v3

# We need this here in order to make sure we assign the correct compiler (i.e. clang for macos)
- name: setup_os
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fancy action for just setting flags like CXX properly.

uses: ./.github/actions/setup-os
with:
os-type: ${{ matrix.os }}

- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- name: install_mdanalysis
shell: bash
run: |
pip install mdanalysis mdanalysistests pytest-xdist pytest-timeout "gsd<3.0"
# If wheels is False we build directly from source so we use the --no-binary flag
# to avoid pulling down wheels for MDAnalysis (which are already precompiled)
if [ "${{ matrix.wheels }}" == "false" ]; then
INSTALL_FLAGS="-vvv --no-binary"
fi
pip install ${INSTALL_FLAGS} mdanalysis mdanalysistests pytest-xdist pytest-timeout

- name: run_tests
shell: bash
Expand Down
Loading