Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring the app into a library #9

Merged
merged 42 commits into from
Sep 21, 2023
Merged

Refactoring the app into a library #9

merged 42 commits into from
Sep 21, 2023

Conversation

ml-evs
Copy link
Collaborator

@ml-evs ml-evs commented Aug 23, 2023 •
edited
Loading

To-do:

  • refactor into several submodules
  • add docs for different modules
  • make plots and results usable from outside of app
  • tweak template layout s.t. plots and tables can still be screencapped
  • echem indicatrix
  • echem best chebyshev residual loop
  • compressibility plot bug
  • Add Jupyter notebook example

@ml-evs ml-evs force-pushed the ml-evs/app_refactor_pass_1 branch 5 times, most recently from dc73cc8 to 28ccf70 Compare August 30, 2023 10:01
@ml-evs ml-evs mentioned this pull request Aug 30, 2023
Merged
@ml-evs ml-evs marked this pull request as ready for review September 18, 2023 17:46
ml-evs
ml-evs commented Sep 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ml-evs ml-evs changed the title Refactoring the app Refactoring the app into a library Sep 20, 2023
@ml-evs ml-evs force-pushed the ml-evs/app_refactor_pass_1 branch 3 times, most recently from cc6d9b6 to ec32ce5 Compare September 20, 2023 15:50
@ml-evs
Reintroduce loop over cheb-space and fix residual + indicatrix plots
140540c
@ml-evs
Update options test
4fcbb1c
@ml-evs
Fix spurious sign
7e61ad1
@ml-evs
Fix compressibility plots
409bef4
@ml-evs
Fix for use pc
a16d75a
@ml-evs
Add missing P table parameters
1130d06
@ml-evs
Allow string n/a through rounding function
93b3dd5
@ml-evs
Remove final legacy code
f9cccd6
@ml-evs
Add stub notebook example
4e84ee9
@ml-evs
Fix missing import
8441350
@ml-evs
Add latest links in README
58f5ffc
@ml-evs
Add version and style tweaks to templates
e763883
@ml-evs
Fix a couple of typos
850977a
@ml-evs
Pass plot size through indicatrix wrapper
0dc4bb6
@ml-evs
Add Jupyter fitting examples to docs
7d0d010
@ml-evs
README tweaks
03be350
@ml-evs
Fix visual bug in BM coeffs table
db6819e
@ml-evs
Update sample example test values
2bbc7f4
@ml-evs
Use poetry as a build system
907ecd8
@ml-evs
Make test slightly more fuzzy
3691c9c
@ml-evs
Add more informative warning and remove to-do
b76bc36
@ml-evs ml-evs merged commit cd7abaf into MJCliffe:Live Sep 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MJCliffe MJCliffe Awaiting requested review from MJCliffe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ml-evs