Skip to content
CodeQL

[lihui] #N/A refactor: fix code smell #396

Sign in to view logs

[lihui] #N/A refactor: fix code smell

[lihui] #N/A refactor: fix code smell #396

Triggered via push April 5, 2024 15:30
@lhuilhui
pushed 71d983d
master
Status Success
Total duration 2m 42s
Artifacts –

codeql-analysis.yml

on: push
Matrix: Analyze
Fit to window
Zoom out
Zoom in

Annotations

26 warnings
Analyze (java)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L134
Condition `ownerComboBox.getItem() instanceof OwnerDTO` is redundant and can be replaced with a null check
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L67
Method invocation `getTrelloBoardMembers` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L86
Method invocation `getTrelloBoardLabels` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/UserSelectedInfo.java#L57
Method invocation `getLine` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/controller/TwCodeReviewSettingsConfigurable.java#L89
Method invocation `getTrelloApiKey` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/UserSelectedInfo.java#L57
Argument `selectionStartPosition` might be null
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/UserSelectedInfo.java#L62
Argument `selectionEndPosition` might be null
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L130
Condition `labelComboBox.getItem() instanceof LabelDTO` is redundant and can be replaced with a null check
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/UserSelectedInfo.java#L62
Method invocation `getLine` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L78
Method invocation `getTrelloBoardMembers` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L62
Method invocation `getTrelloBoardLabels` may produce `NullPointerException`
Lombok @Getter may be used: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/UserSelectedInfo.java#L26
Field 'project' may have Lombok @Getter
Suspicious variable/parameter name combination: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L49
'height' should probably not be passed as parameter 'width'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L79
Unchecked call to 'CollectionComboBoxModel(List)' as a member of raw type 'com.intellij.ui.CollectionComboBoxModel'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L88
Unchecked call to 'ComboBox(ComboBoxModel)' as a member of raw type 'com.intellij.openapi.ui.ComboBox'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L88
Unchecked assignment: 'com.intellij.openapi.ui.ComboBox' to 'com.intellij.openapi.ui.ComboBox'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L68
Unchecked call to 'CollectionComboBoxModel(List)' as a member of raw type 'com.intellij.ui.CollectionComboBoxModel'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L63
Unchecked assignment: 'com.intellij.ui.CollectionComboBoxModel' to 'javax.swing.ComboBoxModel'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L87
Unchecked call to 'CollectionComboBoxModel(List)' as a member of raw type 'com.intellij.ui.CollectionComboBoxModel'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L80
Unchecked call to 'ComboBox(ComboBoxModel)' as a member of raw type 'com.intellij.openapi.ui.ComboBox'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L68
Unchecked assignment: 'com.intellij.ui.CollectionComboBoxModel' to 'javax.swing.ComboBoxModel'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L80
Unchecked assignment: 'com.intellij.openapi.ui.ComboBox' to 'com.intellij.openapi.ui.ComboBox'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L94
Unchecked call to 'setRenderer(ListCellRenderer)' as a member of raw type 'com.intellij.openapi.ui.ComboBoxWithWidePopup'
Unchecked warning: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java#L63
Unchecked call to 'CollectionComboBoxModel(List)' as a member of raw type 'com.intellij.ui.CollectionComboBoxModel'
Unused import: src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/client/TrelloClient.java#L20
Unused import `import java.util.stream.Collectors;`