-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[berkeley] Use Proof_cache for Test_zkapp_update tests #14031
Conversation
!ci-build-me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it help to put the proof caches in separate files, so they don't clutter the tests?
Inlining the proofs into the test files makes them hard to work with. I would really like to see these proofs in separate files that we load inside of the tests. In fact, with the way git works, it would be best to have those files contain compact JSON rather than pretty printed JSON so that every change to those files doesn't incur storing a diff of 60k+ lines of code. We may even want to mark such proof files for storage in LFS, which we can do by giving these files a custom extension (like |
1 similar comment
Inlining the proofs into the test files makes them hard to work with. I would really like to see these proofs in separate files that we load inside of the tests. In fact, with the way git works, it would be best to have those files contain compact JSON rather than pretty printed JSON so that every change to those files doesn't incur storing a diff of 60k+ lines of code. We may even want to mark such proof files for storage in LFS, which we can do by giving these files a custom extension (like |
Didn't we stop using LFS because the repo hit the quota and broke things?
Will do 👍 |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Thanks for the changes!
!approved-for-mainnet |
This PR builds upon #14030, using the proof cache introduced there to skip the proof generation step on the kimchi side.
Checklist: