Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new NSSL cloud microphysics 3-moment option #702

Merged
merged 58 commits into from
Nov 6, 2023

Conversation

MicroTed
Copy link
Contributor

@MicroTed MicroTed commented Sep 25, 2023

Description

Adds namelist flag (nssl_3moment) and tracer variables to use NSSL 3-moment microphysics option (3-moment for rain, graupel, and hail)

Issue(s) addressed

Supports PR for CCPP: ufs-community/ccpp-physics#110

Also initializes the fscav_aero array to nulls so that the logfile.out doesn't have random memory values and look like a binary file (and sometimes screw up xterm settings with random control codes when the file is viewed with more/less)

Testing

RT with ufs_model has been done on hera. Results change as expected for SDFs that use the NSSL scheme (FV3_rrfs_v1nssl and FV3_WoFS_v0). Also tested on MacOS (intel cpu;gfortran). Weather model branch with FV3/ccpp update is

https://github.com/MicroTed/ufs-weather-model/tree/feature-nssl3m

RT does not include the 3-moment option, but I'm not sure one is really needed.

Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
    Yes, it will change regional_wofs, rrfs_v1nssl, and rrfs_v1nssl_nohailnoccn because of some changes to the NSSL microphysics scheme that is used with the tests.
  • Please commit the regression test log files in your ufs-weather-model branch
    /scratch1/BMC/gsd-fv3-dev/Ted.Mansell/ufs/ufs-nssl3m/tests/RegressionTests_hera.log.nssl3m

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
url = https://github.com/MicroTed/ccpp-physics
branch = ufsdev-nssl3m
Concurrent PR for CCPP: ufs-community/ccpp-physics#110

MicroTed and others added 30 commits October 15, 2021 20:16
Included ccpp suite that turns off pbl and surface layer schemes for better idealized testing.
atmos_cubed_sphere Outdated Show resolved Hide resolved
@grantfirl
Copy link
Collaborator

@MicroTed ufs-community/ccpp-physics#110 is merged. Please revert .gitmodules and update the ccpp/physics submodule pointer to the latest ufs-dev commit: ufs-community/ccpp-physics@c751a5a

@MicroTed
Copy link
Contributor Author

MicroTed commented Nov 6, 2023

@grantfirl Thanks! OK, it should be updated now.

@jkbk2004 jkbk2004 merged commit 0dbc9ed into NOAA-EMC:develop Nov 6, 2023
This was referenced Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants